Change 861830 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[mediawiki/extensions/SearchVue@master] Mobile: Show wiki data description of the article in quick view

https://gerrit.wikimedia.org/r/861830

Change 861830 merged by jenkins-bot:

[mediawiki/extensions/SearchVue@master] Mobile: Show wiki data description of the article in quick view

https://gerrit.wikimedia.org/r/861830

Checked in enwiki betalabs

https://en.m.wikipedia.beta.wmflabs.org/w/index.php?fulltext=search&search=cat&title=Special:Search&ns0=1&quickViewEnableMobile=1&quickView=Cat

Testing notes:

• check local vs central (wikidata) description
• enwiki betalabs only example with an article's description - search for 'cat'.
• wikidata betalabs doesn't allow import from production

I only just noticed this:

Show the <article name> is a <wiki data description> in the with the font and spacing as specified in Figma.

This "<article name> is a <wiki data description>" is flawed in many ways:

• the subject may be plural, in which case it would have to be "are a" rather than "is a"
• the wikidata description may start with a vowel sound, in which case it would have to be "is an" instead of "is a"
• the wikidata description is likely to start with a capital, in which case we'd end up with a stray capital mid-sentence
• and in many other cases, depending on exact content, this concatenated sentence likely won't work

I think it'd be best to just stick with only the description.

Moving back to "needs design" to reconsider.

I have yet to see the Wikidata box on mobile beta cluster so didn't realize this was actually implemented. Or has it not?

We do not do this on the Desktop as the article name is right above the WD description for context. On mobile it may be a little out of context. However it makes sense to not do it based on the various cases outlined above. I am okay with just description.

Since this is marked as done (and I have not yet seen the box) do we need to create a ticket to remove it? Or was it never implemented?

Based on Elena's screenshot it seems like it was implemented. I just can't see enough of these descriptions on beta to have noticed the issues outlined above.

I'm updating the acceptance criteria based on the above and moving this back to "Doing" for the fixes.

Change 884913 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[mediawiki/extensions/SearchVue@master] Mobile: Show wiki data description of the article in quick view

https://gerrit.wikimedia.org/r/884913

Change 884913 merged by jenkins-bot:

[mediawiki/extensions/SearchVue@master] Mobile: Show wiki data description of the article in quick view

https://gerrit.wikimedia.org/r/884913

In T320647#8564954, @Sneha wrote:

Based on Elena's screenshot it seems like it was implemented. I just can't see enough of these descriptions on beta to have noticed the issues outlined above.

Yes, enwiki betalabs has very few examples with wikidata descriptions ( search terms - cat, water, and world).

@Sneha - just double-checking with you. I checked the following spec in FF 109 browser emulator (and in Chrome emulator):

{] Currently the default size of the text is 16 pts. If the full text does not fit then allow it to shrink to 14 pts to fit more text.

enwiki betalabs &quickView=Cat shows font-size: 1.14285em; which is 13.77899 pts.

.quickViewDescription__mobile p

height: 144px;
font-size: 1.14285em;
line-height: 1.6em;

Thanks for checking. The em conversions are not always exact which is okay. But in this case it does seem like the default size is 2 pts smaller than specified. The size is supposed to be dynamic so when there is less space it reduces to what is now. I don't think this is a blocker though but would be nice to do.

In T320647#8576308, @Sneha wrote:

Thanks for checking. The em conversions are not always exact which is okay. But in this case it does seem like the default size is 2 pts smaller than specified. The size is supposed to be dynamic so when there is less space it reduces to what is now. I don't think this is a blocker though but would be nice to do.

Thanks @Sneha for checking!

@SimoneThisDot - I consistently see font-size: 1.14285em; for .quickViewDescription__mobile. It might be some confusion on my part with viewing font-size rendering in browsers. Would be great if you confirm that the following spec doesn't get overridden with anything. Thx!

• Currently the default size of the text is 16 pts. If the full text does not fit then allow it to shrink to 14 pts to fit more text.