Maniphest T320703

VisualEditor can't save pages on de.wikipedia.beta
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	daniel
	Oct 13 2022, 9:21 AM

Description

As reported by @matmarex at T320531#8313224

The change on beta de.wp (T320531) seems to have broken saving changes to existing pages using visual editor. (Opening the editor doesn't fail, only saving/reviewing; and saving new pages also works.)

Testing on https://de.wikipedia.beta.wmflabs.org/wiki/Benutzer:Yatu, I get an error message mentioning HTTP 412 (Precondition Failed).

This happens because when opening VE, it loads the existing page HTML client-side (the request is sent from the JS code in the user's browser, not from the PHP code) from https://de.wikipedia.beta.wmflabs.org/api/rest_v1/page/html/Benutzer%3AYatu?redirect=false&stash=true, which presumably still points to RESTBase. But when saving, it calls the core MediaWiki/Parsoid code, which doesn't have the original stashed HTML, so it fails.

Impact

VE edits fail on de.wikipedia.beta. ~~Once the relevant change goes out with the train, it would make VE edits fail on wikitech, since wikitech also uses VE in "direct" mode.~~ [Will only affect wikis that have $wgVisualEditorRestbaseURL or $wgVisualEditorFullRestbaseURL set].

Notes

Caused by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/827005. We may need to revert.
The relevant config change for beta (T320531) should be kept, so we can observe whether this is still broken.

Details

	Subject	Repo	Branch	Lines +/-
	Beta: set $wmgVisualEditorAccessRestbaseDirectly = false for dewiki.	operations/mediawiki-config	master	+8 -0
	Don't try to contact RESTbase directly when in PHP direct mode.	mediawiki/extensions/VisualEditor	master	+34 -22

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Stalled		None	T324931 Clean up open RESTBase related tickets
In Progress		None	T262315 <CORE TECHNOLOGY> API Migration & RESTbase Sunset
Open		None	T264669 Move VE API from RESTBase into core.
Open		None	T344944 Move Parsoid endpoints out of RESTbase
Resolved		Jgiannelos	T344945 Disable storage of Parsoid content in RESTbase
Resolved		daniel	T329366 Enable WarmParsoidParserCache on all wikis
Resolved		Clement_Goubert	T333528 Increase memory_limit for jobrunners to $wmgMemoryLimitParsoid
Open		None	T344946 Create a mechanism for purging output from (parsoid) HTML endpoints from edge caches (without RESTbase)
Resolved		hnowlan	T357504 Prepare amount of workers to handle enwiki traffic for parsoid endpoints
In Progress		None	T328559 Replace usage of RESTbase parsoid endpoints
Resolved		daniel	T320529 Configure VE backend to use Parsoid directly, instead of calling RESTbase
Resolved		None	T310376 Make VE Action API use Parsoid directly
Resolved	PRODUCTION ERROR	daniel	T320703 VisualEditor can't save pages on de.wikipedia.beta
Resolved		daniel	T320704 When VisualEditor saves an edit, it should use the same backend that the HTML was originally loaded from
Open		MSantos	T334238 Create deprecation plan for public parsoid endpoints
Open		None	T335511 Talk to Google about transitioning REST-API-Crawler-Google from RESTBase endpoints
Open		None	T335512 Transition Enterprise MediaWiki from RESTBase to core page HTML endpoints
Resolved		ROdonnell-WMF	T353286 Test structured-contents parsing with the new WMF update in T335512
Open	BUG REPORT	None	T353689 REST HTML endpoint returning 500 for JSON page
Open	BUG REPORT	None	T353688 REST: Trying to load the content "magic" image description pages leads to redirect loop
Open	BUG REPORT	None	T353687 REST: page content endpoints fail on page "0"
Open	BUG REPORT	None	T362187 REST HTML endpoint returning 500 for the first 3 - 5 calls for several pages
Open		None	T335513 Selective outage of `/wikitext/to/lint` and `/html/to/wikitext` RESTBase endpoints
Resolved		daniel	T350661 Expose parsoid transformation API from MediaWiki core.
Open		None	T359964 Move page lint job outside of restbase request/response cycle to allow completely disabling cassandra writes
Open		None	T361013 Update lint tables independently of changeprop/restbase

Event Timeline

daniel triaged this task as High priority.Oct 13 2022, 9:21 AM

daniel created this task.

daniel added a parent task: T320511: 1.40.0-wmf.6 deployment blockers.

daniel mentioned this in T320511: 1.40.0-wmf.6 deployment blockers.

daniel mentioned this in T320531: Configure VE backend to use Parsoid directly on the beta cluster and testwiki.Oct 13 2022, 9:34 AM

daniel updated the task description. (Show Details)Oct 13 2022, 9:39 AM

daniel removed a parent task: T320511: 1.40.0-wmf.6 deployment blockers.

Change 842365 had a related patch set uploaded (by Daniel Kinzler; author: Daniel Kinzler):

[mediawiki/extensions/VisualEditor@master] Don't try to contact RESTbase directly when in PHP direct mode.

https://gerrit.wikimedia.org/r/842365

gerritbot added a project: Patch-For-Review.Oct 13 2022, 11:22 AM

Change 842365 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Don't try to contact RESTbase directly when in PHP direct mode.

https://gerrit.wikimedia.org/r/842365

Maintenance_bot removed a project: Patch-For-Review.Oct 13 2022, 2:31 PM

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.6; 2022-10-17).Oct 13 2022, 3:00 PM

Change 842858 had a related patch set uploaded (by Daniel Kinzler; author: Daniel Kinzler):

[operations/mediawiki-config@master] Beta: set $wmgVisualEditorAccessRestbaseDirectly = false for dewiki.

https://gerrit.wikimedia.org/r/842858

gerritbot added a project: Patch-For-Review.Oct 14 2022, 5:55 PM

Change 842858 merged by jenkins-bot:

[operations/mediawiki-config@master] Beta: set $wmgVisualEditorAccessRestbaseDirectly = false for dewiki.

https://gerrit.wikimedia.org/r/842858

Maintenance_bot removed a project: Patch-For-Review.Oct 14 2022, 7:30 PM

• ppelberg moved this task from To Triage to Triaged on the VisualEditor board.Oct 20 2022, 3:53 PM

VirginiaPoundstone moved this task from Incoming to Radar on the API Platform board.Oct 25 2022, 2:52 PM

daniel closed this task as Resolved.Dec 6 2022, 1:32 PM

daniel claimed this task.

daniel closed subtask T320704: When VisualEditor saves an edit, it should use the same backend that the HTML was originally loaded from as Resolved.

VisualEditor can't save pages on de.wikipedia.betaClosed, ResolvedPublicPRODUCTION ERRORActions