Maniphest T320751

[Grid] Move main menu checkbox outside of grid container
Closed, DeclinedPublic
Actions

Assigned To

None

Authored By

	bwang
	Oct 13 2022, 6:00 PM

Description

Background

The main menu checkbox impacts Vector's layout, when there's no ToC and the main menu is open, it is 2 column, and when its closed its single column. Because the checkbox is a child of the grid container, we cannot directly update the grid template columns based off the checkbox. Moving the checkbox simplifies our grid styles and help prepare the layout for the full width toggle

AC

no visual changes
the main menu checkbox is outside of .mw-page-container-inner

Developer notes

This task will involve cached HTML changes
This task is ideally done after T318011, which needs to be replaced/moved when the main menu checkbox is moved

Details

	Subject	Repo	Branch	Lines +/-
	POC: move main menu checkbox outside of grid container to simplify layout styles	mediawiki/skins/Vector	master	+22 -37

Customize query in gerrit

Related Objects

Mentioned In: T319449: [M] Create toggle to control the fixed width of the content for Vector 2022 skin
Mentioned Here: T317899: [L] [PageTools] Convert main menu into a dropdown menu
T318011: Remove 'vector-sidebar-container-no-toc' class

Event Timeline

bwang created this task.Oct 13 2022, 6:00 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 13 2022, 6:00 PM

bwang updated the task description. (Show Details)Oct 13 2022, 6:00 PM

Change 842512 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] POC: move main menu checkbox outside of grid container to simplify layout styles

https://gerrit.wikimedia.org/r/842512

gerritbot added a project: Patch-For-Review.Oct 13 2022, 6:06 PM

bwang mentioned this in T319449: [M] Create toggle to control the fixed width of the content for Vector 2022 skin.Oct 17 2022, 5:41 PM

ovasileva subscribed.Oct 17 2022, 8:07 PM

Jdlrobson moved this task from Incoming to Visual Enhancements / Layout on the Desktop Improvements (Vector 2022) board.Oct 18 2022, 5:58 PM

Change 842512 abandoned by Bernard Wang:

[mediawiki/skins/Vector@master] POC: move main menu checkbox outside of grid container to simplify layout styles

Reason:

https://gerrit.wikimedia.org/r/842512

Maintenance_bot removed a project: Patch-For-Review.Oct 20 2022, 5:30 PM

Jdlrobson moved this task from Backlog to Accessibility on the Web-Team-Backlog (Needs Prioritization (Tech)) board.Oct 24 2022, 9:40 PM

bwang moved this task from Accessibility to Vector code cleanup on the Web-Team-Backlog (Needs Prioritization (Tech)) board.Oct 25 2022, 6:37 PM

This will be fixed by T317899, which will make the checkbox irrelevant to the grid layout. Instead, the main menu pinned classes will update the grid layout

bwang closed this task as Declined.Oct 27 2022, 6:11 PM

[Grid] Move main menu checkbox outside of grid containerClosed, DeclinedPublicActions