Maniphest T320753

Make it easier to relocate a Reply Tool you've opened on mobile
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	ppelberg
	Oct 13 2022, 6:13 PM

Description

In T319148, we fixed an issue that had been causing the mobile Reply Tool to become "disassociated" from sections that contain 1 comment.

In doing the above, we re-encountered a related usability issue: It can be difficult for people to relocate/return to a comment they've started drafting

This task involves the work for addressing said usability issue.

Story

As someone who has started drafting a comment and needs to scroll the talk page to refer back to something someone said previously such that the comment I started drafting with the Reply Tool is no longer in view, I need an easy way to relocate/return to the comment I started drafting, so that I can finish expressing what I'd started with all of the context I need in mind.

Requirements

Meta

Platform(s): Mobile
Skin(s): Minerva Neue
DiscussionTools state: enabled

UX
Prevent people from collapsing the section they have a Reply Tool open within so that they gain access to the omnipresent Return to Reply button that appears when they scroll the Reply Tool off-screen. See T319148#8308834 [i] .|

Done

An Approach is decided upon
Requirements are documented
Requirements are implemented

i. Note: in implementing this approach, people would NOT be prevented from collapsing/expanding other sections.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Disable section toggling on mobile when replying	mediawiki/extensions/DiscussionTools	master	+10 -0
	Add the ability to temporarily disable header toggling	mediawiki/extensions/MobileFrontend	master	+45 -3

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Esanders	T320753 Make it easier to relocate a Reply Tool you've opened on mobile
		Resolved		ovasileva	T328981 [For editing team] It should be possible for other extensions to disable section collapsing on the mobile site

Event Timeline

ppelberg created this task.Oct 13 2022, 6:13 PM

Restricted Application added a subscriber: Masumrezarock100. · View Herald TranscriptOct 13 2022, 6:13 PM

ppelberg moved this task from Inbox to Ready to Be Worked On on the Editing-team (Kanban Board) board.Oct 13 2022, 6:13 PM

ppelberg moved this task from Backlog to Triaged on the DiscussionTools board.

ppelberg mentioned this in T319148: Reply Tool (mobile) remains visible when section is collapsed.

Assigning this over to @nayoub to review the approach @Esanders proposed and created this Patch Demo for:
https://patchdemo.wmflabs.org/wikis/4d9ad50c24/wiki/Talk:DiscussionTools?mobileaction=toggle_view_mobile

Thanks, @ppelberg & @Esanders!
Looks great, my only concern is that when the keyboard is opened then I'm not seeing the "Return to reply" button (since the keyboard is on top of it).
I wonder if we should place the button at the top of the screen then?

nayoub reassigned this task from nayoub to Esanders.Oct 24 2022, 4:23 PM

nayoub moved this task from Design Review to Blocked / Needs More Work on the Editing-team (Kanban Board) board.

In T320753#8334473, @nayoub wrote:

Looks great, my only concern is that when the keyboard is opened then I'm not seeing the "Return to reply" button (since the keyboard is on top of it).
I wonder if we should place the button at the top of the screen then?

Per the conversations we had offline as a team yesterday:

We are going to move forward with deploying the user experience this patch demo implements: Prevent people from collapsing the section they have a Reply Tool open within so that they gain access to the omnipresent Return to Reply button. See T319148#8308834.
We are going to file a ticket for the issue @nayoub named in T320753#8334473
- Note: we are NOT going to address this issue right now for two reasons: A) as @matmarex explained offline and in T218414#5027607, "affixing" the Return to reply button would open up a host of other UX issues and// B) we are assuming that people will intuitively know to tap the keyboard to return to the Reply Tool that has since disappeared from their view

ppelberg updated the task description. (Show Details)Oct 25 2022, 9:55 PM

Next up:

1. @Esanders to relate the patches that were required to create this patch demo to this task
2. Editing Engineering to code review said patches

ppelberg mentioned this in T321628: Make it easier to relocate a Reply Tool (mobile) once cursor is focused within it.Oct 25 2022, 10:03 PM

ppelberg moved this task from Blocked / Needs More Work to Ready to Be Worked On on the Editing-team (Kanban Board) board.

Aklapper added a project: Mobile.Oct 26 2022, 3:45 AM

Change 842958 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/DiscussionTools@master] WIP Disable section toggling on mobile when replying

https://gerrit.wikimedia.org/r/842958

Change 842957 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/MobileFrontend@master] WIP Add the ability to temporarily disable header toggling

https://gerrit.wikimedia.org/r/842957

ppelberg edited parent tasks, added: T321961: [Config Change] Start mobile DiscussionTools A/B test; removed: T298062: [A/B Test] Run an A/B test to evaluate impact of mobile DiscussionTools.Nov 23 2022, 2:21 AM

ppelberg edited parent tasks, added: T298060: [RELEASE TICKET] Offer Mobile DiscussionTools at All Wikis; removed: T321961: [Config Change] Start mobile DiscussionTools A/B test.Nov 23 2022, 4:51 PM

ppelberg moved this task from Ready to Be Worked On to Code Review on the Editing-team (Kanban Board) board.Jan 21 2023, 12:59 AM

Ed marked the patches as work-in-progress, I'm not sure what work is still to be done.

ovasileva subscribed.Jan 31 2023, 6:40 PM

Jdlrobson added a project: Web-Team-Backlog-Archived (Web Team FY2022-23 Q3 Sprint 3).Jan 31 2023, 6:44 PM

I've broken out the web-team portion of this into T328981 so we can estimate it separately. Please feel free to edit the request if I've not captured it correctly.

Jdlrobson mentioned this in T328981: [For editing team] It should be possible for other extensions to disable section collapsing on the mobile site.Feb 13 2023, 11:47 PM

Change 842957 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/MobileFrontend@master] Add the ability to temporarily disable header toggling

https://gerrit.wikimedia.org/r/842957

Change 842957 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Add the ability to temporarily disable header toggling

https://gerrit.wikimedia.org/r/842957

Esanders moved this task from Blocked / Needs More Work to Code Review on the Editing-team (Kanban Board) board.Mar 6 2023, 3:02 PM

Change 842958 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Disable section toggling on mobile when replying

https://gerrit.wikimedia.org/r/842958

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.27; 2023-03-13).Mar 13 2023, 3:01 PM