Page MenuHomePhabricator

"Start a discussion" and "Read as wiki page" buttons have incorrect margins
Closed, ResolvedPublic

Description

On talk pages that A) have not been created yet and B) have access to the empty state experience implemented as part of T270323, the Start a discussion and Read as wiki page buttons seem to conflict, or at least, not compliment one another.

This task involves with revising how these two buttons appear in the time between now and when we are planning to converge on a single talk page view (T280417) which would, in effect, remove the Read as wiki page view and button all together.

Behavior

❗️Actual😊 Desired
Screen Shot 2022-10-12 at 3.23.11 PM.png (1×794 px, 182 KB)
ReadasWikipage.png (1×736 px, 235 KB)
Notice how the two buttons look as if they're "smooshed" together?The Start a discussion and Read as wiki page buttons appear to be less "on top" of one another/conjoined so that people can clearly differentiate between the two and not be lead to question which of the two buttons they ought to tap when trying to start a new discussion

Done

  • "Desired" behavior is defined
  • "Desired" behavior is implemented

Event Timeline

ppelberg moved this task from Untriaged to Upcoming on the Editing-team board.

Change 851134 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Tweak mobile "Read as wiki page" button placement

https://gerrit.wikimedia.org/r/851134

Esanders renamed this task from "Start a discussion" and "Read as wiki page" buttons seem in tension with one another to "Start a discussion" and "Read as wiki page" buttons have incorrect margins.Nov 2 2022, 9:05 AM

Change 851134 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Tweak mobile "Read as wiki page" button placement

https://gerrit.wikimedia.org/r/851134