Page MenuHomePhabricator

Add "Suggested edits" to new user contributions menu
Closed, ResolvedPublic

Description

As a user (with "Display newcomer homepage" enabled in my preferences), I want easy menu access to all common ways to contribute, including a link to Suggested edits.

Background
A "Contribute" option will be added as a new entry point via the current "Contributions" menu option, leading to a new tab on the Contributions page. T286466

The “Contribute” menu is not visible to users yet (T319362 covers enabling this new menu), but it would be great to have some options ready for the menu when we show it to users.

The Growth team should add Suggested edits to this menu.

Initially, the new tab for Special:Contribute will be shown and connect to the Contributions on mobile only where it is enabled, with the page available via directly going to the Special:Contribute URL on Desktop.

Related work:

  • This patchset (33 lines of code) from the Language team shows how a new option (“Translations”) can be added to the menu.
  • T319306 covers a similar use case to what we will do on Growth: AKA the menu items will depend on certain criteria / preferences.

Design

Mobile
Persistent - Create.png (903×375 px, 48 KB)
Desktop
image.png (1×2 px, 296 KB)

Copy:

Suggested edits
Make small and easy changes (e.g., add a link or copyedit) to improve existing articles.
[View suggested edits]


Acceptance Criteria
Given I navigate to "Contribute" from the menu or directly via Special:Contribute,
When I have "Display newcomer homepage" enabled in my preferences,
Then see a menu item for Suggested edits
And when I tap on the Suggested edits card
Then I navigate to: Special:Homepage&source=specialcontribute&namespace=-1#/homepage/suggested-edits
(From Desktop user is directed to the newcomer homepage, on mobile, the Suggested edits module is opened as a full screen overlay.)

Given I navigate to "Contribute" from the menu,
When I have "Display newcomer homepage" disabled in my preferences,
Then I don't see a menu item for Suggested edits

Completion checklist

Functionality

  • The patches have been code reviewed and merged
  • The task passes its acceptance criteria

Engineering

  • There are existing and passing unit/integration tests
  • Tests for every involved patch should pass
  • Coverage for every involved project should have improved or stayed the same
  • HomepageVisit schema updated to include specialcontribute as a valid referer_route parameter value

Design & QA

  • If the task is UX/Design related: it must be reviewed and approved by the UX/Design team
  • Must be reviewed and approved by Quality Assurance.

Documentation

  • Related and updated documentation done where necessary

Event Timeline

KStoller-WMF renamed this task from Add "Suggested edits" to new mobile User contributions menu to Add "Suggested edits" to new mobile user contributions menu.Oct 14 2022, 5:04 PM
KStoller-WMF raised the priority of this task from Medium to High.Oct 16 2022, 8:34 PM
RHo renamed this task from Add "Suggested edits" to new mobile user contributions menu to Add "Suggested edits" to new user contributions menu.Oct 17 2022, 1:11 PM
RHo updated the task description. (Show Details)

Change 850124 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] HomepageHooks: Implement onContributeCards hook

https://gerrit.wikimedia.org/r/850124

Change 850125 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[schemas/event/secondary@master] HomepageVisit: Add specialcontribute as valid referer_route

https://gerrit.wikimedia.org/r/850125

Change 850146 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] HomepageVisit: Update to schema version 1.5.0

https://gerrit.wikimedia.org/r/850146

@KStoller-WMF @RHo just wanted to flag that setting the query fragment to take the user to the Suggested Edits module on mobile will still result in a flash of the Homepage contents:

I wonder if it is better to take the user to Special:Homepage, since Suggested Edits is still the main call to action there?

@KStoller-WMF @RHo just wanted to flag that setting the query fragment to take the user to the Suggested Edits module on mobile will still result in a flash of the Homepage contents:

I wonder if it is better to take the user to Special:Homepage, since Suggested Edits is still the main call to action there?

Hi @kostajh - can this use the same fix that was applied to this similar task T298660: [mobile] Post-edit dialog: clicking on "View more suggested edits" should not display Hompepage where the homepage is hidden on mobile?

@KStoller-WMF @RHo just wanted to flag that setting the query fragment to take the user to the Suggested Edits module on mobile will still result in a flash of the Homepage contents:

I wonder if it is better to take the user to Special:Homepage, since Suggested Edits is still the main call to action there?

Hi @kostajh - can this use the same fix that was applied to this similar task T298660: [mobile] Post-edit dialog: clicking on "View more suggested edits" should not display Hompepage where the homepage is hidden on mobile?

Ah, right! Thanks for remembering that. Yes, we can use the same solution to work around the problem.

Change 850125 merged by jenkins-bot:

[schemas/event/secondary@master] HomepageVisit: Add specialcontribute as valid referer_route

https://gerrit.wikimedia.org/r/850125

Change 850146 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] HomepageVisit: Update to schema version 1.5.0

https://gerrit.wikimedia.org/r/850146

Change 850124 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] HomepageHooks: Implement onContributeCards hook

https://gerrit.wikimedia.org/r/850124

EUdoh-WMF subscribed.

Testing: on Chrome v106, Safari v16 and Firefox v106 on macOS Monterey 12.6

  1. Display Newcomer Homepage enabled:

image.png (1×1 px, 289 KB)

  1. Display Newcomer Homepage disabled:

image.png (1×1 px, 278 KB)

  1. Display Newcomer Homepage disabled but navigating to the Special:Homepage&source=specialcontribute&namespace=-1#/homepage/suggested-edits URL

image.png (648×1 px, 208 KB)

  1. Suggested Edits menu opens up from Special:Contribute without glitching. This also works well on a mobile (android) device.

Thank you, @EUdoh-WMF ! I checked Special:Contribute for mobile on testwiki and bnwiki (wmf.12):

Screen Shot 2022-12-05 at 3.31.01 PM.png (1×908 px, 134 KB)
Screen Shot 2022-12-05 at 3.29.18 PM.png (1×936 px, 139 KB)
anon user
Screen Shot 2022-12-05 at 3.26.20 PM.png (1×888 px, 95 KB)

@KStoller-WMF - the main scope of the task as the title suggests - "Add "Suggested edits" to new user contributions menu" is done, as verified by @EUdoh-WMF and by me.

However, the description of the task includes some important features for Special:Contribute page that are not currently present even in betalabs where Special:Contribute is supposed to be fully functioning.
The below specs are also part of two closed tasks:
T319240: [M] The Special:Contributions page should show tabs to Special:Contribute
T286466: Persistent contribution entry point on the mobile navigation menu

Background
A "Contribute" option will be added as a new entry point via the current "Contributions" menu option, leading to a
new tab on the Contributions page. T286466

  • Contributions menu option is not currently present in betalabs but it's present in testwiki wmf.12. Is it a regression issue?
betalabstestwiki wmf.12
Screen Shot 2022-12-05 at 3.50.03 PM.png (1×848 px, 106 KB)
Screen Shot 2022-12-05 at 4.08.38 PM.png (1×956 px, 116 KB)

@Etonkovidova thank you for testing and for your diligence on checking requirements!

My assumption is that the Contributions menu item won't display everywhere until this task is complete: T319362

In other words, I think this task is complete. Sorry if that Acceptance Criteria was somewhat confusing!

@Etonkovidova thank you for testing and for your diligence on checking requirements!

My assumption is that the Contributions menu item won't display everywhere until this task is complete: T319362

In other words, I think this task is complete. Sorry if that Acceptance Criteria was somewhat confusing!

Thank you, @KStoller-WMF! Since the end-to-end QA work was done (and will be done after deployment) the by other team, I just checked the current production (bn.wiki wmf.12) - Suggested edits option is displayed and works as expected.

Screen Shot 2022-12-06 at 10.54.27 AM.png (1×750 px, 132 KB)

I added a note to my post-deployment regression check to keep an eye on the pilots wiki for the feature.