Page MenuHomePhabricator
Create Task
Maniphest T320882

Mirage is no longer compatible with SocialProfile
Closed, ResolvedPublic
Actions

Description

Due to https://gerrit.wikimedia.org/r/c/mediawiki/extensions/SocialProfile/+/444441 (which I apologise, broke Mirage; I only realised after), Mirage's SocialProfileAvatarLookup is broken, since it uses wAvatar::getAvatarUrlPath(), which was removed in that patch.

It seems Mirage is the only one affected by the change from a codesearch.

Details

SubjectRepoBranchLines +/-
Fix SocialProfile compatibilitymediawiki/skins/MirageREL1_38+10 -2
Fix SocialProfile compatibilitymediawiki/skins/MirageREL1_39+10 -2
Fix SocialProfile compatibilitymediawiki/skins/MirageREL1_37+10 -2
Fix SocialProfile compatibilitymediawiki/skins/Miragemaster+10 -2
Customize query in gerrit

Event Timeline

Universal_Omega created this task.Oct 16 2022, 1:37 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 16 2022, 1:37 AM
gerritbot added a comment.Oct 16 2022, 1:59 AM

Change 842901 had a related patch set uploaded (by Universal Omega; author: Universal Omega):

[mediawiki/skins/Mirage@master] Fix SocialProfile compatibility

https://gerrit.wikimedia.org/r/842901

gerritbot added a project: Patch-For-Review.Oct 16 2022, 1:59 AM
Universal_Omega claimed this task.Oct 16 2022, 5:30 AM
gerritbot added a comment.Oct 16 2022, 3:06 PM

Change 842901 merged by jenkins-bot:

[mediawiki/skins/Mirage@master] Fix SocialProfile compatibility

https://gerrit.wikimedia.org/r/842901

Mainframe98 closed this task as Resolved.Oct 16 2022, 3:20 PM
Mainframe98 removed a project: Patch-For-Review.
gerritbot added a comment.Oct 16 2022, 4:09 PM

Change 842903 had a related patch set uploaded (by Universal Omega; author: Universal Omega):

[mediawiki/skins/Mirage@REL1_37] Fix SocialProfile compatibility

https://gerrit.wikimedia.org/r/842903

gerritbot added a project: Patch-For-Review.Oct 16 2022, 4:09 PM

Change 842904 had a related patch set uploaded (by Universal Omega; author: Universal Omega):

[mediawiki/skins/Mirage@REL1_38] Fix SocialProfile compatibility

https://gerrit.wikimedia.org/r/842904

gerritbot added a comment.Oct 16 2022, 4:10 PM

Change 842905 had a related patch set uploaded (by Universal Omega; author: Universal Omega):

[mediawiki/skins/Mirage@REL1_39] Fix SocialProfile compatibility

https://gerrit.wikimedia.org/r/842905

gerritbot added a comment.Oct 16 2022, 4:12 PM

Change 842903 abandoned by Universal Omega:

[mediawiki/skins/Mirage@REL1_37] Fix SocialProfile compatibility

Reason:

actually 1.37 goes EOL next month probably doesn't need backported here

https://gerrit.wikimedia.org/r/842903

gerritbot added a comment.Oct 16 2022, 4:28 PM

Change 842905 merged by jenkins-bot:

[mediawiki/skins/Mirage@REL1_39] Fix SocialProfile compatibility

https://gerrit.wikimedia.org/r/842905

gerritbot added a comment.Oct 16 2022, 4:29 PM

Change 842904 merged by jenkins-bot:

[mediawiki/skins/Mirage@REL1_38] Fix SocialProfile compatibility

https://gerrit.wikimedia.org/r/842904

Maintenance_bot removed a project: Patch-For-Review.Oct 16 2022, 4:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL