@ifried / @gonyeahialam

Do we have requirements or design for this?

@MHorsey-WMF Thanks for bringing this to our attention! No, I don't believe we do have designs yet. @gonyeahialam and @Daan.L: bringing this to your attention. Perhaps this can be worked on in the next day or two? Thanks!

In T320956#8360031, @ifried wrote:

@MHorsey-WMF Thanks for bringing this to our attention! No, I don't believe we do have designs yet. @gonyeahialam and @Daan.L: bringing this to your attention. Perhaps this can be worked on in the next day or two? Thanks!

We can have something like this

In T320956#8363377, @gonyeahialam wrote:

We can have something like this

Yep, I think this would work.

Discussed in Engineering > Design weekly sync-up 23rd Nov

Helptext after radio buttons is not possible
Remove Helptext until after release
https://phabricator.wikimedia.org/T217693 references this issue

Change 860070 had a related patch set uploaded (by Mhorsey; author: Mhorsey):

[mediawiki/extensions/CampaignEvents@master] Implement support for private registration in Special:RegisterForEvent

https://gerrit.wikimedia.org/r/860070

Change 860070 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Implement support for private registration in Special:RegisterForEvent

https://gerrit.wikimedia.org/r/860070

All AC is met and no js registration experience is fully functional:
✅ Participant should be able to choose between public and private registration on Special:RegisterForEvent
✅ The selection should be via radio buttons for public and private registration
✅ The default selection should be public registration
Note: If we cannot add the icons as specified in the prototypes, that is fine

Registering as public participant:

Registering as a private participant:

@MHorsey-WMF a few notes:
Public registration and Private registration should be bold

comp:

build:

The text in the build differs from what is in the comp. I believe this is likely the correct text because it is the same text as in the JS experience in the event privacy modal, but calling it out since it is different.
Also, the font weight in the build is different from what is in the comp.

comp:

build:

The text in the build differs from what is in the comp. I believe this is likely the correct text because it is the same text as in the JS experience in the event privacy modal, but calling it out since it is different.

confirming that text difference between the comp and the build is correct - see T318368. Moving this to design sign off.

@gonyeahialam some design differences between comp and build are noted in T320956#8425919 if you have anything else to add.

Note that the explainer text will be handled separately in T323949

@MHorsey-WMF a few notes:
Public registration and Private registration should be bold

comp:

build:

@vaughnwalters @MHorsey-WMF The text doesn't need to be bold any longer since we have removed the explainer body text.

The text in the build differs from what is in the comp. I believe this is likely the correct text because it is the same text as in the JS experience in the event privacy modal, but calling it out since it is different.
Also, the font weight in the build is different from what is in the comp.

comp:

build:

The text in the build is accurate.

In T320956#8427118, @gonyeahialam wrote:

@vaughnwalters @MHorsey-WMF The text doesn't need to be bold any longer since we have removed the explainer body text.

Also noting that form labels are generally not bold in MW, and while it would be possible to achieve that with a sort of hack, that would probably be inconsistent with other forms.