Page MenuHomePhabricator
Create Task
Maniphest T321103

Avoid Duplicating Serialization Work When Serializing a ZMap
Closed, ResolvedPublic
Actions

Description

The readable but lazy way to accomplish this task was to perform serialization twice. This is inefficient, so we should rework this code.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
wikifunctions: Upgrade evaluators from 2024-07-23-225548 to 2024-08-16-153209operations/deployment-chartsmaster+2 -2
Customize query in gerrit
Related Changes in GitLab:
TitleReferenceAuthorSource BranchDest Branch
Avoid type-converting the same thing twice when converting ZMaps from code.repos/abstract-wiki/wikifunctions/function-evaluator!241apineapine-dedupe-serializationmain
Customize query in GitLab

Related Objects

Event Timeline

cmassaro created this task.Oct 18 2022, 4:26 PM
DVrandecic moved this task from To Triage to Phase κ – Clean-up on the Abstract Wikipedia team board.Oct 18 2022, 6:34 PM
DVrandecic edited projects, added Abstract Wikipedia team (Phase κ – Clean-up); removed Abstract Wikipedia team.
Jdforrester-WMF moved this task from Incoming to Nice-to-haves on the Abstract Wikipedia team (Phase κ – Clean-up) board.Oct 24 2022, 8:23 PM
Jdforrester-WMF moved this task from Phase κ – Clean-up to To triage: Nice-to-haves on the Abstract Wikipedia team board.Nov 7 2022, 5:47 PM
Jdforrester-WMF edited projects, added Abstract Wikipedia team; removed Abstract Wikipedia team (Phase κ – Clean-up).
Jdforrester-WMF triaged this task as Low priority.May 29 2024, 4:46 PM
Jdforrester-WMF added a project: Abstract Wikipedia Fix-It tasks.
Jdforrester-WMF moved this task from To triage: Nice-to-haves to Backlog on the Abstract Wikipedia team board.
CodeReviewBot added a project: Patch-For-Review.Jul 29 2024, 3:08 PM

apine opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/241

Avoid type-converting the same thing twice when converting ZMaps from code.

cmassaro claimed this task.Jul 29 2024, 3:09 PM
CodeReviewBot added a comment.Jul 29 2024, 7:41 PM

ecarg merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/241

Avoid type-converting the same thing twice when converting ZMaps from code.

Maintenance_bot removed a project: Patch-For-Review.Jul 29 2024, 8:31 PM
cmassaro moved this task from Backlog to 25Q1 (Jul–Sep) on the Abstract Wikipedia team board.Jul 30 2024, 1:55 AM
cmassaro edited projects, added Abstract Wikipedia team (25Q1 (Jul–Sep)); removed Abstract Wikipedia team.
cmassaro moved this task from Incoming to Needs Sign-off on the Abstract Wikipedia team (25Q1 (Jul–Sep)) board.
gerritbot added a comment.Aug 20 2024, 1:46 PM

Change #1064032 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2024-07-23-225548 to 2024-08-16-153209

https://gerrit.wikimedia.org/r/1064032

gerritbot added a project: Patch-For-Review.Aug 20 2024, 1:46 PM
gerritbot added a comment.Aug 20 2024, 1:57 PM

Change #1064032 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2024-07-23-225548 to 2024-08-16-153209

https://gerrit.wikimedia.org/r/1064032

Jdforrester-WMF closed this task as Resolved.Aug 23 2024, 1:54 PM
ecarg mentioned this in rMSFE85b526b9a7c8: Avoid type-converting the same thing twice when converting ZMaps from code..Oct 3 2025, 9:42 AM
Maintenance_bot removed a project: Patch-For-Review.Oct 3 2025, 10:36 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits