When storing new permalinks data, update existing rows if possible rather than insert+delete
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• matmarex
	Oct 18 2022, 7:15 PM

Description

When storing new permalinks data after an edit is made, DiscussionTools would currently first store the data for the new revision by inserting new rows into discussiontools_item_revisions, then update some references to point to them, then finally delete the old now-unreferenced rows. @Ladsgroup says (on T315353) that this might cause us to run out of the primary key auto-increment values (one used for each new row) in the foreseeable future. We should change this code to update existing rows whenever possible, rather than insert+delete.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	ThreadItemStore: Update existing rows if possible rather than insert+delete	mediawiki/extensions/DiscussionTools	wmf/1.40.0-wmf.8	+141 -129
	ThreadItemStore: Update existing rows if possible rather than insert+delete	mediawiki/extensions/DiscussionTools	master	+141 -129

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T314973 Improve Topic Subscription support for discussions that are merged, moved, or deleted
Open	None	T315050 Enable people to visit the page the discussion they were subscribed to has been moved to
Open	None	T318449 [Tracking] Improve the sharing of MediaWiki content
Open	None	T318446 [Tracking] Improve sharing link functionality of pages
Open	None	T315507 Introduce support for topic and comment permanent links within the Android and iOS apps
Open	None	T349353 Expose comment/topic permanent links on Special:Contributions
Open	None	T265269 Assist with linking to other comments within the Reply Tool
Resolved	ppelberg	T302011 [Release Ticket] Introduce permalinks on wikitext talk pages
Resolved	DLynch	T365974 Deploy talk page permalinks to en.wiki
Resolved	• matmarex	T315353 Create database tables for permalinks in production wikis, and enable the feature
Resolved	• matmarex	T321121 When storing new permalinks data, update existing rows if possible rather than insert+delete

Event Timeline

• matmarex created this task.Oct 18 2022, 7:15 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 18 2022, 7:15 PM

• matmarex claimed this task.Oct 18 2022, 7:16 PM

• matmarex added a project: Editing-team (Kanban Board).

• matmarex added a parent task: T315353: Create database tables for permalinks in production wikis, and enable the feature.

• matmarex moved this task from Inbox to Doing on the Editing-team (Kanban Board) board.

Change 844573 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] [WIP] ThreadItemStore: Update existing rows if possible rather than insert+delete

https://gerrit.wikimedia.org/r/844573

gerritbot added a project: Patch-For-Review.Oct 20 2022, 2:01 AM

• matmarex moved this task from Backlog to Triaged on the DiscussionTools board.Oct 20 2022, 3:29 PM

• matmarex mentioned this in T321360: Wipe permalinks data from the short-lived deployment.Oct 20 2022, 9:35 PM

• matmarex moved this task from Doing to Code Review on the Editing-team (Kanban Board) board.Oct 21 2022, 10:38 PM

ppelberg moved this task from Code Review to Blocked / Needs More Work on the Editing-team (Kanban Board) board.Oct 31 2022, 11:09 PM

Change 844573 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] ThreadItemStore: Update existing rows if possible rather than insert+delete

https://gerrit.wikimedia.org/r/844573

Maintenance_bot removed a project: Patch-For-Review.Nov 3 2022, 2:30 PM

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.10; 2022-11-14).Nov 3 2022, 3:00 PM

• matmarex moved this task from Blocked / Needs More Work to Ready for Sign Off on the Editing-team (Kanban Board) board.Nov 3 2022, 8:01 PM

• matmarex added a project: Skipped QA.

ppelberg closed this task as Resolved.Nov 4 2022, 11:30 PM

Change 854068 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@wmf/1.40.0-wmf.8] ThreadItemStore: Update existing rows if possible rather than insert+delete

https://gerrit.wikimedia.org/r/854068

gerritbot added a project: Patch-For-Review.Nov 7 2022, 8:17 PM

Change 854068 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@wmf/1.40.0-wmf.8] ThreadItemStore: Update existing rows if possible rather than insert+delete

https://gerrit.wikimedia.org/r/854068

Mentioned in SAL (#wikimedia-operations) [2022-11-07T21:09:06Z] <urbanecm@deploy1002> Started scap: Backport for [[gerrit:854068|ThreadItemStore: Update existing rows if possible rather than insert+delete (T321121)]]

Mentioned in SAL (#wikimedia-operations) [2022-11-07T21:09:26Z] <urbanecm@deploy1002> urbanecm and matmarex: Backport for [[gerrit:854068|ThreadItemStore: Update existing rows if possible rather than insert+delete (T321121)]] synced to the testservers: mwdebug1001.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet

Mentioned in SAL (#wikimedia-operations) [2022-11-07T21:16:37Z] <urbanecm@deploy1002> Finished scap: Backport for [[gerrit:854068|ThreadItemStore: Update existing rows if possible rather than insert+delete (T321121)]] (duration: 07m 30s)

Maintenance_bot removed a project: Patch-For-Review.Nov 7 2022, 9:31 PM

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.8; 2022-10-31); removed MW-1.40-notes (1.40.0-wmf.10; 2022-11-14).Nov 7 2022, 10:00 PM

When storing new permalinks data, update existing rows if possible rather than insert+deleteClosed, ResolvedPublicActions

Description

Details

Related ObjectsSearch...

Event Timeline

When storing new permalinks data, update existing rows if possible rather than insert+delete
Closed, ResolvedPublic
Actions

Related Objects
Search...