Page MenuHomePhabricator
Create Task
Maniphest T321162

[buildservice] allow running deploy.sh without passing a parameter
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

To fully comply with the deployment standard:
https://wikitech.wikimedia.org/wiki/Wikimedia_Cloud_Services_team/EnhancementProposals/Decision_record_T303931_k8s_standard_deployment_code_pattern

the deploy.sh script should allow running it without parameters in production.

This task is to add a check similar to:
https://gerrit.wikimedia.org/r/c/labs/tools/registry-admission-webhook/+/841539

to the deploy.sh script in the buildservice repo:
https://github.com/toolforge/buildservice

Related Objects
Search...

Event Timeline

dcaro created this task.Oct 19 2022, 9:12 AM
dcaro triaged this task as High priority.
dcaro added a parent task: T267374: [tbs.beta] Create a toolforge build service beta release.
dcaro added a project: Toolforge Build Service.
dcaro moved this task from Backlog to To be Discussed on the Toolforge Build Service board.Oct 19 2022, 12:33 PM
dcaro assigned this task to Slst2020.Oct 25 2022, 1:43 PM
dcaro removed Slst2020 as the assignee of this task.
dcaro added a subscriber: Slst2020.
dcaro assigned this task to komla.Oct 25 2022, 1:54 PM
KHernandez-WMF set the point value for this task to 3.Oct 25 2022, 1:54 PM
KHernandez-WMF moved this task from To be Discussed to Discussed/Estimated on the Toolforge Build Service board.
KHernandez-WMF moved this task from Discussed/Estimated to Iteration 03 on the Toolforge Build Service board.Oct 25 2022, 3:37 PM
KHernandez-WMF edited projects, added Toolforge Build Service (Iteration 03); removed Toolforge Build Service.
komla changed the task status from Open to In Progress.Nov 8 2022, 2:12 PM
komla moved this task from Next Up to In Progress on the Toolforge Build Service (Iteration 03) board.
KHernandez-WMF moved this task from Iteration 03 to Iteration 04 on the Toolforge Build Service board.Nov 8 2022, 11:25 PM
KHernandez-WMF edited projects, added Toolforge Build Service (Iteration 04); removed Toolforge Build Service (Iteration 03).
KHernandez-WMF moved this task from Next Up to In Progress on the Toolforge Build Service (Iteration 04) board.
komla added a comment.Nov 15 2022, 12:34 AM

I've sent a PR for this on Github

dcaro added a comment.Nov 17 2022, 4:30 PM

For reference, the PR is https://github.com/toolforge/buildservice/pull/14

KHernandez-WMF moved this task from Iteration 04 to Iteration 05 on the Toolforge Build Service board.Nov 22 2022, 5:50 PM
KHernandez-WMF edited projects, added Toolforge Build Service (Iteration 05); removed Toolforge Build Service (Iteration 04).
KHernandez-WMF moved this task from Next Up to In Progress on the Toolforge Build Service (Iteration 05) board.
KHernandez-WMF moved this task from Iteration 05 to Iteration 06 on the Toolforge Build Service board.Dec 7 2022, 3:26 PM
KHernandez-WMF edited projects, added Toolforge Build Service (Iteration 06); removed Toolforge Build Service (Iteration 05).
KHernandez-WMF moved this task from Next Up to In Progress on the Toolforge Build Service (Iteration 06) board.
KHernandez-WMF moved this task from Iteration 06 to Iteration 07 on the Toolforge Build Service board.Dec 20 2022, 4:57 PM
KHernandez-WMF edited projects, added Toolforge Build Service (Iteration 07); removed Toolforge Build Service (Iteration 06).
KHernandez-WMF moved this task from Next Up to In Progress on the Toolforge Build Service (Iteration 07) board.
KHernandez-WMF moved this task from Iteration 07 to Iteration 08 on the Toolforge Build Service board.Jan 10 2023, 6:23 PM
KHernandez-WMF edited projects, added Toolforge Build Service (Iteration 08); removed Toolforge Build Service (Iteration 07).
KHernandez-WMF moved this task from Next Up to In Progress on the Toolforge Build Service (Iteration 08) board.
Raymond_Ndibe added a project: User-Raymond_Ndibe.Jan 18 2023, 2:36 PM
Raymond_Ndibe subscribed.

going to clean this up so we can merge it

fnegri edited projects, added cloud-services-team; removed cloud-services-team (Kanban).Jan 18 2023, 6:30 PM
fnegri moved this task from Kanban to Inbox on the cloud-services-team board.
komla added a comment.EditedJan 18 2023, 7:14 PM
In T321162#8535077, @Raymond_Ndibe wrote:

going to clean this up so we can merge it

Let me know the nature of the cleanup. Thanks!

Raymond_Ndibe added a comment.Jan 18 2023, 7:54 PM

there were some reviews by David that has been pending for sometime now. I merged this change into master then submitted a follow up patch to address those reviews. that has been merged too. so we can move this to done

Raymond_Ndibe moved this task from In Progress to Done on the Toolforge Build Service (Iteration 08) board.Jan 18 2023, 7:55 PM
komla added a comment.Jan 18 2023, 8:19 PM

On Github?
I've been trying to recover my account there since Nov last year!

Thanks, Raymond!!

KHernandez-WMF closed this task as Resolved.Jan 23 2023, 7:07 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits