Page MenuHomePhabricator
Create Task
Maniphest T321267

[subtask] PHP Warning: preg_match() expects parameter 2 to be string, array given (in Vector Hooks::shouldDisableMaxWidth)
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   PHP Warning: preg_match() expects parameter 2 to be string, array given
exception.trace
from /srv/mediawiki/php-1.40.0-wmf.6/skins/Vector/includes/Hooks.php(829)
#0 [internal function]: MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.40.0-wmf.6/skins/Vector/includes/Hooks.php(829): preg_match(string, array)
#2 /srv/mediawiki/php-1.40.0-wmf.6/skins/Vector/includes/Hooks.php(729): MediaWiki\Skins\Vector\Hooks::shouldDisableMaxWidth(array, Title, array)
#3 /srv/mediawiki/php-1.40.0-wmf.6/includes/HookContainer/HookContainer.php(160): MediaWiki\Skins\Vector\Hooks->onOutputPageBodyAttributes(OutputPage, MediaWiki\Skins\Vector\SkinVector22, array)
#4 /srv/mediawiki/php-1.40.0-wmf.6/includes/HookContainer/HookRunner.php(2711): MediaWiki\HookContainer\HookContainer->run(string, array, array)
#5 /srv/mediawiki/php-1.40.0-wmf.6/includes/OutputPage.php(3436): MediaWiki\HookContainer\HookRunner->onOutputPageBodyAttributes(OutputPage, MediaWiki\Skins\Vector\SkinVector22, array)
#6 /srv/mediawiki/php-1.40.0-wmf.6/includes/skins/SkinMustache.php(63): OutputPage->headElement(MediaWiki\Skins\Vector\SkinVector22)
#7 /srv/mediawiki/php-1.40.0-wmf.6/includes/skins/SkinTemplate.php(177): SkinMustache->generateHTML()
#8 /srv/mediawiki/php-1.40.0-wmf.6/includes/OutputPage.php(2892): SkinTemplate->outputPage()
#9 /srv/mediawiki/php-1.40.0-wmf.6/includes/MediaWiki.php(922): OutputPage->output(boolean)
#10 /srv/mediawiki/php-1.40.0-wmf.6/includes/MediaWiki.php(562): MediaWiki->main()
#11 /srv/mediawiki/php-1.40.0-wmf.6/index.php(50): MediaWiki->run()
#12 /srv/mediawiki/php-1.40.0-wmf.6/index.php(46): wfIndexMain()
#13 /srv/mediawiki/w/index.php(3): require(string)
#14 {main}
Impact
Notes

Started after promoting all wikis to 1.40.0-wmf.6. There were 9 occurrences all coming from jawiki. I am not sure why they hit /w/wiki.phtml isn't it a long deprecated entry point?

Some entries have $acunetix passed as parameters, maybe that is the penetration testing system https://www.acunetix.com/

Details

Request URL
https://ja.wikipedia.org/w/wiki.phtml?action%5B%5D=*&title=*
Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Use WebRequest directly in Hooks::shouldDisableMaxWidthmediawiki/skins/Vectormaster+24 -6
Customize query in gerrit

Related Objects
Search...

Event Timeline

hashar created this task.Oct 20 2022, 8:36 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 20 2022, 8:36 AM
hashar added a subscriber: Umherirrender.Oct 20 2022, 8:39 AM

Some URLs have the string acunetix which is also referred to by T321133 which says:

In T321133#8327500, @Umherirrender wrote:

Looks like some fuzzying urls (internet search for acunetix shows some related result)

Regardless the condition should be caught/handled ;)

hashar mentioned this in T321133: PHP Notice: Array to string conversion (in SpecialNewFiles.php).Oct 20 2022, 8:39 AM
hashar updated the task description. (Show Details)Oct 20 2022, 8:42 AM
Krinkle added a project: Vector 2022.Oct 20 2022, 3:30 PM
Krinkle renamed this task from PHP Warning: preg_match() expects parameter 2 to be string, array given to PHP Warning: preg_match() expects parameter 2 to be string, array given (in Vector Hooks::shouldDisableMaxWidth).Oct 20 2022, 3:34 PM
thcipriani moved this task from Untriaged to Oct 2022 on the Wikimedia-production-error board.Oct 20 2022, 3:41 PM
Umherirrender claimed this task.Oct 20 2022, 6:37 PM
In T321267#8331386, @hashar wrote:

Some URLs have the string acunetix which is also referred to by T321133 which says:

In T321133#8327500, @Umherirrender wrote:

Looks like some fuzzying urls (internet search for acunetix shows some related result)

Regardless the condition should be caught/handled ;)

Yes, the backend should handle invalid values from the frontend better as a type error or fatal

When using WebRequest::getValues the array values are not discarded as done in WebRequest::getVal and mention there: "Array values are discarded for security reasons. Use {@see getArray} or {@see getIntArray}."
Requesting each value from WebRequest as needed is better as all and using it as array

gerritbot added a comment.Oct 20 2022, 6:37 PM

Change 845038 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/skins/Vector@master] Use WebRequest directly in Hooks::shouldDisableMaxWidth

https://gerrit.wikimedia.org/r/845038

gerritbot added a project: Patch-For-Review.Oct 20 2022, 6:37 PM
Jdlrobson edited projects, added: Web-Team-Backlog-Archived (Kanbanana-2022-23-Q2); removed: Web-Team-Backlog-Archived.Oct 21 2022, 7:22 PM
Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog-Archived (Kanbanana-2022-23-Q2) board.
Jdlrobson subscribed.Oct 21 2022, 10:30 PM

How can I test this one? Patch looks fine but have no idea what index.phtml is and how to replicate this on my local machine...

Umherirrender added a comment.Oct 21 2022, 10:47 PM
In T321267#8336406, @Jdlrobson wrote:

How can I test this one? Patch looks fine but have no idea what index.phtml is and how to replicate this on my local machine...

It fails also for the "normal" index.php, there is a rewrite rule from wiki.phtml to index.php in the config (not sure where)

Use

index.php?title=NotMainPage&action[]=history&useskin=vector-2022

with

$wgVectorMaxWidthOptions['exclude']['querystring']['action'] = '(history|edit)';
Jdlrobson added a comment.Oct 21 2022, 10:53 PM

Can replicate that locally now, thanks!

Jdlrobson renamed this task from PHP Warning: preg_match() expects parameter 2 to be string, array given (in Vector Hooks::shouldDisableMaxWidth) to [subtask] PHP Warning: preg_match() expects parameter 2 to be string, array given (in Vector Hooks::shouldDisableMaxWidth).Oct 21 2022, 10:54 PM
Jdlrobson moved this task from Upcoming to QA in Prod on the Web-Team-Backlog-Archived (Kanbanana-2022-23-Q2) board.
Jdlrobson added a parent task: T319447: [M] Create user preference to turn fixed width on and off.
gerritbot added a comment.Oct 21 2022, 11:19 PM

Change 845038 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Use WebRequest directly in Hooks::shouldDisableMaxWidth

https://gerrit.wikimedia.org/r/845038

Umherirrender closed this task as Resolved.Oct 21 2022, 11:20 PM
Umherirrender removed a project: Patch-For-Review.
Jdlrobson moved this task from QA in Prod to Ready for Signoff on the Web-Team-Backlog-Archived (Kanbanana-2022-23-Q2) board.Oct 21 2022, 11:29 PM
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.7; 2022-10-24).Oct 22 2022, 12:00 AM
hashar added a comment.Oct 24 2022, 8:00 AM

Thank you @Umherirrender , I really appreciate this kind of bugs to be addressed so quickly, the MediaWiki log errors stream thanks you as well!

hashar mentioned this in T321471: MWException: HTML attribute value can not contain a list of values (in Special:ListFiles).Oct 24 2022, 8:15 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits