Report language version in the metadata map & dialog
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	DMartin-WMF
	Oct 20 2022, 7:15 PM

Description

When a function call is performed, using a supported-language implementation (Python, JavaScript, etc.), record the language version (e.g., Python 3.10.8) in the metadata map (Z22K2), and show it whenever the corresponding metadata dialog is displayed.

Note: It'll make sense to do this after settling the relevant operational details of the deployment of evaluators and executors.

Desired behavior/Acceptance criteria (returned value, expected error, performance expectations, etc.)

Language version should be recorded and displayed, as described above, whenever a supported-language implementation is executed.

Completion checklist

Before closing this task, review one by one the checklist available here: https://www.mediawiki.org/wiki/Abstract_Wikipedia_team/Definition_of_Done#Back-end_Task/Bug_completion_checklist

Details

	Subject	Repo	Branch	Lines +/-
	Follow-up c9a1cded: Add new i18n key to manifest too	mediawiki/extensions/WikiLambda	master	+1 -0
	Add programmingLanguageVersion metadata key to i18n.	mediawiki/extensions/WikiLambda	master	+5 -1

Customize query in gerrit

	Title	Reference	Author	Source Branch	Dest Branch
	Also report programming language version information in metadata.	repos/abstract-wiki/wikifunctions/function-evaluator!60	apine	apine-language-versions	main

Customize query in GitLab

Related Objects

Mentioned In: T314960: Add some environment meta-data to the response envelope

Event Timeline

DMartin-WMF created this task.Oct 20 2022, 7:15 PM

DMartin-WMF mentioned this in T314960: Add some environment meta-data to the response envelope.Oct 20 2022, 7:24 PM

DVrandecic moved this task from To triage to Phase κ – Clean-up on the Abstract Wikipedia team board.Oct 25 2022, 6:45 PM

DVrandecic edited projects, added Abstract Wikipedia team (Phase κ – Clean-up); removed Abstract Wikipedia team.

Jdforrester-WMF moved this task from Incoming to Nice-to-haves on the Abstract Wikipedia team (Phase κ – Clean-up) board.Oct 25 2022, 6:50 PM

Jdforrester-WMF moved this task from Phase κ – Clean-up to To triage: Nice-to-haves on the Abstract Wikipedia team board.Nov 7 2022, 5:28 PM

Jdforrester-WMF edited projects, added Abstract Wikipedia team; removed Abstract Wikipedia team (Phase κ – Clean-up).

Jdforrester-WMF triaged this task as Low priority.Oct 3 2023, 6:19 PM

Jdforrester-WMF moved this task from To triage: Nice-to-haves to Backlog on the Abstract Wikipedia team board.

cmassaro changed the task status from Open to In Progress.Oct 4 2023, 12:07 PM

cmassaro claimed this task.

cmassaro moved this task from Backlog to In Progress on the Abstract Wikipedia team board.

apine opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/60

Also report programming language version information in metadata.

Change 964086 had a related patch set uploaded (by Jforrester; author: Cory Massaro):

[mediawiki/extensions/WikiLambda@master] Add programmingLanguageVersion metadata key to i18n.

https://gerrit.wikimedia.org/r/964086

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/60

Also report programming language version information in metadata.

Change 964086 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Add programmingLanguageVersion metadata key to i18n.

https://gerrit.wikimedia.org/r/964086

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.30; 2023-10-10).Oct 9 2023, 2:00 PM

Maintenance_bot removed a project: Patch-For-Review.Oct 9 2023, 2:11 PM

cmassaro moved this task from In Progress to Verify in production on the Abstract Wikipedia team board.Oct 9 2023, 3:37 PM

Works in wikifunctions beta, e.g.

Screen Shot 2023-10-11 at 11.38.45 AM.png (1×1 px, 216 KB)

https://wikifunctions.beta.wmflabs.org/view/en/Z10054

Translations are in place too (but not displayed in beta): MediaWiki:wikilambda-functioncall-metadata-execution-programming-language-version.

wikifunctions wmf.30 does not display the language version, e.g. https://www.wikifunctions.org/view/en/Z10065

Screen Shot 2023-10-11 at 11.56.32 AM.png (1×1 px, 290 KB)

Change 966896 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Follow-up c9a1cded: Add new i18n key to manifest too

https://gerrit.wikimedia.org/r/966896

gerritbot added a project: Patch-For-Review.Oct 18 2023, 4:33 PM

Change 966896 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Follow-up c9a1cded: Add new i18n key to manifest too

https://gerrit.wikimedia.org/r/966896

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.2; 2023-10-24).Oct 18 2023, 5:00 PM

Maintenance_bot removed a project: Patch-For-Review.Oct 18 2023, 5:10 PM

Checked in wikifunctions beta (https://wikifunctions.beta.wmflabs.org/view/en/Z10054)

the language version is displayed with a correct label

before the fix	after the fix

In wikifunctions wmf.1 (https://www.wikifunctions.org/view/en/Z10065) the label is displayed, but not the Programming language version message text:

Screen Shot 2023-10-19 at 3.12.35 PM.png (1×1 px, 225 KB)

In T321341#9267046, @Etonkovidova wrote:

In wikifunctions wmf.1 (https://www.wikifunctions.org/view/en/Z10065) the label is displayed, but not the Programming language version message text:

Yup, the code was added in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikiLambda/+/964086 but we forgot to add it to the manifest, fixed in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikiLambda/+/966896 (which went out in 1.42.0-wmf.2).

	F38902331: Screen Shot 2023-10-19 at 3.12.35 PM.png
	Oct 19 2023, 10:45 PM

	F38901472: Screen Shot 2023-10-19 at 3.36.57 PM.png
	Oct 19 2023, 10:45 PM

	F38209807: Screen Shot 2023-10-11 at 11.56.32 AM.png
	Oct 11 2023, 6:57 PM

	F38209721: Screen Shot 2023-10-11 at 11.38.45 AM.png
	Oct 11 2023, 6:57 PM

Report language version in the metadata map & dialogClosed, ResolvedPublicActions

Description

Description

Completion checklist

Details

Related Objects

Event Timeline

Report language version in the metadata map & dialog
Closed, ResolvedPublic
Actions