| Tgr | |
| Oct 20 2022, 7:47 PM |
| F36961374: Screenshot 2023-04-24 at 05.00.54.png | |
| Apr 24 2023, 4:02 AM |
| F36908313: Screenshot 2023-03-12 at 23.16.42.png | |
| Mar 12 2023, 11:23 PM |
| F35605507: codesearch-repo-cutoff.png | |
| Oct 20 2022, 7:47 PM |
The UI isn't actually truncated, but the lack of an added margin does indeed make this non-obvious. At a smaller zoom level, it becomes clearer:
There are at most 20 suggestions at any given time. It's modelled to actively avoid implying that one has to scroll through the entire list, and encourage liberal use of fuzzysearch (T299768#8004383), so typing any characters you know will get you closer, akin to the "quick open" modal in a text editor, or browser address bar, which doesn't list every file or every history/bookmark entry on the system for scrolling by default either.
I'll add a bottom margin, and a placeholder value to the input field to make this more apparent but suggesting we don't block T263354 on it, as the other repos being in the list was by design. Happy to reconsider but it played a significant part in making the UI render fast, and for the typeahead to be fast by not re-rendering 1000s of repos that one would never realistically scroll to or select to when most wouldn't go there and there's another way to get there.
Change 897389 had a related patch set uploaded (by Krinkle; author: Krinkle):
[labs/codesearch@master] frontend: Add margin-bottom to dropdown menu
Change 897390 had a related patch set uploaded (by Krinkle; author: Krinkle):
[labs/codesearch@master] frontend: Add placeholder to repo selector input
Change 897389 merged by jenkins-bot:
[labs/codesearch@master] frontend: Add margin-bottom to dropdown menu
Change 897390 merged by jenkins-bot:
[labs/codesearch@master] frontend: Add placeholder to repo selector input
In addition to the placeholder text and margin, I've also added "Limited to 50 suggestions" to the dropdown menu when results are truncated.
https://gerrit.wikimedia.org/r/c/labs/codesearch/+/898238
