Page MenuHomePhabricator
Create Task
Maniphest T321376

[M] Update position of SearchVue panel to match interwiki widget position
Closed, ResolvedPublic
Actions

Description

T312269 changes the position of the interwiki widget.

  • SearchVue right-side should align with the interwiki right side
  • SearchVue width should be "larger" than interwiki
  • SearchVue should not cover the search result or the arrow
  • In cases where the screen is too narrow to display interwiki results on the side, SearchVue should not be wired up! (stopgap until this is dealt with in T321377)
  • The arrow should ALWAYS be present when a quick view is open ( to provide context to the user on which searchVue is open)

Details

SubjectRepoBranchLines +/-
Update position of SearchVue panel to match interwiki widget positionmediawiki/extensions/SearchVuemaster+394 -52
Customize query in gerrit

Related Objects

Event Timeline

matthiasmullie created this task.Oct 21 2022, 8:49 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 21 2022, 8:49 AM
matthiasmullie added a subscriber: Sneha.Oct 21 2022, 8:49 AM
matthiasmullie updated the task description. (Show Details)Oct 21 2022, 9:09 AM
matthiasmullie moved this task from Incoming to Ready for Development on the Structured-Data-Backlog (Current Work) board.Oct 21 2022, 9:15 AM
CBogen moved this task from Ready for Development to Ready for Estimation on the Structured-Data-Backlog (Current Work) board.Oct 24 2022, 1:41 PM
CBogen updated the task description. (Show Details)Nov 2 2022, 4:53 PM
CBogen renamed this task from Update position of SearchVue panel to match interwiki widget position to [M] Update position of SearchVue panel to match interwiki widget position.Nov 2 2022, 4:56 PM
Sneha added a comment.Nov 2 2022, 4:58 PM

The width of the quick view should cover interwiki widgets but it does not necessarily need to cover the height of the interwiki widgets. Quick view could appear in different position vertically and can also vary in size vertically depending on the content so it may not cover the interwiki widget vertically at all times.

CBogen moved this task from Ready for Estimation to Ready for Development on the Structured-Data-Backlog (Current Work) board.Nov 2 2022, 5:43 PM
SimoneThisDot changed the task status from Open to In Progress.Nov 21 2022, 11:24 AM
SimoneThisDot claimed this task.
SimoneThisDot moved this task from Ready for Development to Doing on the Structured-Data-Backlog (Current Work) board.
gerritbot added a comment.Nov 21 2022, 9:54 PM

Change 859140 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[mediawiki/extensions/SearchVue@master] Update position of SearchVue panel to match interwiki widget position

https://gerrit.wikimedia.org/r/859140

gerritbot added a project: Patch-For-Review.Nov 21 2022, 9:54 PM
SimoneThisDot moved this task from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.Nov 21 2022, 10:03 PM
SimoneThisDot added a comment.Nov 22 2022, 9:08 PM

After a discussion with Sneha we agreed:

  • the right handside of the searhcVue is aligned on the right
  • The width of the search Preview does not change

Please use this as a guideline: https://www.figma.com/file/86M7oLZplSxXKwKJR59mIK/Special%3ASearch-on-Wikipedia?node-id=1407%3A14423&t=X2Pv2A6VFCzNBZwi-0

SimoneThisDot moved this task from Code Review to Doing on the Structured-Data-Backlog (Current Work) board.Nov 22 2022, 9:08 PM
SimoneThisDot mentioned this in T322074: [betalabs] QuickView overlaps search results when screen is resizing.Nov 23 2022, 8:10 AM
matthiasmullie merged a task: T322074: [betalabs] QuickView overlaps search results when screen is resizing.Nov 23 2022, 9:03 AM
matthiasmullie added subscribers: Etonkovidova, vadim-kovalenko, SimoneThisDot, CBogen.
SimoneThisDot updated the task description. (Show Details)Nov 23 2022, 9:29 AM
SimoneThisDot added a comment.Nov 23 2022, 9:31 AM

The body of the ticket has been updated after a discussion with Sneha and the patch changed to gather for the new requirements

SimoneThisDot moved this task from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.Nov 23 2022, 9:32 AM
gerritbot added a comment.Nov 24 2022, 3:46 PM

Change 859140 merged by jenkins-bot:

[mediawiki/extensions/SearchVue@master] Update position of SearchVue panel to match interwiki widget position

https://gerrit.wikimedia.org/r/859140

SimoneThisDot mentioned this in rESVUcf142e013a89: Update position of SearchVue panel to match interwiki widget position.Nov 24 2022, 3:47 PM
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.12; 2022-11-28).Nov 24 2022, 4:01 PM
Maintenance_bot removed a project: Patch-For-Review.Nov 24 2022, 4:30 PM
SimoneThisDot moved this task from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.Nov 28 2022, 12:34 PM
Etonkovidova updated the task description. (Show Details)Jan 5 2023, 3:08 AM
Etonkovidova moved this task from Needs QA to Verify on Production on the Structured-Data-Backlog (Current Work) board.
Etonkovidova closed this task as Resolved.Jan 7 2023, 2:48 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL