Page MenuHomePhabricator
Create Task
Maniphest T321377

[S] Figure out how to show SearchVue on small screens in non-mobile skins
Closed, ResolvedPublic
Actions

Description

In T312269, it was determined that screens below 1000px simply don't have enough width available in order to display both search results + interwiki widget side by side. Interwiki widget results will simply be displayed below the search results.

This also means that we have no room on the side for the SearchVue panel.
What can we do?

After careful consideration and exploration the following acceptance criteria will be used to address the problem stated above.

  • Show two columns layout similar to desktop down to the tablet size of 768px 720px (as discussed in this thread). Which means SearchVue will work as it works on desktop.

    Link to Figma
    768px.png (1,807×1,197 px, 165 KB)

For tablet screens smaller than 768 px that do not use mobile skin:
A separate ticket is created to figure out how to show search preview on smaller devices T324137

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Change IW breakpoint to be enabled on smaller screenMatthias Mulliemediawiki/corewmf/1.40.0-wmf.14+5 -5
Always show search results at full widthMatthias Mulliemediawiki/skins/MinervaNeuewmf/1.40.0-wmf.14+24 -0
Make SearchVue work on smaller screenSimone Cuomomediawiki/extensions/SearchVuemaster+5 -4
Change IW breakpoint to be enabled on smaller screenSimone Cuomomediawiki/coremaster+5 -5
Always show search results at full widthMatthias Mulliemediawiki/skins/MinervaNeuemaster+24 -0
Customize query in gerrit

Related Objects

Event Timeline

matthiasmullie created this task.Oct 21 2022, 9:08 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 21 2022, 9:08 AM
matthiasmullie renamed this task from Figure out how to to Figure out how to show SearchVue on small screens in non-mobile skins.Oct 21 2022, 9:09 AM
matthiasmullie mentioned this in T321376: [M] Update position of SearchVue panel to match interwiki widget position.
matthiasmullie moved this task from Incoming to Needs Design on the Structured-Data-Backlog (Current Work) board.
matthiasmullie mentioned this in T312269: Responsive layouts for special:search page.Oct 21 2022, 9:13 AM
SimoneThisDot subscribed.Nov 16 2022, 11:12 AM

I would suggest waiting for T312269 to be merged, before completing this task

Sneha updated the task description. (Show Details)Nov 25 2022, 9:24 PM
Sneha moved this task from Needs Design to Ready for Estimation on the Structured-Data-Backlog (Current Work) board.
SimoneThisDot added a comment.Nov 30 2022, 10:14 AM

@Sneha just to let you know it seems like this ticket should either be split in two or will require multiple Patches to be completed:

  1. In Mediawiki core - Speacial:Search page
  2. Remove thumbnail on small screen
  3. Move interwiki down (this should already happening now with recent updates of the layout)
  1. In Search Preview
  2. Make the changes to make space and show the preview as required in tablet screens
Sneha mentioned this in T324137: Part 2 of Figure out how to show SearchVue on small screens in non-mobile skins.Nov 30 2022, 6:12 PM
Sneha updated the task description. (Show Details)Nov 30 2022, 6:14 PM
Sneha added a subscriber: vadim-kovalenko.Nov 30 2022, 6:20 PM

@SimoneThisDot Based on the discussion in the estimation meeting I have removed the requirement of showing search preview as part of this ticket. It was estimated as small for two requirements 1) changing the threshold to 768px 2) Not showing thumbnails for screen smaller than 768px.

Re: showing things in single column for smaller devices, I believe it was already discussed as a requirement in some other ticket for smaller devices but I could be wrong. @matthiasmullie @vadim-kovalenko Do we need to put the single column requirement to another ticket or okay to keep here or is it done already?

Also if we are not showing search preview for these devices then we should make sure the tutorial also does not appear. @matthiasmullie @vadim-kovalenko
If removing tutorial is adding work then perhaps we should implement this ticket T324137 as well.

MarkTraceur renamed this task from Figure out how to show SearchVue on small screens in non-mobile skins to [S] Figure out how to show SearchVue on small screens in non-mobile skins.Dec 1 2022, 5:58 PM
MarkTraceur moved this task from Ready for Estimation to Ready for Development on the Structured-Data-Backlog (Current Work) board.
CBogen subscribed.Dec 8 2022, 3:26 PM

@Sneha should this ticket be in Milestone 3, not Milestone 4?

Sneha added a comment.Dec 8 2022, 11:51 PM
This comment was removed by Sneha.
Sneha added a comment.EditedDec 8 2022, 11:54 PM

Sorry realized this ticket needs to be part of Milestone 2. There is another part 2 of this ticket T324137 which should be done in Milestone 3 as it touches smaller mobile devices/tablets.

The solution here was discussed and agreed in our estimation meeting. But I wasn't sure if it was understood or clear when we should do this.

CBogen edited projects, added: SDAW-Search-Improvements (Milestone 2: QuickView MVP); removed: SDAW-Search-Improvements (Milestone 4: Additional QuickView features).Dec 9 2022, 1:39 PM
Sneha updated the task description. (Show Details)Dec 12 2022, 9:38 PM
SimoneThisDot claimed this task.Dec 13 2022, 10:25 AM
SimoneThisDot moved this task from Ready for Development to Doing on the Structured-Data-Backlog (Current Work) board.
SimoneThisDot added a subscriber: Sneha.
gerritbot added a comment.Dec 13 2022, 8:15 PM

Change 867699 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[mediawiki/core@master] Change IW breakpoint to be enabled on smaller screen

https://gerrit.wikimedia.org/r/867699

gerritbot added a project: Patch-For-Review.Dec 13 2022, 8:15 PM

Change 867700 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[mediawiki/extensions/SearchVue@master] Make SearchVue work on smaller screen

https://gerrit.wikimedia.org/r/867700

gerritbot added a comment.Dec 14 2022, 2:43 PM

Change 868090 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):

[mediawiki/skins/MinervaNeue@master] Always show search results at full width

https://gerrit.wikimedia.org/r/868090

gerritbot added a comment.Dec 16 2022, 8:46 AM

Change 867699 merged by jenkins-bot:

[mediawiki/core@master] Change IW breakpoint to be enabled on smaller screen

https://gerrit.wikimedia.org/r/867699

gerritbot added a comment.Dec 16 2022, 8:47 AM

Change 868090 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Always show search results at full width

https://gerrit.wikimedia.org/r/868090

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.17; 2023-01-02).Dec 16 2022, 9:01 AM
gerritbot added a comment.Dec 16 2022, 1:00 PM

Change 867700 merged by jenkins-bot:

[mediawiki/extensions/SearchVue@master] Make SearchVue work on smaller screen

https://gerrit.wikimedia.org/r/867700

matthiasmullie mentioned this in rESVU9c57d275bf77: Make SearchVue work on smaller screen.Dec 16 2022, 1:00 PM
SimoneThisDot moved this task from Doing to Needs QA on the Structured-Data-Backlog (Current Work) board.Dec 19 2022, 8:47 AM
Sneha updated the task description. (Show Details)Dec 21 2022, 6:58 PM
gerritbot added a comment.Jan 3 2023, 3:13 PM

Change 874889 had a related patch set uploaded (by Matthias Mullie; author: Simone Cuomo):

[mediawiki/core@wmf/1.40.0-wmf.14] Change IW breakpoint to be enabled on smaller screen

https://gerrit.wikimedia.org/r/874889

gerritbot added a comment.Jan 3 2023, 3:15 PM

Change 874890 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):

[mediawiki/skins/MinervaNeue@wmf/1.40.0-wmf.14] Always show search results at full width

https://gerrit.wikimedia.org/r/874890

gerritbot added a comment.Jan 4 2023, 8:23 AM

Change 874890 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@wmf/1.40.0-wmf.14] Always show search results at full width

https://gerrit.wikimedia.org/r/874890

Stashbot added a comment.Jan 4 2023, 8:23 AM

Mentioned in SAL (#wikimedia-operations) [2023-01-04T08:23:50Z] <mlitn@deploy1002> Started scap: Backport for [[gerrit:874890|Always show search results at full width (T321377)]]

Stashbot added a comment.Jan 4 2023, 8:25 AM

Mentioned in SAL (#wikimedia-operations) [2023-01-04T08:25:42Z] <mlitn@deploy1002> mlitn and mlitn: Backport for [[gerrit:874890|Always show search results at full width (T321377)]] synced to the testservers: mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet

Stashbot added a comment.Jan 4 2023, 8:32 AM

Mentioned in SAL (#wikimedia-operations) [2023-01-04T08:32:12Z] <mlitn@deploy1002> Finished scap: Backport for [[gerrit:874890|Always show search results at full width (T321377)]] (duration: 08m 22s)

gerritbot added a comment.Jan 4 2023, 8:47 AM

Change 874889 merged by jenkins-bot:

[mediawiki/core@wmf/1.40.0-wmf.14] Change IW breakpoint to be enabled on smaller screen

https://gerrit.wikimedia.org/r/874889

Stashbot added a comment.Jan 4 2023, 8:48 AM

Mentioned in SAL (#wikimedia-operations) [2023-01-04T08:48:11Z] <mlitn@deploy1002> Started scap: Backport for [[gerrit:874889|Change IW breakpoint to be enabled on smaller screen (T321377)]]

Stashbot added a comment.Jan 4 2023, 8:50 AM

Mentioned in SAL (#wikimedia-operations) [2023-01-04T08:50:00Z] <mlitn@deploy1002> mlitn and mlitn: Backport for [[gerrit:874889|Change IW breakpoint to be enabled on smaller screen (T321377)]] synced to the testservers: mwdebug1001.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2001.codfw.wmnet

Stashbot added a comment.Jan 4 2023, 8:57 AM

Mentioned in SAL (#wikimedia-operations) [2023-01-04T08:57:07Z] <mlitn@deploy1002> Finished scap: Backport for [[gerrit:874889|Change IW breakpoint to be enabled on smaller screen (T321377)]] (duration: 08m 56s)

ReleaseTaggerBot edited projects, added: MW-1.40-notes (1.40.0-wmf.14; 2022-12-12); removed: MW-1.40-notes (1.40.0-wmf.17; 2023-01-02).Jan 4 2023, 3:02 PM
Etonkovidova moved this task from Needs QA to Verify on Production on the Structured-Data-Backlog (Current Work) board.Feb 1 2023, 1:55 AM
Maintenance_bot removed a project: Patch-For-Review.Feb 1 2023, 2:30 AM
Etonkovidova updated the task description. (Show Details)Feb 9 2023, 3:17 AM
Etonkovidova closed this task as Resolved.Feb 9 2023, 3:21 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits