Page MenuHomePhabricator
Create Task
Maniphest T321380

Move phabricator/deployments repository from Diffusion to GitLab/Gerrit
Closed, ResolvedPublic
Actions

Description

We should update the Phabricator deployment submodules repositories to point to the canonical GitLab/Gerrit repositories instead of the diffusion mirrors.

https://phabricator.wikimedia.org/diffusion/ARC/arcanist.gitMoved to GitLab already: https://gerrit.wikimedia.org/g/phabricator/arcanist
https://phabricator.wikimedia.org/diffusion/PHSP/phabricator-sprint.gitT275325: Archive broken and unmaintained Phabricator Sprint extension; Moved to GitLab already and archived there: https://gerrit.wikimedia.org/g/phabricator/extensions/Sprint
https://phabricator.wikimedia.org/source/phabricator-translations.gitdone T321350: Phabricator translations can no more be received due to decommissioning of git-ssh; Moved to Gerrit: https://gerrit.wikimedia.org/g/phabricator/translations
https://phabricator.wikimedia.org/diffusion/PHAB/phabricator.gitMoved to GitLab already: https://gerrit.wikimedia.org/g/phabricator/phabricator
https://phabricator.wikimedia.org/diffusion/PHTO/phabricator-tools.gitMoved to GitLab already: https://gitlab.wikimedia.org/repos/phabricator/tools
https://phabricator.wikimedia.org/diffusion/PHEX/phab-extensions.gitMoved to GitLab already: https://gerrit.wikimedia.org/g/phabricator/extensions

More or less related is https://phabricator.wikimedia.org/source/phabricator-translatewiki/ though it is not part of the phabricator/deployment repository (and is disabled and inactive)

For the records, there is also the (deployed) extension https://gerrit.wikimedia.org/g/phabricator/antivandalism/ with its canonical code repo still on Gerrit (instead of most other Phab repos being on GitLab).

Related Objects
Search...

Event Timeline

hashar created this task.Oct 21 2022, 10:02 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 21 2022, 10:02 AM
hashar mentioned this in T191182: Migrate active repositories in Phabricator Differential to GitLab.Oct 25 2022, 9:16 PM
hashar mentioned this in T228507: Remove "Browse Gerrit Projects" on https://phabricator.wikimedia.org/r/.Dec 14 2022, 4:40 PM
Aklapper added a comment.Feb 9 2023, 3:45 PM
https://phabricator.wikimedia.org/diffusion/PHEX/phab-extensions.githttps://gerrit.wikimedia.org/r/phabricator/extensions

Note that this repo moved to GitLab in the meantime anyway per T191182#8576350 so Diffusion isn't really used anymore

brennen closed this task as Declined.Mar 20 2023, 10:28 PM
brennen added a project: User-brennen.
brennen moved this task from To Triage to Infrastructure on the Phabricator board.
brennen subscribed.

All but a couple of these have moved to GitLab at this point:

https://gitlab.wikimedia.org/repos/phabricator

hashar reopened this task as Open.Mar 21 2023, 10:07 AM
In T321380#8712149, @brennen wrote:

All but a couple of these have moved to GitLab at this point:

https://gitlab.wikimedia.org/repos/phabricator

There are six repositories in this task description and https://gitlab.wikimedia.org/repos/phabricator has the same six. Which two Phabricator repositories have to migrate? We also need Phabricator to observe the Gitlab repositories and probably should stop mirroring to Gerrit and archive the Gerrit repositories.

URI links:

https://phabricator.wikimedia.org/source/arcanist/manage/uris/Mirror to Gerrit
https://phabricator.wikimedia.org/diffusion/PHSP/manage/uris/Mirror to Gerrit
https://phabricator.wikimedia.org/source/phabricator-translations/manage/uris/Observes Gerrit (not sure whether translatewiki got adjusted)
https://phabricator.wikimedia.org/source/phabricator/manage/uris/Mirror to Gerrit (and to GitHub clashing with Gerrit replication)
https://phabricator.wikimedia.org/diffusion/PHTO/manage/uris/Nothing?
https://phabricator.wikimedia.org/source/phab-extensions/manage/uris/Mirror to Gerrit

I guess we should make them to observe the Gitlab repositories and stop mirroring to Gerrit.

For translations we got it moved to Gerrit via T321350 and the bot was still sending updates there (March 20th commit https://gerrit.wikimedia.org/r/c/phabricator/translations/+/901183 ).

Aklapper triaged this task as High priority.Jul 11 2023, 9:39 AM
thcipriani claimed this task.Aug 16 2023, 4:31 PM
thcipriani edited projects, added Release-Engineering-Team (Priority Backlog 📥); removed Release-Engineering-Team.
jeena claimed this task.Sep 12 2023, 6:19 PM
jeena added a subscriber: thcipriani.
Aklapper updated the task description. (Show Details)Sep 24 2023, 4:46 PM
Aklapper renamed this task from Move phabricator/deployments repository from Differential to Gerrit to Move phabricator/deployments repository from Diffusion to Gerrit.Sep 24 2023, 4:50 PM
Aklapper updated the task description. (Show Details)
Aklapper added a comment.Sep 24 2023, 5:52 PM

Hmm, isn't this mostly done (apart from Antivandalism still being in Gerrit, and Sprint which should be removed per T275325: Archive broken and unmaintained Phabricator Sprint extension) per https://gitlab.wikimedia.org/repos/phabricator/deployment/-/commit/6aafd15f7d5bad50c309746cdd41a4e4c7633465 by @brennen?

thcipriani added a comment.Sep 25 2023, 4:30 PM
In T321380#9193656, @Aklapper wrote:

Hmm, isn't this mostly done (apart from Antivandalism still being in Gerrit, and Sprint which should be removed per T275325: Archive broken and unmaintained Phabricator Sprint extension) per https://gitlab.wikimedia.org/repos/phabricator/deployment/-/commit/6aafd15f7d5bad50c309746cdd41a4e4c7633465 by @brennen?

The repos that moved to GitLab still have some lingering work.

I archived the gerrit repos for those that have moved.

I assigned this to @jeena to dig through the URIs in phabricator to ensure:

  • they're no longer mirroring to gerrit
  • they are observing GitLab

Once that's done we can call this complete.

Aklapper mentioned this in T347577: Understand which repositories we mirror, observe, host in Diffusion (and fix some findings).Oct 24 2023, 8:03 PM
Aklapper updated the task description. (Show Details)Oct 24 2023, 8:17 PM
Aklapper added a comment.Oct 24 2023, 8:23 PM
In T321380#9196283, @thcipriani wrote:

The repos that moved to GitLab still have some lingering work.

I assigned this to @jeena to dig through the URIs in phabricator to ensure:

  • they're no longer mirroring to gerrit
  • they are observing GitLab

I guess I just did so in T347577#9277852 (though I set up mirroring to Gerrit in cases when the Gerrit repo wasn't already archived).

Once that's done we can call this complete.

https://gitlab.wikimedia.org/repos/phabricator/deployment/-/blob/wmf/stable/.gitmodules reflects the current reality wrt canonical code repos.

If moving the translations repo (blocked on T318763: Work out how to bring in new Phabricator translations again) and moving the antivandalism repo (see T349662) from Gerrit to GitLab is out of scope, then in my understanding this task is complete and can be resolved. (I might misunderstand again.)

Pppery subscribed.Oct 29 2023, 8:44 PM

Also note https://github.com/wikimedia/phabricator-deployment is still mirroring Gerrit and not GitLab.

Aklapper added a comment.Nov 14 2023, 3:55 PM
In T321380#9289890, @Pppery wrote:

Also note https://github.com/wikimedia/phabricator-deployment is still mirroring Gerrit and not GitLab.

Indeed, thanks! I am clueless where to change the URI in the Github web interface. I'm afraid it requires manual cloning, sigh.

Stashbot added a comment.Nov 15 2023, 12:08 PM

Mentioned in SAL (#wikimedia-releng) [2023-11-15T12:08:50Z] <hashar> GitHub: deleted Phabricator mirrored repositories # T321380

Aklapper updated the task description. (Show Details)Nov 15 2023, 6:18 PM
Aklapper renamed this task from Move phabricator/deployments repository from Diffusion to Gerrit to Move phabricator/deployments repository from Diffusion to GitLab/Gerrit.Nov 17 2023, 7:48 AM
Aklapper updated the task description. (Show Details)
Aklapper added a comment.Jun 11 2024, 3:44 PM

@jeena: Is this task resolved as https://gitlab.wikimedia.org/repos/phabricator/deployment/-/blob/wmf/stable/.gitmodules does not list any repos in Diffusion but canonical repositories?

Aklapper closed this task as Resolved.Jun 23 2024, 2:16 PM
Aklapper removed jeena as the assignee of this task.
Aklapper added a subscriber: jeena.

In my understanding this task is done ¯\_(ツ)_/¯

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits