MW has wrapper functions for querystring building etc
It saves having to do stuff like
$delimiter = ( strpos( $mobileViewUrl, "?" ) !== false ) ? "&" : "?";
And also makes sure that all parameters are properly encoded
As per a request on #wikimedia-tech where this was giving validation errors
<li id="mobileview"><a href='/w/index.php?title=Datei%3ALogo_African_Pygmy_Goat.png&action=edit&useFormat=mobile'>Mobile View</a></li>
r93561
Version: unspecified
Severity: normal
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | None | T29719 Mobile broken for non-shortened URL | |||
| Resolved | None | T30510 Searching for terms with periods in the query string gives 403 errror - e.g. Data.gov | |||
| Resolved | None | T32517 Deprecate Ruby mobile gateway | |||
| Resolved | • Tfinc | T32518 Deprecate Hawhaw mobile gateway | |||
| Resolved | None | T32512 Turn MobileFrontend on for 100% of production traffic | |||
| Resolved | None | T32142 Don't manually build URLs in MobileFrontend extension |
$mobileViewUrl = $wgRequest->getRequestURL(); $delimiter = ( strpos( $mobileViewUrl, "?" ) !== false ) ? "&" : "?"; $mobileViewUrl .= $delimiter . 'useFormat=mobile'; $mobileViewUrl = htmlspecialchars( $mobileViewUrl );
even
That particular case is already fixed in r93591. But there a few more problems around.