Page MenuHomePhabricator

Search accesskey inconsistent behaviour when search box is collapsed
Closed, DuplicatePublic3 Estimated Story PointsBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Visit a site with Vector 2022 enabled e.g. French Wikipedia
  • Resize the window to <1000px wide so the Search bar collapses into just a magnifying glass icon
  • Press the search accesskey - Ctrl+Option+f on macOS

What happens?:

  • Chrome - nothing happens
  • Firefox - magnifying glass is highlighted, and takes pressing Enter to open search bar
  • Safari - expected result

What should have happened instead?:
The search box expands, and the cursor is placed in it ready to type. This is the behaviour when screen width >1000px, and on Vector Legacy

Event Timeline

The Firefox issue is covered by T318305.
Not sure what's going on with Chrome but does seem to be related.

When I remove the accesskey from the input, the access key focuses the search (but does not navigate to it) $('input[accesskey="f"]').removeAttr('accesskey') so I guess we need to either remove that accesskey in JavaScript or remove it from the HTML and add it via JavaScript.

Jdlrobson set the point value for this task to 1.Nov 17 2022, 4:30 PM
LGoto changed the point value for this task from 1 to 3.Jan 12 2023, 6:36 PM