Page MenuHomePhabricator
Create Task
Maniphest T321431

Consider supporting topic subscriptions when JavaScript is disabled
Closed, ResolvedPublic
Actions

Description

We should consider supporting topic subscriptions when JavaScript is disabled. We already have a no-JS interface for unsubscribing, but not for subscribing, so it should be easy to add. All of the notifications features have no-JS fallback already.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Remove no-JavaScript topic subscriptions cached HTML compatBartosz Dziewońskimediawiki/extensions/DiscussionToolsmaster+6 -17
Support topic subscriptions when JavaScript is disabledBartosz Dziewońskimediawiki/extensions/DiscussionToolsmaster+995 -758
Customize query in gerrit

Related Objects

Event Timeline

• matmarex created this task.Oct 22 2022, 2:25 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 22 2022, 2:25 AM
ppelberg moved this task from Backlog to Existing Feature Improvements on the DiscussionTools board.Nov 3 2022, 3:16 PM
Tacsipacsi subscribed.Nov 3 2022, 8:53 PM

Yes, absolutely! As a long-time NoScript user (although not on WMF wikis), I’m quite annoyed by websites not functioning without JavaScript without a good reason.

• matmarex mentioned this in T323461: Make new "[reply]" links work without javascript.Nov 21 2022, 1:08 AM
gerritbot added a comment.Feb 9 2023, 5:57 PM

Change 888067 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Support topic subscriptions when JavaScript is disabled

https://gerrit.wikimedia.org/r/888067

gerritbot added a project: Patch-For-Review.Feb 9 2023, 5:57 PM

Change 888068 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Remove no-JavaScript topic subscriptions cached HTML compat

https://gerrit.wikimedia.org/r/888068

• matmarex claimed this task.Feb 9 2023, 5:59 PM
• matmarex added a project: Editing-team (Kanban Board).
• matmarex moved this task from Inbox to Code Review on the Editing-team (Kanban Board) board.
gerritbot added a comment.Apr 10 2023, 7:36 PM

Change 888067 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Support topic subscriptions when JavaScript is disabled

https://gerrit.wikimedia.org/r/888067

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.4; 2023-04-10).Apr 10 2023, 8:00 PM
• matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Apr 11 2023, 3:20 PM
• matmarex edited projects, added: Editing QA; removed: Patch-For-Review.
Iniquity added a project: Convenient-Discussions.Apr 14 2023, 1:29 PM
Jack_who_built_the_house mentioned this in rMGCD945ff8911f36: Take section's subscribe ID from element data.Apr 14 2023, 5:53 PM
Jack_who_built_the_house subscribed.Apr 16 2023, 7:11 PM
Ryasmeen moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Apr 24 2023, 9:54 PM
Ryasmeen edited projects, added: Verified; removed: Editing QA.
• matmarex closed this task as Resolved.Apr 25 2023, 4:18 PM
gerritbot added a comment.Apr 26 2023, 5:35 PM

Change 888068 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Remove no-JavaScript topic subscriptions cached HTML compat

https://gerrit.wikimedia.org/r/888068

Jack_who_built_the_house mentioned this in rMGCD29dc520b7565: Take section's subscribe ID from element data.May 4 2023, 1:13 PM
ReleaseTaggerBot edited projects, added: MW-1.41-notes (1.41.0-wmf.9; 2023-05-15); removed: MW-1.41-notes (1.41.0-wmf.4; 2023-04-10).May 15 2023, 10:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits