Cite lost styling due to T280766
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Izno
	Oct 23 2022, 3:30 AM

Description

Steps to replicate the issue (include links if applicable):

Edit a page section of a page which uses named references, and the named reference content isn't in the text, such as Tor (network) 3rd section

What happens?:

The notice that indicates the content is elsewhere displays as

What should have happened instead?:

These notices should be colored or otherwise indicated as differing, for example:

Other information (browser name/version, screenshots, etc.):
This is a regression, most likely due to T280766: Phase out legacy error, warning and success classes for usage outside the parser. That would make the expected styling color: #ac6600; font-size: larger; as these carry the warning class. I think an appropriate fix for this ticket would remove warning and add styling for the color to the class mw-ext-cite-warning in ext.cite.styles.css (I don't think the size change is desirable in this context, but ymmv). There may be other uses of mw-ext-cite-warning in the extension.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Restore styling for cite warnings	mediawiki/extensions/Cite	master	+7 -0

Customize query in gerrit

Related Objects

Mentioned In: T280766: Phase out legacy error, warning and success classes for usage outside the parser
Mentioned Here: T281228: Provide styling for parser-outputted .error class in content-parser-output
T280766: Phase out legacy error, warning and success classes for usage outside the parser

Event Timeline

Izno created this task.Oct 23 2022, 3:30 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 23 2022, 3:30 AM

Izno mentioned this in T280766: Phase out legacy error, warning and success classes for usage outside the parser.Oct 23 2022, 3:31 AM

Izno added a project: Regression.

Izno updated the task description. (Show Details)Oct 23 2022, 3:34 AM

Izno moved this task from Unsorted backlog to Defect backlog on the Cite board.

This is fallout from T281228: Provide styling for parser-outputted .error class in content-parser-output; kinda. The parser only uses .error, not .warning, so only .error was made available. Depending on how many other uses of parser-outputted warnings there are, it might be a good idea to do the same thing for .warning in content.parser-output.less to allow other extensions to benefit as well.

@Jdlrobson What do you think? Add styling for parser-emitted warning in core's content.parser-output.less or handle this edge case in Cite?

The case was actually caught in the code search in T280766, just only in a test file because Cite is doing something abominable with how it's adding the warning class. :) I think it makes more sense to do it in Cite here given the reason warning wasn't added to content.parser-output.less.

Hmm, warning seems to be used much more than not after a review of Code search. I'll leave some comments on the original task. I still don't think that indicates that we should add it, since in the wild it's not used often and there aren't other extensions that depend on it for core functioning (like ParserFunctions and error).