Define wmgSiteLogoVariants in logos/config.yaml
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Jdlrobson
	Oct 24 2022, 8:40 PM

Description

Variants can already be defined in logos/config.yaml yet we have many rules inside wmf-config/InitialiseSettings.php

Moving these rules to logos/config.yaml would greatly simplify things.

zhwiki already has rules for zhwiki-hans and zhwiki-20

zhwikivoyage:
    commons: 'File:Wikivoyage-Logo-v3-zh-hans.svg'
    variants:
        zhwikivoyage-hant:
            commons: 'File:Wikivoyage-Logo-v3-zh-hant.svg'
    comment: 'T61077, T308620'
    comment_1_5x: 'T150618, T308620'
    comment_2x: 'T150618, T308620'

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Move wmgSiteLogoVariants to logos.php	operations/mediawiki-config	master	+309 -158

Customize query in gerrit

Related Objects

Mentioned In: T308620: HIDPI support for logos among Chinese projects
Mentioned Here: T308620: HIDPI support for logos among Chinese projects

Event Timeline

Jdlrobson created this task.Oct 24 2022, 8:40 PM

Restricted Application added subscribers: Ericliu1912, Aklapper. · View Herald TranscriptOct 24 2022, 8:40 PM

Change 848552 had a related patch set uploaded (by Stang; author: Stang):

[operations/mediawiki-config@master] Move wmgSiteLogoVariants to logos.php

https://gerrit.wikimedia.org/r/848552

gerritbot added a project: Patch-For-Review.Oct 24 2022, 11:28 PM

Stang claimed this task.Oct 24 2022, 11:28 PM

Change 848552 merged by jenkins-bot:

[operations/mediawiki-config@master] Move wmgSiteLogoVariants to logos.php

https://gerrit.wikimedia.org/r/848552

Mentioned in SAL (#wikimedia-operations) [2022-10-25T13:27:13Z] <lucaswerkmeister-wmde@deploy1002> Started scap: Backport for [[gerrit:848552|Move wmgSiteLogoVariants to logos.php (T308620 T321519)]]

Mentioned in SAL (#wikimedia-operations) [2022-10-25T13:27:36Z] <lucaswerkmeister-wmde@deploy1002> lucaswerkmeister-wmde and stang: Backport for [[gerrit:848552|Move wmgSiteLogoVariants to logos.php (T308620 T321519)]] synced to the testservers: mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet

Maintenance_bot removed a project: Patch-For-Review.Oct 25 2022, 1:30 PM

Mentioned in SAL (#wikimedia-operations) [2022-10-25T13:33:00Z] <lucaswerkmeister-wmde@deploy1002> Finished scap: Backport for [[gerrit:848552|Move wmgSiteLogoVariants to logos.php (T308620 T321519)]] (duration: 05m 47s)

Stang closed this task as Resolved.Oct 25 2022, 1:34 PM

Stang unsubscribed.Oct 28 2022, 10:33 PM

Ericliu1912 unsubscribed.Oct 29 2022, 12:10 AM

Define wmgSiteLogoVariants in logos/config.yamlClosed, ResolvedPublicBUG REPORTActions

Description

Details

Related Objects

Event Timeline

Define wmgSiteLogoVariants in logos/config.yaml
Closed, ResolvedPublicBUG REPORT
Actions