Page MenuHomePhabricator

Do not display suggestions that are already in depict statements
Open, Needs TriagePublicFeature

Description

Feature summary:
We need to prevent the display of depict suggestions that are already present on the image.
This is needed because the suggestion may still have status "unreviewed" (e.g. if the edit was made directly on Commons)

The easiest way is to set isAccepted=true on any suggestion that is already included within the initalData.depicts array (i.e. they have a matching Wikidata item).
This should be done in both the populateMachineVisionSuggestions and the populateM2CSuggestions functions just before we call this.appendSuggestions (this is when they are "saved" to main this.depictSuggestions array).

Event Timeline

@NavinoEvans could this be related to T312871?

Good point, I had forgotten to update this to include the M2C suggestions. I've just updated the description to show this needs to happen with both sets of suggestions.