Page MenuHomePhabricator

Pending table rows have no gateway_txn_id in the column and in the message its gateway_txn_id:false
Closed, ResolvedPublic

Description

Found when trying to test the adyen pending transaction resolver T321602: Adyen pending resolver - handle no gateway_txn_id and when its equal to the string false

{"gateway_txn_id":false,"response":false,"gateway_account":"WikimediaDonations","fee":0,"contribution_tracking_id":"133452400","utm_source":"2.7.cc.default~default~default~default~control.cc","utm_medium":"WikipediaApp","utm_campaign":"Android"...

Preliminary research:
MariaDB [smashpig]> select count(id) from pending WHERE gateway='adyen' AND gateway_txn_id='';

count(id)
534

So there are a bunch of these

Checking the last few made in Adyen looks like some aren't in Adyen at all, some are Refused and at least one was Retried and sitting at Authorised
137966477.1 Not in Adyen
137949583.1 Refused
137947555.1 Refused
137945018.1 Not in Adyen
137911822.1 Refused
137870362.1 Retried then sitting at Authorised

Event Timeline

All of these (well, the most recent 10 that I checked) seem to either be rtbt or 3DS redirects, where we legitimately don't have a gateway_txn_id at the point of redirecting the donor. I think we do want to send pending messages in these cases, as they can be useful to record donations via an IPN.

So, no action needed beyond the change you're already making to the isResolvable function. It's also probably OK that these messages will be deleted by the resolver.

greg assigned this task to Ejegg.
greg set the point value for this task to 1.
Dwisehaupt removed the point value for this task.Nov 9 2022, 8:38 PM
Dwisehaupt set Final Story Points to 1.