Page MenuHomePhabricator
Create Task
Maniphest T321637

Remove 'dist/' from import paths
Closed, ResolvedPublic
Actions

Description

Right now, importing a mixin from Codex looks like this:

import ( reference ) '@wikimedia/codex/dist/mixins/link.less';

And importing the design tokens looks like this:

@import ( reference ) '@wikimedia/codex-design-tokens/dist/theme-wikimedia-ui.less';

We should remove dist/ from these import paths, perhaps using generate-export-aliases.

Details

SubjectRepoBranchLines +/-
Update Codex from v0.3.0 to v0.4.0mediawiki/coremaster+664 -637
build: Remove 'dist/' from import paths for mixin and tokens filesdesign/codexmain+340 -92
Customize query in gerrit

Related Objects
Search...

Event Timeline

Catrope created this task.Oct 26 2022, 12:32 AM
Restricted Application added a project: Design-System-Team. · View Herald TranscriptOct 26 2022, 12:32 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
AnneT subscribed.Oct 26 2022, 1:35 PM
Catrope mentioned this in T322274: [Epic] Publish the design-tokens package in NPM.Nov 19 2022, 12:28 AM
Catrope added a parent task: T322274: [Epic] Publish the design-tokens package in NPM.
Catrope moved this task from Inbox to Up Next on the Design-System-Team board.
Catrope claimed this task.Nov 30 2022, 4:43 PM
Catrope edited projects, added Design-System-Team (Design-System-Sprint); removed Design-System-Team.
Catrope moved this task from Committed to In Development on the Design-System-Team (Design-System-Sprint) board.
gerritbot added a comment.Nov 30 2022, 11:50 PM

Change 862376 had a related patch set uploaded (by Catrope; author: Catrope):

[design/codex@main] build: Remove 'dist/' from import paths for mixin and tokens files

https://gerrit.wikimedia.org/r/862376

gerritbot added a project: Patch-For-Review.Nov 30 2022, 11:50 PM
Catrope moved this task from In Development to Code Review on the Design-System-Team (Design-System-Sprint) board.Dec 1 2022, 1:03 AM
Volker_E reassigned this task from Catrope to DAbad.Dec 2 2022, 2:06 PM
Volker_E reassigned this task from DAbad to Catrope.
Volker_E moved this task from Code Review to Product Sign-Off on the Design-System-Team (Design-System-Sprint) board.
Volker_E moved this task from Product Sign-Off to Code Review on the Design-System-Team (Design-System-Sprint) board.
Volker_E added a subscriber: DAbad.
gerritbot added a comment.Dec 5 2022, 10:58 PM

Change 862376 merged by jenkins-bot:

[design/codex@main] build: Remove 'dist/' from import paths for mixin and tokens files

https://gerrit.wikimedia.org/r/862376

Maintenance_bot removed a project: Patch-For-Review.Dec 5 2022, 11:30 PM
egardner moved this task from Code Review to Pending Release on the Design-System-Team (Design-System-Sprint) board.Dec 6 2022, 5:20 PM
gerritbot added a comment.Dec 6 2022, 6:59 PM

Change 865151 had a related patch set uploaded (by Eric Gardner; author: Eric Gardner):

[mediawiki/core@master] Update Codex from v0.3.0 to v0.4.0

https://gerrit.wikimedia.org/r/865151

gerritbot added a project: Patch-For-Review.Dec 6 2022, 6:59 PM
gerritbot added a comment.Dec 6 2022, 7:16 PM

Change 865151 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v0.3.0 to v0.4.0

https://gerrit.wikimedia.org/r/865151

Maintenance_bot removed a project: Patch-For-Review.Dec 6 2022, 7:32 PM
Volker_E closed this task as Resolved.Dec 6 2022, 8:19 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL