FileImporter support for PHP 8.1
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

00:01:20.716 1) FileImporter\Tests\Exceptions\ImportExceptionTest::testException with data set #3 (1.2, 1.2)
00:01:20.716 ctype_digit(): Argument of type float will be interpreted as string in the future
00:01:20.716 
00:01:20.716 /workspace/src/extensions/FileImporter/src/Exceptions/ImportException.php:23
00:01:20.716 /workspace/src/extensions/FileImporter/tests/phpunit/unit/Exceptions/ImportExceptionTest.php:30
00:01:20.716 /workspace/src/tests/phpunit/MediaWikiUnitTestCase.php:116

Details

	Subject	Repo	Branch	Lines +/-
	Fix PHP 8.1 test failures	mediawiki/extensions/FileImporter	master	+47 -22
	Avoid passing non-strings to ctype_digit()	mediawiki/extensions/FileImporter	master	+5 -1

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Stalled	None	T255792 Quibble runs core:unit tests twice!
Open	None	T328919 Upgrade to PHPUnit 10
Open	None	T338103 Micro-optimize ApiResult::isMetadataKey with str_starts_with once we support PHP8+
Open	None	T328921 Drop PHP 7.4 support from MediaWiki
Stalled	None	T334726 Use return type `never` in Wikibase
Open	None	T328922 Drop PHP 8.0 support from MediaWiki
Stalled	None	T319055 Upgrade to psr/container 2.x
Stalled	Krinkle	T319432 Migrate WMF production from PHP 7.4 to PHP 8.1
Resolved	Jdforrester-WMF	T316078 Make PHP 8.1 voting on development (master) branch of MW ecosystem (core, extensions, skins, libraries)
Resolved	Jdforrester-WMF	T319065 All Wikimedia production extensions and skins must support PHP 8.1
Resolved	thiemowmde	T321692 FileImporter support for PHP 8.1

Event Timeline

Jdforrester-WMF created this task.Oct 26 2022, 1:35 PM

Reedy moved this task from Backlog to Wikimedia production on the PHP 8.1 support board.Oct 26 2022, 3:56 PM

Krinkle added a project: WMDE-TechWish.Oct 27 2022, 3:16 AM

Change 850026 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/FileImporter@master] Avoid passing non-strings to ctype_digit()

https://gerrit.wikimedia.org/r/850026

gerritbot added a project: Patch-For-Review.Oct 27 2022, 8:02 AM

thiemowmde claimed this task.Oct 27 2022, 8:03 AM

thiemowmde added projects: WMDE-TechWish-Maintenance, WMDE-TechWish-Sprint-2022-10-26, Unplanned-Sprint-Work.

thiemowmde moved this task from Backlog to Tickets in sprint on the Move-Files-To-Commons board.

thiemowmde set the point value for this task to 1.

thiemowmde moved this task from Sprint Backlog to Tech Review on the WMDE-TechWish-Sprint-2022-10-26 board.

WMDE-Fisch moved this task from Tech Review to Done on the WMDE-TechWish-Sprint-2022-10-26 board.Oct 27 2022, 10:05 AM

Change 850026 merged by jenkins-bot:

[mediawiki/extensions/FileImporter@master] Avoid passing non-strings to ctype_digit()

https://gerrit.wikimedia.org/r/850026

Maintenance_bot removed a project: Patch-For-Review.Oct 27 2022, 10:32 AM

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.8; 2022-10-31).Oct 27 2022, 11:00 AM

Thank you!

1) FileImporter\Tests\Data\ImportDetailsTest::testInvalidFileRevisionTimestamp
strtotime(): Passing null to parameter #1 ($datetime) of type string is deprecated

/srv/mw/extensions/FileImporter/src/Data/FileRevisions.php:54
/srv/mw/extensions/FileImporter/src/Data/FileRevisions.php:41
/srv/mw/extensions/FileImporter/src/Data/ImportDetails.php:121
/srv/mw/extensions/FileImporter/tests/phpunit/Data/ImportDetailsTest.php:73

2) FileImporter\Tests\Remote\MediaWiki\RemoteApiImportTitleCheckerTest::test with data set #7 (null, false, 1)
json_decode(): Passing null to parameter #1 ($json) of type string is deprecated

/srv/mw/extensions/FileImporter/src/Remote/MediaWiki/RemoteApiImportTitleChecker.php:67
/srv/mw/extensions/FileImporter/tests/phpunit/Remote/MediaWiki/RemoteApiImportTitleCheckerTest.php:71

Tests where everything is mocked, the fields are null, validation is disabled, and then you call random methods and expect them to work. Fragile and sensitive to private details of the classes being tested.

Change 851181 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/extensions/FileImporter@master] Fix PHP 8.1 test failures

https://gerrit.wikimedia.org/r/851181

gerritbot added a project: Patch-For-Review.Nov 1 2022, 3:20 AM

Change 851181 merged by jenkins-bot:

[mediawiki/extensions/FileImporter@master] Fix PHP 8.1 test failures

https://gerrit.wikimedia.org/r/851181

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.10; 2022-11-14); removed MW-1.40-notes (1.40.0-wmf.8; 2022-10-31).Nov 1 2022, 9:01 AM

Maintenance_bot removed a project: Patch-For-Review.Nov 1 2022, 9:30 AM

Jdforrester-WMF closed this task as Resolved.Nov 2 2022, 4:27 PM