Page MenuHomePhabricator

Civi: Forget Me button yields configuration error
Closed, ResolvedPublicBUG REPORT

Description

Yamini spotted and I was able to replicate that when choosing the Forget Me button, it stops and says:

Configuration key 'payment-provider/cc/class' does not exist

The last successful use was October 22nd, 2022 7:02 PM for activity: 1193250 Privacy Request, so the error must be pretty recent.

Here is what we see:

Forget Me2022-10-26 at 9.37.33 AM.png (958×1 px, 117 KB)

Maybe this is related to T318283: build Adyen API into Civi Forget Me button? The donors we tested were ones without Adyen contribs.

Event Timeline

Oops, I think I know what caused this. Should be an easy fix. Sorry for not testing thoroughly enough!

Change 851176 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/crm@master] Error handling for contribution forgetme

https://gerrit.wikimedia.org/r/851176

Thanks, @Ejegg I just tested the Forget Me button and got similar:

Screen Shot 2022-11-01 at 11.30.58 AM.png (944×1 px, 119 KB)

@MBeat33 we've got a fix in review - I'll let you know when we have it deployed.

Change 851176 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Error handling for contribution forgetme

https://gerrit.wikimedia.org/r/851176

OK @MBeat33 the fix is deployed. It no longer throws the error when loading the initial screen on that contact. I haven't yet pressed the button to do the actual forgetting, but I think that should work too.

Thanks, @Ejegg I tested on a non-Adyen donor and it worked, but for an Adyen donor Civi responded with:

Screen Shot 2022-11-01 at 4.36.12 PM.png (434×1 px, 105 KB)

Oh shoot! There's one config file update I missed, and I think a bit of network configuration that we'll need. Sorry again.

OK, the config file is updated so the forgetme button will now make the GDPR requests against the live rather than test Adyen endpoint.

@Jgreen or @Dwisehaupt when you have time, could you please see about allowing outbound access from civi1001 to yet another Adyen API endpoint? It needs to be able to hit https://ca-live.adyen.com/ca/services/DataProtectionService/v1 . Thank you!

I have added the config for the ipset and enabled it. Also deployed the iptables config.

When testing, it looks like that url redirects to https://authn-live.adyen.com so looking at adding that in too.

Added in the config for ipset and iptables rules for adyen.authn-live and enabled it all. Verified the connection with wget and it is successful.

@MBeat33 with the changes I just made, I believe you are clear to test this again.

Awesome, thank you both. I just tested with an Adyen and a non-Adyen donor, and it looks great.

MBeat33 claimed this task.

Not sure if this should be a spinoff Task, but I got the following error when forgetting cid=13211031

https://civicrm.wikimedia.org/civicrm/a/#/forgetme/forget/13211031

Screen Shot 2022-11-07 at 12.50.11 PM.png (266×734 px, 47 KB)

Screen Shot 2022-11-07 at 12.50.19 PM.png (256×706 px, 28 KB)

This cid is one of the older deletion request for which I was re-applying Forget Me, in order to delete the Adyen data.

Not sure if this should be a spinoff Task, but I got the following error when forgetting cid=13211031

Screen Shot 2022-11-07 at 12.50.19 PM.png (256×706 px, 28 KB)

Looks like there is a trailing comma in the list there and thus it's seeing a non-int value. @Ejegg could you take a look when you get a chance.

greg reassigned this task from MBeat33 to Ejegg.
greg set the point value for this task to 2.
Dwisehaupt removed the point value for this task.Nov 9 2022, 8:38 PM
Dwisehaupt set Final Story Points to 2.