Page MenuHomePhabricator

Implement permission checks to determine if user should be able to see privately registered participants
Closed, ResolvedPublic1 Estimated Story Points

Description

This is only for the backend code, and would not be exposed in the UI or anywhere else.

Acceptance criteria

  • Only the organizer of an event should be able to see privately registered participants
  • If the organizer is blocked, they should not be able to see private registrations
    • Note: This would occur if the organizer is blocked after they create the event and enable registration

Event Timeline

Daimona renamed this task from Determine if a blocked organizer should be able to see privately registered participants to Implement permission checks to determine if user should be able to see privately registered participants.Oct 26 2022, 6:33 PM
Daimona claimed this task.
Daimona updated the task description. (Show Details)

Change 849656 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] [WIP] Implement perm check to determine if user can see private participants

https://gerrit.wikimedia.org/r/849656

Daimona set the point value for this task to 1.Oct 26 2022, 9:07 PM

(The patch is WIP due to the question in the task description)

TBD: What if the organizer was blocked?

@ifried Do we have an answer on this? If not, can we just disallow blocked organizers for now?

Change 849656 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Implement perm check to determine if user can see private participants

https://gerrit.wikimedia.org/r/849656

✅ Only the organizer of an event should be able to see privately registered participants

See test notes at T321625#8368773 which went through this (it is working as expected)


✅ If the organizer is blocked, they should not be able to see private registrations

Organizer blocked after creating event and cannot see private participants:

Screen Shot 2022-11-04 at 2.34.18 PM.png (1×1 px, 241 KB)


@Daimona when the organizer is blocked after creating an event, they can still see publicly registered participants with ?include_private=false (just like any non-organizer would be able to see, or when logged out and viewing the event). I believe this is the correct behavior, but checking to make sure?

@Daimona when the organizer is blocked after creating an event, they can still see publicly registered participants with ?include_private=false (just like any non-organizer would be able to see, or when logged out and viewing the event). I believe this is the correct behavior, but checking to make sure?

Yes, because as you mentioned, that information is publicly available.