[S] [minor] Special:Search Quick view - when all sections are displayed, bottom border of last row of section titles is not displayed
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Etonkovidova
	Oct 26 2022, 8:56 PM

Description

Steps:

Go to enwiki betalabs Special:Search and perform a search for an article for which all sections will be displayed in the QuickView
The search for lilac (https://en.wikipedia.beta.wmflabs.org/w/index.php?search=lilac&title=Special:Search&profile=advanced&fulltext=1&ns0=1&quickView=Cat+coat+genetics) returns Cat coat genetics. This article was imported and un-modified (at the moment of filing this task), so it's a real example.
Click on Cat coat genetics in the results to display the QuickView, the bottom border of the last section will not be displayed.

The screenshot is done with full-screen, 100% scale.

Screen Shot 2022-10-26 at 10.53.50 AM.png (1×2 px, 1 MB)

Note: When we there will be +n more section, all borders are displayed correctly.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	when all sections are displayed, bottom border is not displayed	mediawiki/extensions/SearchVue	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: rESVUd3aed3888e32: when all sections are displayed, bottom border is not displayed

Event Timeline

Etonkovidova created this task.Oct 26 2022, 8:56 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 26 2022, 8:56 PM

CBogen added a project: SDAW-Search-Improvements (Milestone 2: QuickView MVP).Oct 26 2022, 9:10 PM

CBogen edited projects, added Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog.Oct 31 2022, 4:46 PM

CBogen moved this task from Incoming to Ready for Estimation on the Structured-Data-Backlog (Current Work) board.

CBogen renamed this task from [minor] Special:Search Quick view - when all sections are displayed, bottom border of last row of section titles is not displayed to [S] [minor] Special:Search Quick view - when all sections are displayed, bottom border of last row of section titles is not displayed.Nov 2 2022, 4:45 PM

CBogen moved this task from Ready for Estimation to Ready for Development on the Structured-Data-Backlog (Current Work) board.Nov 2 2022, 5:43 PM

SimoneThisDot claimed this task.Nov 14 2022, 12:40 PM

SimoneThisDot moved this task from Ready for Development to Code Review on the Structured-Data-Backlog (Current Work) board.

Change 856542 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[mediawiki/extensions/SearchVue@master] when all sections are displayed, bottom border is not displayed

https://gerrit.wikimedia.org/r/856542

gerritbot added a project: Patch-For-Review.Nov 14 2022, 12:42 PM

Change 856542 merged by jenkins-bot:

[mediawiki/extensions/SearchVue@master] when all sections are displayed, bottom border is not displayed

https://gerrit.wikimedia.org/r/856542

SimoneThisDot mentioned this in rESVUd3aed3888e32: when all sections are displayed, bottom border is not displayed.Nov 15 2022, 9:13 AM

Maintenance_bot removed a project: Patch-For-Review.Nov 15 2022, 9:30 AM

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.12; 2022-11-28).Nov 15 2022, 10:00 AM

SimoneThisDot moved this task from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.Nov 15 2022, 11:11 AM

Tested this again on Chrome v106, Safari v16 and Firefox v106. All looks good when the ... more sections link is both present and absent.

Checked after deployment (wmf.17) to ruwiki, ptwiki, and idwiki - the fix is in place.

The example shows a QuickView for an article without the table of content and no media images - the border is displayed correctly:

Screen Shot 2023-01-05 at 5.05.00 PM.png (1×796 px, 892 KB)

	F36004057: Screen Shot 2023-01-05 at 5.05.00 PM.png
	Jan 6 2023, 1:07 AM

	F35635240: Screen Shot 2022-10-26 at 10.53.50 AM.png
	Oct 26 2022, 8:56 PM

	F35807376: image.png
	Nov 20 2022, 10:26 PM

	F35807367: image.png
	Nov 20 2022, 10:26 PM

[S] [minor] Special:Search Quick view - when all sections are displayed, bottom border of last row of section titles is not displayedClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

[S] [minor] Special:Search Quick view - when all sections are displayed, bottom border of last row of section titles is not displayed
Closed, ResolvedPublic
Actions