The shouldUnattachImplementationTester value needs to be passed to the submitZObject function in PublishDialog.vue.
It is derived from either output/inputs having changed in a function definition.
Previously this check happened in validateInputOutputTypeChanged but this will change now we are going to handle warnings differently. Depending on whether that validation check is done a) locally in the FunctionDefinition Component or b) in the errors store module will mean we either
a) Pass a prop into the ZObjectPublish component and then the PublishDialog component.
or
b) Somehow store this in an errors object, which can be checked on submission.
Description
Description
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | BUG REPORT | None | T344206 Special:MathStatus exception error on Wikifunctions | ||
| Open | None | T342865 Post-creation work for wikifunctionswiki | |||
| Resolved | BTullis | T289316 Prepare and check storage layer for Wikifunctions.org (new public content wiki) | |||
| Resolved | Jdforrester-WMF | T275945 Create Wikifunctions.org | |||
| Resolved | Jdforrester-WMF | T299176 Phase Theta – Root task | |||
| Resolved | Nik.xyz.in | T340774 e2e tests for DefaultView: Fix and re-enable once DefaultView is fully finished | |||
| Resolved | DVrandecic | T324802 Phase θ Goal 5: Fallback view | |||
| Resolved | Ddwaal | T321381 Publish component: Create a publish component used in all Wikifunctions create and edit pages | |||
| Resolved | Ddwaal | T321739 Handle shouldUnattachImplementationTester passed to this.submitZObject in the PublishDialog |
Event Timeline
Comment Actions
We have decided to pass this in the return object from validateZObject - the method in the zobjects.js which will add all errors and warnings to the errors module.