Page MenuHomePhabricator

Handle shouldUnattachImplementationTester passed to this.submitZObject in the PublishDialog
Closed, ResolvedPublic


The shouldUnattachImplementationTester value needs to be passed to the submitZObject function in PublishDialog.vue.
It is derived from either output/inputs having changed in a function definition.
Previously this check happened in validateInputOutputTypeChanged but this will change now we are going to handle warnings differently. Depending on whether that validation check is done a) locally in the FunctionDefinition Component or b) in the errors store module will mean we either
a) Pass a prop into the ZObjectPublish component and then the PublishDialog component.
b) Somehow store this in an errors object, which can be checked on submission.

Event Timeline

We have decided to pass this in the return object from validateZObject - the method in the zobjects.js which will add all errors and warnings to the errors module.