Maniphest T321821

Migrate from Validators to Type Comparisons
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	cmassaro
	Oct 27 2022, 3:40 PM

Tags

Referenced Files

None

Subscribers

Description

Description

Discussion can be found here.

Desired behavior/Acceptance criteria (returned value, expected error, performance expectations, etc.)

JSON schema validators will no longer be used for type-checking in the orchestrator
JSON schema validators will no longer be generated for complex objects in the orchestrator (only built-in types)
the results of validation will be cached in order to deduplicate work

Remove all the non-applicable tags from the "Tags" field, leave only the tags of the projects/repositories related to this task

Completion checklist

Before closing this task, review one by one the checklist available here: https://www.mediawiki.org/wiki/Abstract_Wikipedia_team/Definition_of_Done#Back-end_Task/Bug_completion_checklist

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Replace validation with type comparison.	mediawiki/services/function-orchestrator	master	+974 -1 K

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Declined		None	T321827 Switch to a More Eager Evaluation Strategy
		Resolved		cmassaro	T321821 Migrate from Validators to Type Comparisons
		Resolved		cmassaro	T321824 Create a JavaScript Function Which Can Decide Whether a Type Is Type-Equivalent to Another Type

Event Timeline

cmassaro created this task.Oct 27 2022, 3:40 PM

Discussion can be found here.

cmassaro updated the task description. (Show Details)Oct 31 2022, 5:41 PM

cmassaro added a parent task: T321827: Switch to a More Eager Evaluation Strategy.Nov 3 2022, 6:21 PM

cmassaro edited projects, added function-schemata; removed Epic.

cmassaro merged a task: T319431: Overhaul Validators on the Backend.Nov 3 2022, 6:39 PM

DVrandecic moved this task from To Triage to Phase θ – Throttling on the Abstract Wikipedia team board.Nov 15 2022, 7:46 PM

DVrandecic edited projects, added Abstract Wikipedia team (Phase θ – Throttling); removed Abstract Wikipedia team.

DVrandecic moved this task from Phase θ – Throttling to To triage: Nice-to-haves on the Abstract Wikipedia team board.Nov 15 2022, 7:48 PM

DVrandecic edited projects, added Abstract Wikipedia team; removed Abstract Wikipedia team (Phase θ – Throttling).

DVrandecic moved this task from To triage: Nice-to-haves to Phase θ – Throttling on the Abstract Wikipedia team board.Dec 22 2022, 11:13 PM

DVrandecic edited projects, added Abstract Wikipedia team (Phase θ – Throttling); removed Abstract Wikipedia team.

Pointing to T318365 for the type comparison operator

Change 856014 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[mediawiki/services/function-orchestrator@master] Replace validation with type comparison.

https://gerrit.wikimedia.org/r/856014

gerritbot added a project: Patch-For-Review.Jan 17 2023, 5:11 PM

Jdforrester-WMF assigned this task to cmassaro.Jan 23 2023, 4:42 PM

cmassaro added a subtask: T327870: Discuss Running the Validator Function for Both the Actual Type and the Declared Type.Jan 25 2023, 9:23 AM

DVrandecic closed subtask T321824: Create a JavaScript Function Which Can Decide Whether a Type Is Type-Equivalent to Another Type as Resolved.Jan 27 2023, 1:19 AM

Change 856014 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Replace validation with type comparison.

https://gerrit.wikimedia.org/r/856014

cmassaro mentioned this in rMSFOe8324cb733ab: Replace validation with type comparison..Jan 27 2023, 10:45 AM

cmassaro moved this task from Ready: G2. Correct & efficient to QA / Ready to close on the Abstract Wikipedia team (Phase θ – Throttling) board.Jan 27 2023, 11:30 AM

Maintenance_bot removed a project: Patch-For-Review.Jan 27 2023, 11:30 AM

Moved dependencies to the upper task, and this can then be closed.