Page MenuHomePhabricator

Addition to the Deduper Interface
Closed, ResolvedPublic4 Estimated Story PointsFeature


Feature summary (what you would like to be able to do and where):

Have the ability to have the "on hold" description that can be seen next to an email on the Civi summary page, on the actual Deduper Interface query with the donor information in the same editable format. I added screenshots of my test CID as examples.

Screen Shot 2022-10-27 at 12.24.10 PM.png (254×890 px, 38 KB)

Screen Shot 2022-10-27 at 12.13.13 PM.png (682×2 px, 150 KB)

Use case(s) (list the steps that you performed to discover that problem, and describe the actual underlying problem which you want to solve. Do not describe only a solution):

Our dedupe admin team pulls up a query on the deduper interface which was created to facilitate the merging process, however, they are having to manually open the CID after each merge to make sure the email saved as the primary (attached to the most recent donation) isn't the one "On hold" while the good, email that will receive communication from us, is being saved as the "other" therefore, bulk emails won't reach these donors.

Benefits (why should this be implemented?):

If we can have the "On hold" description in the deduper interface, with the same editing capability already present for the correction of misspelled names, emails, and addresses, we would be able to add the email "NOT-ON-HOLD" to the CID to be saved in the same step, instead of having to open extra tabs to finalize the CID update. This would streamline the entire deduping process and put us back on track!

Event Timeline

SHust renamed this task from Deduper Interface to Addition to the Deduper Interface .Oct 27 2022, 5:38 PM
Dwisehaupt set the point value for this task to 4.Oct 31 2022, 8:46 PM

Hey there @SHust, a bunch of us spoke yesterday about how awesome this feature request is. Thanks for taking the time to lay out the requirements the way you have. It's fantastic! :)

@jgleeson you made my day + I'm now hopeful that it might become a reality! Ty and the team :)

Change 865839 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Add on_hold information to the deduper interface

I've put up a patch for review that makes the on-hold-ness visible in the UI per the screen shots.

I feel like we should possibly make it such that the dedupe code looks at on_hold when deduping & choosing what to mark as primary. However, I guess that might be a little complex in this workflow is based on a dedupe search where the emails do not match whereas making it choose the email when they do could lead to some unexpected consequences I guess - and also, in this workflow it's probably good to 'disappear' the on hold one rather than just demote it. Anyway - if adding to the UI is enough I don't need to scope out a bigger fix

image.png (806×2 px, 132 KB)

@Eileenmcnaughton thank you, we'll test it out.
If you think that there's a way to pull queries without the on-hold cases, it might be easier I guess. We have tried using the clause 'primary address on hold + not between + two sets of Cids' on top of the rule to search for different emails and such, but the queries still come with on-hold dupes so that is why I requested the visibility. Thanks again!

@SHust for clarity - it isn't deployed yet. I need to fix some errors Dami found in review & get it deployed

Change 865839 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Add on_hold information to the deduper interface

@SHust I just deployed the on-hold display fix

@Eileenmcnaughton thanks for the solution and the ping! So I know what to look for, will the queries have the visible 'on-hold' tag next to an email, or will the 'on-hold' cases no longer come up in queries under the deduper interface?

@SHust - the former - the on-hold will be visible like the image you provided at the top

Great, I'll let the team know, thanks again!

@Eileenmcnaughton, unfortunately, we're not seeing the visible 'on-hold' tag next to the emails in the deduper queries, here are a few examples:
29918174 vs 47329178 + this odd privacy or fraudsters cids 2991817445524948, 3355591, 43266254, 8930177.

Change 868848 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Hack Partner back into contactBasic form

@SHust it turns out that the form wasn't loading cos we had local overrides to add the Partner field - the new feature is now loading BUT at the temporary expense of the partner field - which I'm working on getting back in

@Eileenmcnaughton, we can now see the 'on-hold' tag, thank you! The partner field isn’t something we're actively using in the deduper interface so there's no rush getting it back. Thanks again!

Change 868848 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Hack Partner back into contactBasic form

XenoRyet set Final Story Points to 4.