Page MenuHomePhabricator
Create Task
Maniphest T321864

Add CentralAuth to the gated extensions list
Closed, DeclinedPublic
Actions

Description

Tests for CheckUser that are run as part of the gated extensions tests need to reference two string constants in CentralAuthUser. While the string constant could be written out manually it is desirable to not do this in case the raw value of these constants are changed. Without CentralAuth in the gated extensions list CentralAuthUser is not accessible to CheckUser tests when running the gated extension tests.

For the time being I will write the string values in manually as the test does not rely on CentralAuth for any purpose.

Details

ProjectBranchLines +/-Subject
integration/configmaster+2 -0Add CentralAuth to the gated extensions list
Customize query in gerrit

Related Objects
Search...

Event Timeline

Dreamy_Jazz created this task.Oct 27 2022, 9:11 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 27 2022, 9:11 PM
Dreamy_Jazz added parent tasks: T315648: Fully test Hooks.php, T204252: Have dependencies of gated extensions in the gate.Oct 27 2022, 9:12 PM
Dreamy_Jazz updated the task description. (Show Details)
Dreamy_Jazz mentioned this in T204252: Have dependencies of gated extensions in the gate.Oct 27 2022, 9:16 PM
gerritbot added a comment.Oct 27 2022, 9:22 PM

Change 850278 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[integration/config@master] Add CentralAuth to the gated extensions list

https://gerrit.wikimedia.org/r/850278

gerritbot added a project: Patch-For-Review.Oct 27 2022, 9:22 PM
Dreamy_Jazz added a project: CheckUser.Oct 27 2022, 9:23 PM
Dreamy_Jazz updated the task description. (Show Details)Oct 27 2022, 9:32 PM
Jdforrester-WMF added a subscriber: Jdforrester-WMF.Oct 27 2022, 9:34 PM

Sorry, this is not possible with the current architecture of CI. The "gate" means treating the extension/skin like MediaWiki core itself, always cloning and installing it and running its tests with every MediaWiki land patch.

CentralAuth intentionally (and rightly!) replaces MediaWiki core's auth stack with its own. When running CI with CentralAuth enabled, all of core's tests about its auth stack are skipped.

Adding CentralAuth to the gate would thus removal all CI testing of a critical part of MediaWiki core, sadly.

Dreamy_Jazz added a comment.EditedOct 27 2022, 9:36 PM

Ah. I had not realised that this was the case. The parent task made it seem that adding CentralAuth was something that would be okay in theory, but obviously not on further look. Is there any other way that CheckUser can access code in CentralAuth? Specifically I want to be able to use CentralAuthUser::AUTHENTICATE_GOOD_PASSWORD over writing out "good password" in an integration test.

gerritbot added a comment.Oct 27 2022, 9:37 PM

Change 850278 abandoned by Dreamy Jazz:

[integration/config@master] Add CentralAuth to the gated extensions list

Reason:

Per -2 plus explanation on the ticket this ain't happening.

https://gerrit.wikimedia.org/r/850278

Dreamy_Jazz closed this task as Declined.Oct 27 2022, 9:38 PM

Per the above.

Maintenance_bot removed a project: Patch-For-Review.Oct 27 2022, 10:30 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL