Page MenuHomePhabricator
Create Task
Maniphest T321890

FunctionDefinition: Edit button going to the wrong place
Closed, ResolvedPublicBUG REPORT
Actions

Description

The "EDIT" button on the function definition details page should navigate to the function editor but instead it navigates to the function definition about tab.

Steps to reproduce:

  1. Load a ZFunction page (ex: https://wikifunctions.beta.wmflabs.org/wiki/Z10056?view=function-viewer)
  2. Navigate to the details tab
  3. Click the "EDIT" button next to the words "Function Definition" in the side panel

Screen Shot 2022-10-28 at 8.08.50 AM.png (584×1 px, 93 KB)

Observed behavior:

  • You are redirected to the function page's about tab

**Expected behavior (Acceptance criteria):

  • You are brought to the function definition editor

Devices and Design (URLs or screenshots, if applicable):

  • Desktop: ...
  • Small screens/mobile: ...

Completion checklist

Details

SubjectRepoBranchLines +/-
Fix routing and align vue route with wikimedia routingmediawiki/extensions/WikiLambdamaster+667 -270
Customize query in gerrit

Related Objects

Event Timeline

• JKieserman renamed this task from <Component>: <Short one-liner describing the problem> to FunctionDefinition: Edit button going to the wrong place.Oct 28 2022, 12:10 PM
• JKieserman created this task.
• JKieserman updated the task description. (Show Details)
gengh moved this task from To triage to Phase θ – Throttling on the Abstract Wikipedia team board.Nov 8 2022, 2:58 PM
gengh edited projects, added Abstract Wikipedia team (Phase θ – Throttling); removed Abstract Wikipedia team.
gengh moved this task from Incoming to Ready: G4. Function view on the Abstract Wikipedia team (Phase θ – Throttling) board.Nov 8 2022, 3:43 PM
• AdesojiThisDot claimed this task.Nov 9 2022, 10:39 AM
gerritbot added a comment.Nov 10 2022, 3:50 PM

Change 855616 had a related patch set uploaded (by AdesojiThisDot; author: AdesojiThisDot):

[mediawiki/extensions/WikiLambda@master] Fix routing and align vue route with wikimedia routing

https://gerrit.wikimedia.org/r/855616

gerritbot added a project: Patch-For-Review.Nov 10 2022, 3:50 PM
gerritbot added a comment.Nov 10 2022, 6:08 PM

Change 855616 had a related patch set uploaded (by Jforrester; author: AdesojiThisDot):

[mediawiki/extensions/WikiLambda@master] Fix routing and align vue route with wikimedia routing

https://gerrit.wikimedia.org/r/855616

gengh mentioned this in T320506: Handle page layout correctly based on ZObject type and url param.Nov 23 2022, 8:07 AM
gerritbot added a comment.Dec 12 2022, 2:29 PM

Change 855616 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Fix routing and align vue route with wikimedia routing

https://gerrit.wikimedia.org/r/855616

DVrandecic closed this task as Resolved.Dec 23 2022, 12:07 AM
DVrandecic moved this task from Ready: G4. Function view to QA / Ready to close on the Abstract Wikipedia team (Phase θ – Throttling) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL