Page MenuHomePhabricator

ZLabelsBlock: Need to click delete twice to remove an alias
Closed, ResolvedPublicBUG REPORT

Description

Description

Steps to reproduce:

  1. Go to the create z object page (https://wikifunctions.beta.wmflabs.org/wiki/Special:CreateZObject)
  2. Type a new alias in the alias string box
  3. click the trash icon to delete that alias

Observed behavior:

  • It doesn't delete until I click a second time (note: this only appears to happen for the first language)

Expected behavior (Acceptance criteria):

  • it should delete on the first click

Devices and Design (URLs or screenshots, if applicable):

  • Desktop: ...
  • Small screens/mobile: ...

Completion checklist

Event Timeline

Let's keep this task in the phase backlog.
This should be solved, but I believe that this might get solved when we implement the new default component.

Change 855958 had a related patch set uploaded (by Teleosteen; author: Teleosteen):

[mediawiki/extensions/WikiLambda@master] Fix ZLabelsBlock: Need to click delete twice to remove an alias

https://gerrit.wikimedia.org/r/855958

I proposed a fix which changes the behavior. Not sure about the UX though.

If you believe we should rather wait for the new component as mentioned @gengh, I can close the gerrit ticket and wait until then.

I've seen your suggestion and it affects the UX of a component that is being currently redesigned and will be completely reworked -- hence leaving it out of scope. Sadly, I believe it would be better to close the ticket and focus on scoped tasks.

Is there a way that I can better reflect that a task is unscoped so that you don't waste your effort? I generally try to reflect this by leaving the tasks in "Incoming" and, if necessary, using the comments to justify why they remain out of scope. I'm open to any suggestions that would make this clearer.

Thanks a lot for your help, as always.

I am the one to apologize, I'd rather know how probable the might in this sentence meant: This should be solved, but I believe that this might get solved when we implement the new default component.
At first, when I sought for an answer, I felt like a fix was not taking that much time, but that wasn't considering the review.

And don't worry about my patch, as I said, that wasn't much time, I don't feel bad about closing the ticket any at all.

Change 855958 abandoned by Teleosteen:

[mediawiki/extensions/WikiLambda@master] Fix ZLabelsBlock: Need to click delete twice to remove an alias

Reason:

Altering the UX for fixing the issue is not a viable solution

https://gerrit.wikimedia.org/r/855958

Jdforrester-WMF claimed this task.
Jdforrester-WMF subscribed.

This has been Resolved by the replacement of this UX with the new system. I also confirmed that this wasn't present in the Function editor.