Page MenuHomePhabricator

Special:NewPagesFeed filters "Reviewed pages" and "Nominated for deletion" should not be checked by default
Closed, ResolvedPublic

Description

Consensus is leaning this way at https://en.wikipedia.org/wiki/Wikipedia_talk:New_pages_patrol/Reviewers#Proposal_to_change_the_default_filters_for_fresh_NPPers

May just be able to adjust the default states of the check boxes in modules/ext.pageTriage.views.list/ext.pageTriage.listControlNav.underscore

If this doesn't work, may need to dig into the Underscore.view model at modules/ext.pageTriage.views.list/ext.pageTriage.listControlNav.js. There's a bunch of code that ferries settings back and forth between local storage, the view model, and the HTML form. Unclear where it gets its defaults from.

image.png (1×1 px, 187 KB)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

"Reviewed pages" may already be removed from the default. I cleared my cookies and my local storage, and this setting was not checked. If you can confirm, feel free to rename the ticket.

"Reviewed pages" may already be removed from the default. I cleared my cookies and my local storage, and this setting was not checked. If you can confirm, feel free to rename the ticket.

"Reviewed pages" are shown by default. Log out of wikipedia (or use a private browsing tab) and check https://en.wikipedia.org/wiki/Special:NewPagesFeed for verification.

If this doesn't work, may need to dig into the Underscore.view model at modules/ext.pageTriage.views.list/ext.pageTriage.listControlNav.js. There's a bunch of code that ferries settings back and forth between local storage, the view model, and the HTML form. Unclear where it gets its defaults from.

The default settings are in https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/PageTriage/+/refs/heads/master/modules/ext.pageTriage.util/models/ext.pageTriage.article.js#272 with some code needed to be changed in https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/PageTriage/+/refs/heads/master/modules/ext.pageTriage.views.list/ext.pageTriage.listControlNav.js#465

Change 858451 had a related patch set uploaded (by MPGuy2824; author: MPGuy2824):

[mediawiki/extensions/PageTriage@master] NewPagesFeed filters: Change the default filters for a new user

https://gerrit.wikimedia.org/r/858451

MPGuy2824 changed the task status from Open to In Progress.Nov 18 2022, 6:10 AM
MPGuy2824 claimed this task.
MPGuy2824 moved this task from Priority small features to Code Review on the PageTriage board.

Change 858451 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] NewPagesFeed filters: Change the default filters for a new user

https://gerrit.wikimedia.org/r/858451

EUdoh-WMF added a subscriber: EUdoh-WMF.

Changes look good! I opened this on an incognito browser as an anonymous user and Reviewed pages and Nominated for deletion filters are unchecked by default.

image.png (1×1 px, 580 KB)

MPGuy2824 moved this task from Waiting for enwiki deploy to Done on the PageTriage board.