Just like we have hit/timing metrics for api.php requests by module, the same should be done for rest entrypoints. We could use the first component of each RestRoutes entry path.
A dashboard should exist, similar to https://grafana.wikimedia.org/d/000000559/api-requests-breakdown?orgId=1
| Subject | Author | Repo | Branch | Lines +/- | |
|---|---|---|---|---|---|
| REST: collect metrics on endpoint access | Daniel Kinzler | mediawiki/core | master | +70 -5 |
Hey @WDoranWMF and @daniel !
We've detected that rest.php could benefit from the same instrumentation api.php already has.
This is a small effort and would help us a lot with our goal to share knowledge and performance awareness with the rest of the Org, not only on how to make the instrumentation available but also how to instruct other teams on how to use it.
Do you think it's possible to get someone to work on this? @aaron could definitely help or pair program with the person.
Change 867616 had a related patch set uploaded (by Krinkle; author: Daniel Kinzler):
[mediawiki/core@master] REST: collect metrics on endpoint access
Change 867616 merged by jenkins-bot:
[mediawiki/core@master] REST: collect metrics on endpoint access