Page MenuHomePhabricator
Create Task
Maniphest T321988

Field Target on Special:Log is not filled with value of parameter page
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

What happens?:

  • The field Target is empty.
  • A click on the button Show show the logs for all pages.

What should have happened instead?:

  • The field Target should contain the page Compatibility.
  • A click on the button Show should show the logs of the page Compatibility.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Prefill page/pattern/tagfilter/offender in form for Special:Logmediawiki/coremaster+18 -5
Customize query in gerrit

Related Objects

Event Timeline

Fomafix created this task.Oct 30 2022, 9:01 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 30 2022, 9:01 AM
Fomafix added a subscriber: Bawolff.Oct 30 2022, 9:59 AM

The field Target is not filled with the value of the URL parameter page since rMW72913f4cc3f4: Call setFormIdentifier() on LogEventsList form.

Fomafix edited projects, added MediaWiki-Logevents, MediaWiki-HTMLForm; removed MediaWiki-Special-pages.Oct 30 2022, 1:34 PM
Fomafix added a comment.Oct 30 2022, 6:43 PM

A simple fix would be to use the link

https://www.mediawiki.org/w/index.php?title=Special:Log&page=Compatibility&wpFormIdentifier=logeventslist

instead of

https://www.mediawiki.org/w/index.php?title=Special:Log&page=Compatibility

on https://www.mediawiki.org/w/index.php?title=Compatibility&action=history but there are also other links which use the URL parameter page.

hoo subscribed.Oct 31 2022, 12:27 PM

LogEventsList::getTitleInputDesc already gets the title input, it "just" needs to be title formatted and passed as default.

Umherirrender claimed this task.Oct 31 2022, 9:22 PM

For user it works already (due to T200446)

gerritbot added a comment.Oct 31 2022, 9:23 PM

Change 851133 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] Prefill page/pattern/tagfilter/offender in form for Special:Log

https://gerrit.wikimedia.org/r/851133

gerritbot added a project: Patch-For-Review.Oct 31 2022, 9:23 PM
AntiCompositeNumber subscribed.Nov 1 2022, 1:46 AM
matej_suchanek merged a task: T323449: "Target (pagename or user)" field on log pages isn't filled when should be.Nov 20 2022, 9:50 AM
matej_suchanek added subscribers: MBH, Base.
gerritbot added a comment.Nov 23 2022, 11:35 AM

Change 851133 merged by jenkins-bot:

[mediawiki/core@master] Prefill page/pattern/tagfilter/offender in form for Special:Log

https://gerrit.wikimedia.org/r/851133

matmarex closed this task as Resolved.Nov 23 2022, 11:37 AM
matmarex subscribed.

The fix will be deployed to Wikimedia wikis next week, per the usual schedule.

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.12; 2022-11-28).Nov 23 2022, 12:01 PM
Maintenance_bot removed a project: Patch-For-Review.Nov 23 2022, 12:30 PM
Xaosflux mentioned this in T323720: incoming links to Special Log shouldn't require wpFormIdentifier to be included.Nov 23 2022, 4:44 PM
Umherirrender merged a task: T323720: incoming links to Special Log shouldn't require wpFormIdentifier to be included.Nov 23 2022, 6:31 PM
Umherirrender added subscribers: Xaosflux, Umherirrender.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits