| bmartinezcalvo | |
| Oct 31 2022, 11:02 AM |
| F58154160: linkExternal-rtl.svg | |
| Jan 9 2025, 4:18 PM |
| F57577035: linkExternal-rtl.svg | |
| Oct 1 2024, 10:42 AM |
| F57572812: linkExternal.svg | |
| Sep 30 2024, 5:04 PM |
| F36439681: External-link_Icon_SVG.zip | |
| Jan 23 2023, 2:48 PM |
| F35677487: Captura de Pantalla 2022-10-31 a las 12.00.11.png | |
| Oct 31 2022, 11:02 AM |
External link icon was updated in this task and we should use this new icon for the Codex Link component T309248 as specified in the Figma spec sheet.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Update Codex from v1.13.0 to v1.13.1 | mediawiki/core | master | +168 -122 | |
| icons: Add new external link icon | design/codex | main | +1 -2 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Invalid | None | T307319 Design System Codex / Wikit | |||
| Resolved | CCiufo-WMF | T309248 [EPIC] Add Link component to Codex | |||
| Resolved | lwatson | T322014 icons, Link: Add new external link icon |
@bmartinezcalvo - can you please put an initial/proposed priority level on this task and move it to the Backlog column?
DST prioritization guidance
Since the new external link icon was already designed (added in the task description) we could implement it soon.
Change #1076028 had a related patch set uploaded (by LWatson; author: LWatson):
[design/codex@main] icons, Link: Add new external link icon
@bmartinezcalvo My understanding is to remove the existing externalLink icon in Codex and replace it with the new icon image(s). This way the icons in Codex and Figma match. Does that sound right?
Other questions:
We shouldn't have to change anything with the Link yet, that work is captured in T369869. For now we want to preserve the current, but just have a new icon.
Thanks! I'll update the SVG image for externalLink icon if I understand that correctly. The current icon image flips/mirrors so I will not change that.
Right, this task is just to include the externalLink icon within the Codex list of icons.
Sorry for the back and forth. An externalLink icon already exists in Codex and this list of icons. Do we want to introduce a new icon (different from the existing externalLink ) or update externalLink icon's SVG image to the SVG in the task description?
@bmartinezcalvo, I have a request for when you return to the office. To resolve this task, we may need to export a 20x20 SVG image so that the external link icon is the same size as the other icons. The SVG in the task description is 12x12. Could we update the SVG to fit the standard 20x20 size (based on Codex SVG conventions)?
Change #1076028 merged by jenkins-bot:
[design/codex@main] icons: Add new external link icon
Change #1077085 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):
[mediawiki/core@master] Update Codex from v1.13.0 to v1.13.0
Test wiki created on Patch demo by ATomasevich (WMF) using patch(es) linked to this task:
http://patchdemo.wmcloud.org/wikis/f142db38be/w/
Change #1077085 merged by jenkins-bot:
[mediawiki/core@master] Update Codex from v1.13.0 to v1.13.1
Test wiki on Patch demo by ATomasevich (WMF) using patch(es) linked to this task was deleted:
Thanks for flagging this! It was my error for not updating the icon in OOUI. I filed a new task to update the icon in OOUI T383086
Hey @bmartinezcalvo, can you update the linkExternal-rtl SVG image in the task description when you have time? The RTL image's arrow should point to the northwest. In Codex we flip the LTR image but in OOUI we need both LTR and RTL images.
