Page MenuHomePhabricator
Create Task
Maniphest T322015

[S] SearchPreview - Performance Review - Change the TOC link to improve CDN caching
Closed, ResolvedPublic
Actions

Description

This ticket is a follow-up of the comment received from the performance review https://phabricator.wikimedia.org/T307736:

The TOC links should probably use cannonical /wiki/X#Y URLs instead of ?title=X#Y URLS. This grants better CDN caching.

AC:

  • Change the link generated for the sections to be /wiki/X#Y format instead than ?title=x#y

Details

SubjectRepoBranchLines +/-
Use cannonical /wiki/X#Y URLs instead of ?title=X#Y URLSmediawiki/extensions/SearchVuemaster+33 -18
Customize query in gerrit

Related Objects

Event Timeline

SimoneThisDot created this task.Oct 31 2022, 11:03 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 31 2022, 11:03 AM
CBogen edited projects, added Structured-Data-Backlog; removed Structured-Data-Backlog (Current Work).Oct 31 2022, 12:20 PM
CBogen edited projects, added Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog.Oct 31 2022, 4:47 PM
CBogen moved this task from Incoming to Ready for Estimation on the Structured-Data-Backlog (Current Work) board.
matthiasmullie claimed this task.Nov 2 2022, 4:28 PM
matthiasmullie moved this task from Ready for Estimation to Code Review on the Structured-Data-Backlog (Current Work) board.
CBogen renamed this task from SearcPreview - Performance Review - Change the TOC link to improve CDN caching to [S] SearchPreview - Performance Review - Change the TOC link to improve CDN caching.Nov 2 2022, 4:28 PM
CBogen removed matthiasmullie as the assignee of this task.
CBogen added a subscriber: matthiasmullie.
gerritbot added a comment.Nov 2 2022, 4:29 PM

Change 850166 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):

[mediawiki/extensions/SearchVue@master] Use cannonical /wiki/X#Y URLs instead of ?title=X#Y URLS

https://gerrit.wikimedia.org/r/850166

gerritbot added a project: Patch-For-Review.Nov 2 2022, 4:29 PM
SimoneThisDot assigned this task to matthiasmullie.Nov 10 2022, 10:50 AM
gerritbot added a comment.Nov 15 2022, 3:32 PM

Change 850166 merged by jenkins-bot:

[mediawiki/extensions/SearchVue@master] Use cannonical /wiki/X#Y URLs instead of ?title=X#Y URLS

https://gerrit.wikimedia.org/r/850166

matthiasmullie mentioned this in rESVU18eb6561d6e5: Use cannonical /wiki/X#Y URLs instead of ?title=X#Y URLS.Nov 15 2022, 3:32 PM
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.12; 2022-11-28).Nov 15 2022, 4:00 PM
Maintenance_bot removed a project: Patch-For-Review.Nov 15 2022, 4:30 PM
Cparle subscribed.Nov 17 2022, 4:06 PM

@matthiasmullie can this be moved to QA?

matthiasmullie moved this task from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.Nov 21 2022, 1:35 PM
Cparle added a subscriber: Krinkle.Dec 5 2022, 5:19 PM

@matthiasmullie who signs off on this? is it @Krinkle ?

Krinkle closed this task as Resolved.Dec 21 2022, 12:00 AM

Sure. Based on https://en.wikipedia.beta.wmflabs.org/w/index.php?go=Go&search=Conflict&title=Special:Search&ns0=1, this LGTM.

Krinkle added a project: Performance-Team (Radar).Dec 21 2022, 12:00 AM
Krinkle moved this task from Limbo to Perf recommendation on the Performance-Team (Radar) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL