Maniphest T322049

PublishDialog: warning for deattaching testers/implementations
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• JKieserman
	Oct 31 2022, 5:21 PM

Description

When a user modifies the type of inputs and/or output, any attached testers and implementations will be deattached, assuming they will no longer function properly. Before a user saves this type of change, they should be warned of the consequences of this action.

Desired behavior/Acceptance criteria

a warning is shown in the publish dialog UI

Devices and Design (URLs or screenshots)

Desktop: https://www.figma.com/file/2v8obpswfHqr3ZT5W8CkJk/Publish-component?node-id=604%3A41421
Small screens/mobile: https://www.figma.com/file/2v8obpswfHqr3ZT5W8CkJk/Publish-component?node-id=581%3A38780

Completion checklist

Before closing this task, review one by one the checklist available here: https://www.mediawiki.org/wiki/Abstract_Wikipedia_team/Definition_of_Done#Front-end_Task/Bug_Completion_Checklist

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Add warning for when input or output type has changed and function implementations/testers would be removed.	mediawiki/extensions/WikiLambda	master	+101 -23

Customize query in gerrit

Event Timeline

• JKieserman created this task.Oct 31 2022, 5:21 PM

AAlhazwani-WMF updated the task description. (Show Details)Oct 31 2022, 5:29 PM

Change 851043 had a related patch set uploaded (by Dani DW; author: Dani DW):

[mediawiki/extensions/WikiLambda@master] Add warning for when input or output type has changed and so a function implementations and testers will be detached.

https://gerrit.wikimedia.org/r/851043

gerritbot added a project: Patch-For-Review.Nov 2 2022, 9:14 PM

Change 851043 had a related patch set uploaded (by Dani DW; author: Dani DW):

[mediawiki/extensions/WikiLambda@master] Add warning for when input or output type has changed and function implementations/testers would be removed.

https://gerrit.wikimedia.org/r/851043

Change 851043 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Add warning for when input or output type has changed and function implementations/testers would be removed.

https://gerrit.wikimedia.org/r/851043

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.10; 2022-11-14).Nov 7 2022, 9:00 PM

gengh moved this task from To Triage to Phase θ – Throttling on the Abstract Wikipedia team board.Nov 8 2022, 2:54 PM

gengh edited projects, added Abstract Wikipedia team (Phase θ – Throttling); removed Abstract Wikipedia team.

gengh moved this task from Incoming to Ready: G5. Fallback view on the Abstract Wikipedia team (Phase θ – Throttling) board.Nov 8 2022, 3:39 PM