Page MenuHomePhabricator

Enable viewing of reading lists on web
Closed, ResolvedPublic

Description

Currently reading lists can be created in the Wikipedia apps but cannot be viewed on web.

In T317935 we added functionality to view lists. It can be seen on the beta cluster here:
https://en.wikipedia.beta.wmflabs.org/wiki/Special:ReadingLists

Screen Shot 2022-10-31 at 4.58.26 PM.png (812×1 px, 88 KB)

Screen Shot 2022-10-31 at 4.58.38 PM.png (566×1 px, 64 KB)

Remaining work is to review the feature and enable the feature flag.

Event Timeline

A year or so ago, I have spent several hours writing a script to view reading lists, https://meta.wikimedia.org/wiki/User:Base/Scripts/ReadingListViewer.js , only to discover another script that does that, only to later discover that that one actually doesn't work and I would eventually have to finish my own one: I am glad I wouldn't have to :)

What’s the status of this? Over a month passed, and I still get permission denied error on production wikis.

@Tacsipacsi it needs to be enabled on the project that wants it via backport! The config option is $wgReadingListsWebAuthenticatedPreviews
I think the code is ready, I just haven't had the time to drive it. Feel free to do that if you feel motivated!

Alternatively, I've got a gadget you can install which turns it on and also adds the ability to modify and add/remove to lists:

mw.loader.load( 'https://en.wikipedia.org/w/index.php?title=User:Jdlrobson/readingList.js&action=raw&ctype=text/javascript' );

@Tacsipacsi it needs to be enabled on the project that wants it via backport!

Don’t you plan to enable it on all Wikipedias, as opposed to only those that explicitly want it? Or do you plan to have some opt-in early adopter wikis, and enable it everywhere later?

The config option is $wgReadingListsWebAuthenticatedPreviews
I think the code is ready, I just haven't had the time to drive it. Feel free to do that if you feel motivated!

I could create a patch for InitialiseSettings.php, but I don’t know whether any checks are needed after deploying, and if yes, which. If you say it’s okay to deploy it without any checks, I’m happy to prepare the patch if my time allows.

Alternatively, I've got a gadget you can install which turns it on and also adds the ability to modify and add/remove to lists:

mw.loader.load( 'https://en.wikipedia.org/w/index.php?title=User:Jdlrobson/readingList.js&action=raw&ctype=text/javascript' );

Thanks, but it’s not that important for me, I have my phone with which I can access the list. I was just annoyed that this feature is seemingly ready, other people probably need it, and it’s blocked on just toggling a feature switch.

Don’t you plan to enable it on all Wikipedias, as opposed to only those that explicitly want it? Or do you plan to have some opt-in early adopter wikis, and enable it everywhere later?

Eventually yes, just December is not a good time for all projects. I was targeting February/March. If any projects want to get it early they can go head and do that, provided the associated community is aware and happy with the feature being added. Right now there is no way to add or remove items to the list (without using the app or gadgets) so there are no plans to advertise the feature broadly.

Hi, is there any update on this? Thank you guys!

@Ntache7: Hi, all available updates are in this very task.

@Tacsipacsi @Ntache7 I'll be looking at enabling this for pilot communities later this month, ideally communities that will use it and report bugs. If you want your community to be a pilot community could you start a conversation on your relevant community portal per https://wikitech.wikimedia.org/wiki/Wikimedia_site_requests#Lifecycle_of_a_request ? "The local project discusses the matter in public, in the manner the most appropriated for this project."

In lieu of any communities stepping forward I'm guessing meta and mediawiki would be the first ones to trial the feature.

Change 902197 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Enable web based viewing of ReadingLists on mediawiki.org and metawiki

https://gerrit.wikimedia.org/r/902197

Change 902197 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable web based viewing of ReadingLists on mediawiki.org and metawiki

https://gerrit.wikimedia.org/r/902197

Mentioned in SAL (#wikimedia-operations) [2023-03-27T20:10:02Z] <kindrobot@deploy2002> Started scap: Backport for [[gerrit:903322|Expand list of wikis with language button at top. (T331777)]], [[gerrit:902197|Enable web based viewing of ReadingLists on mediawiki.org and metawiki (T322093)]]

Mentioned in SAL (#wikimedia-operations) [2023-03-27T20:11:29Z] <kindrobot@deploy2002> jdlrobson and kindrobot: Backport for [[gerrit:903322|Expand list of wikis with language button at top. (T331777)]], [[gerrit:902197|Enable web based viewing of ReadingLists on mediawiki.org and metawiki (T322093)]] synced to the testservers: mwdebug2002.codfw.wmnet, mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug1001.eqiad.wmnet

Mentioned in SAL (#wikimedia-operations) [2023-03-27T20:20:52Z] <kindrobot@deploy2002> Finished scap: Backport for [[gerrit:903322|Expand list of wikis with language button at top. (T331777)]], [[gerrit:902197|Enable web based viewing of ReadingLists on mediawiki.org and metawiki (T322093)]] (duration: 10m 50s)

Jdlrobson claimed this task.

The feature is now enabled on meta.wikimedia.org and mediawiki.org. I've found a few bugs with the feature already, so if you are subscribed to this please do give it a test and file tasks for anything you can think of to MediaWiki-extensions-ReadingList so that we can improve it and deploy it more widely.

Another thing I miss is being able to see the articles on a shared list in the browser, without opening the app. Would it be possible in the current iteration?

@Tacsipacsi my worry here is whether this would require moderation from editors given that is what led to the Gather RFC on English Wikipedia. Since any list can be shared, it's very possible to construct and share a list which may be problematic with no way to moderate the content (E.g. suppress it). On the other hand, in this situation, you have to be logged in to view the shared list, so maybe it' s not a problem? One possible thing we could do is add a user right, that we check that disables sharing of previews for the associated user, that admins could use to moderate if necessary, but perhaps that's not needed.

Enabling it is easy - the flag wgReadingListsAnonymizedPreviews = true and I'd love to do that, but ideally I'd want some kind of discussion in our communities before doing that. Is that something you could help with?

I didn’t read through the original VP discussion (it being long is an understatement), but to react to the points in the RFC “Background” section:

  • Fair use images: the preview of the shared list wouldn’t be the first place where the list items appear, they can also be seen in the apps or on the web in one’s own reading lists. So I assume this is already handled, fair use images are hidden, aren’t they?
  • Moderation: yep, this is an even larger issue, as the list content is encoded into the URL, making it impossible rather than just hard to moderate. However, given that it contains nothing more than a list of titles, plus a title and a description, I don’t really see the issue with the lack of moderation; since a direct link is required to access it, the person sending the URL could just send the content, which could not be moderated either. Also, after importing the list into the app, it can be viewed regardless (in theory; I couldn’t make it work), showing it on the web just makes the feature more convenient, not more powerful, doesn’t it?
  • Bugs, overrun time limit: don’t apply here.

I didn't know the lists could be shared. There definitely has to be a way to redact content of the name and description of the list, perhaps at least as crudely as w.wiki links can be deleted by stews.