Page MenuHomePhabricator
Create Task
Maniphest T322097

Add a Proper Logger to the Evaluator
Closed, ResolvedPublic
Actions

Description

Description

Evaluator code currently just uses console.log; it should use a logger like what's used in function-orchestrator (see T290700).

Desired behavior/Acceptance criteria (returned value, expected error, performance expectations, etc.)

  • function-evaluator will use a logger instead of bare logging to the console

Remove all the non-applicable tags from the "Tags" field, leave only the tags of the projects/repositories related to this task

Completion checklist

Details

SubjectRepoBranchLines +/-
Use wrapped logger throughout evaluator.mediawiki/services/function-evaluatormaster+61 -11
Update function-schemata sub-module to HEAD (adb4e69)mediawiki/extensions/WikiLambdamaster+1 -1
Update function-schemata sub-module to HEAD (adb4e69)mediawiki/tools/wikilambda-climaster+1 -1
Update function-schemata sub-module to HEAD (adb4e69)mediawiki/services/function-evaluatormaster+1 -1
Update function-schemata sub-module to HEAD (adb4e69)mediawiki/services/function-orchestratormaster+1 -1
Update function-schemata sub-module to HEAD (adb4e69)mediawiki/services/function-orchestratormaster+1 -1
Update function-schemata sub-module to HEAD (adb4e69)mediawiki/services/function-evaluatormaster+1 -1
Add LoggerWrapper class to be shared among backend services.mediawiki/services/function-schematamaster+200 -0
Customize query in gerrit

Related Objects

Event Timeline

cmassaro created this task.Nov 1 2022, 1:33 AM
DVrandecic moved this task from To triage to Phase θ – Throttling on the Abstract Wikipedia team board.Nov 15 2022, 7:50 PM
DVrandecic edited projects, added Abstract Wikipedia team (Phase θ – Throttling); removed Abstract Wikipedia team.
Jdforrester-WMF moved this task from Incoming to Ready: Errors on the Abstract Wikipedia team (Phase θ – Throttling) board.Nov 15 2022, 8:45 PM
Jdforrester-WMF updated the task description. (Show Details)Jan 11 2023, 4:11 PM
Jdforrester-WMF triaged this task as High priority.Jan 11 2023, 8:14 PM
cmassaro claimed this task.Mar 27 2023, 11:10 PM
gerritbot added a comment.Mar 28 2023, 7:29 PM

Change 903703 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[mediawiki/services/function-schemata@master] Add LoggerWrapper class to be shared among backend services.

https://gerrit.wikimedia.org/r/903703

gerritbot added a project: Patch-For-Review.Mar 28 2023, 7:29 PM
gerritbot added a comment.Mar 30 2023, 7:02 PM

Change 903764 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[mediawiki/services/function-evaluator@master] Use wrapped logger throughout evaluator.

https://gerrit.wikimedia.org/r/903764

gerritbot added a comment.Mar 30 2023, 10:08 PM

Change 903703 merged by jenkins-bot:

[mediawiki/services/function-schemata@master] Add LoggerWrapper class to be shared among backend services.

https://gerrit.wikimedia.org/r/903703

cmassaro mentioned this in rMSFSadb4e699831c: Add LoggerWrapper class to be shared among backend services..Mar 30 2023, 10:08 PM
gerritbot added a comment.Mar 30 2023, 11:50 PM

Change 904646 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (adb4e69)

https://gerrit.wikimedia.org/r/904646

gerritbot added a comment.Mar 31 2023, 2:50 PM

Change 904812 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (adb4e69)

https://gerrit.wikimedia.org/r/904812

gerritbot added a comment.Apr 3 2023, 1:00 PM

Change 905223 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/tools/wikilambda-cli@master] Update function-schemata sub-module to HEAD (adb4e69)

https://gerrit.wikimedia.org/r/905223

gerritbot added a comment.Apr 3 2023, 1:00 PM

Change 905224 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (adb4e69)

https://gerrit.wikimedia.org/r/905224

gerritbot added a comment.Apr 3 2023, 1:00 PM

Change 905225 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (adb4e69)

https://gerrit.wikimedia.org/r/905225

gerritbot added a comment.Apr 3 2023, 1:00 PM

Change 905226 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (adb4e69)

https://gerrit.wikimedia.org/r/905226

gerritbot added a comment.Apr 3 2023, 1:50 PM

Change 905224 abandoned by Jforrester:

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (adb4e69)

Reason:

Dupe of I5090a1ad6df33dd242d5d9bfe14839cadf25d23a.

https://gerrit.wikimedia.org/r/905224

gerritbot added a comment.Apr 3 2023, 1:51 PM

Change 905225 abandoned by Jforrester:

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (adb4e69)

Reason:

Dupe of I05e85562470a0a27d1f387b02c451bbcebe5a8bb.

https://gerrit.wikimedia.org/r/905225

gerritbot added a comment.Apr 3 2023, 1:53 PM

Change 904646 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (adb4e69)

https://gerrit.wikimedia.org/r/904646

cmassaro mentioned this in rMSFOc491015a69a6: Update function-schemata sub-module to HEAD (adb4e69).Apr 3 2023, 1:53 PM
gerritbot added a comment.Apr 3 2023, 1:54 PM

Change 904812 merged by jenkins-bot:

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (adb4e69)

https://gerrit.wikimedia.org/r/904812

cmassaro mentioned this in rMSFEc208f785b2ad: Update function-schemata sub-module to HEAD (adb4e69).Apr 3 2023, 1:54 PM
gerritbot added a comment.Apr 3 2023, 3:01 PM

Change 905223 merged by jenkins-bot:

[mediawiki/tools/wikilambda-cli@master] Update function-schemata sub-module to HEAD (adb4e69)

https://gerrit.wikimedia.org/r/905223

Jdforrester-WMF mentioned this in rMTWC9539cf18c159: Update function-schemata sub-module to HEAD (adb4e69).Apr 3 2023, 3:01 PM
gerritbot added a comment.Apr 3 2023, 3:03 PM

Change 905226 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (adb4e69)

https://gerrit.wikimedia.org/r/905226

gerritbot added a comment.Apr 4 2023, 2:15 PM

Change 903764 merged by jenkins-bot:

[mediawiki/services/function-evaluator@master] Use wrapped logger throughout evaluator.

https://gerrit.wikimedia.org/r/903764

cmassaro mentioned this in rMSFEdbfd014b1b1a: Use wrapped logger throughout evaluator..Apr 4 2023, 2:16 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 4 2023, 2:31 PM
Jdforrester-WMF closed this task as Resolved.Jun 8 2023, 8:33 PM
Jdforrester-WMF moved this task from Ready: Errors to QA / Ready to close on the Abstract Wikipedia team (Phase θ – Throttling) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL