Page MenuHomePhabricator

TwoColConflict support for PHP 8.1
Closed, ResolvedPublic

Description

PHPUnit failures:

There was 1 error:

1) TwoColConflict\Tests\TwoColConflictHooksTest::testOnEditPageShowEditFormFields
strtolower(): Passing null to parameter #1 ($string) of type string is deprecated

/srv/mw/core/includes/context/RequestContext.php:396
/srv/mw/core/includes/context/RequestContext.php:465
/srv/mw/core/includes/language/Message.php:385
/srv/mw/core/includes/language/Message.php:984
/srv/mw/core/includes/language/Message.php:1054
/srv/mw/extensions/TwoColConflict/includes/Html/CoreUiHintHtml.php:37
/srv/mw/extensions/TwoColConflict/includes/Hooks/TwoColConflictHooks.php:139
/srv/mw/extensions/TwoColConflict/includes/Hooks/TwoColConflictHooks.php:124
/srv/mw/extensions/TwoColConflict/tests/phpunit/TwoColConflictHooksTest.php:300
/srv/mw/core/tests/phpunit/MediaWikiIntegrationTestCase.php:518
=== Logs generated by test case
[objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
[localisation] [debug] LocalisationCache using store LCStoreNull []
[objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
===

--

There was 1 failure:

1) TwoColConflict\Tests\AnnotatedHtmlDiffFormatterTest::testFormat with data set #9 ('Just a multi-line text.\nLine...above.', 'Just a multi-line text.\nAdd ...stuff.', array(array('copy', 'Just a multi-line text.'), array('change', 'Line number two. <del class=".../del>.', 'Line number two. This line is...above.', '<ins class="mw-twocolconflict.../ins>.', 'Add something new.\nLine numb...stuff.')))
Failed asserting that two arrays are identical.
--- Expected
+++ Actual
@@ @@
     1 => Array &2 (
         'action' => 'change'
         'oldhtml' => 'Line number two. <del class="mw-twocolconflict-diffchange">This </del>line <del class="mw-twocolconflict-diffchange">is </del>quite long!\n
-<del class="mw-twocolconflict-diffchange">And that's line number three - even longer than the line before.</del>\n
+<del class="mw-twocolconflict-diffchange">And that&#039;s line number three - even longer than the line before.</del>\n
  \n
 <del class="mw-twocolconflict-diffchange">Just another line with an empty line above</del>.'
         'oldtext' => 'Line number two. This line is quite long!\n

/srv/mw/extensions/TwoColConflict/tests/phpunit/unit/AnnotatedHtmlDiffFormatterTest.php:28
/srv/mw/core/tests/phpunit/MediaWikiUnitTestCase.php:116

Related Objects

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Event Timeline

Change 851743 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/core@master] WordAccumulator: use htmlspecialchars with ENT_NOQUOTES

https://gerrit.wikimedia.org/r/851743

Change 851745 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/core@master] Make RequestContext::sanitizeLangCode() accept null

https://gerrit.wikimedia.org/r/851745

Change 851743 merged by jenkins-bot:

[mediawiki/core@master] WordAccumulator: use htmlspecialchars with ENT_NOQUOTES

https://gerrit.wikimedia.org/r/851743

Change 851745 merged by jenkins-bot:

[mediawiki/core@master] Make RequestContext::sanitizeLangCode() accept null

https://gerrit.wikimedia.org/r/851745

Change #1172074 had a related patch set uploaded (by SBassett; author: Tim Starling):

[mediawiki/core@REL1_39] Make RequestContext::sanitizeLangCode() accept null

https://gerrit.wikimedia.org/r/1172074

Change #1172074 merged by jenkins-bot:

[mediawiki/core@REL1_39] Make RequestContext::sanitizeLangCode() accept null

https://gerrit.wikimedia.org/r/1172074