Page MenuHomePhabricator
Create Task
Maniphest T322115

Make edit summary readable for MediaWiki:GrowthMentors.json
Closed, ResolvedPublicFeature
Actions

Description

Feature summary (what you would like to be able to do and where):
Now, according to the history of edits, it is completely unclear what is happening with the list of mentors. Who left, who changed the message, who changed the weight. Because of this, the meaning of the history is lost.

https://ru.wikipedia.org/w/index.php?title=MediaWiki:GrowthMentors.json&action=history

Use case(s) (list the steps that you performed to discover that problem, and describe the actual underlying problem which you want to solve. Do not describe only a solution):
Go to https://ru.wikipedia.org/w/index.php?title=MediaWiki:GrowthMentors.json&action=history
Try to find who change their "automaticallyAssigned" status.

Benefits (why should this be implemented?):
More useful history, no need to go through every edit to figure out what happened.

Desired edit summaries

ActionDesired summaryCurrent summary
EnrollingAdding myself as a mentorSame as desired
Mentor changes mentorship propertiesChanging my mentorship options(none)
Removing a mentorRemoving ABC as a mentor: REASONREASON
Admin changes mentorship propertiesChanging ABC's mentorship options: REASONREASON

Details

SubjectRepoBranchLines +/-
Structured mentor list: Use meaningful edit summariesmediawiki/extensions/GrowthExperimentsmaster+295 -13
Customize query in gerrit

Event Timeline

Iniquity created this task.Nov 1 2022, 9:44 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 1 2022, 9:44 AM
Iniquity renamed this task from Make edit summary translatable and readable for MediaWiki:GrowthMentors.json to Make edit summary readable for MediaWiki:GrowthMentors.json.Nov 1 2022, 9:45 AM
Iniquity updated the task description. (Show Details)
Urbanecm_WMF subscribed.Nov 1 2022, 12:32 PM

Thanks again for the feedback @Iniquity! To me, this looks like we should improve edit summaries. Here is a list of common operations, and proposed summaries -- let me know what you think.

ActionDesired summaryCurrent summary
EnrollingAdding myself as a mentorSame as desired
Mentor changes mentorship propertiesChanging my mentorship options(none)
Removing a mentorRemoving ABC as a mentor: REASONREASON
Admin changes mentorship propertiesChanging ABC's mentorship options: REASONREASON

@Iniquity Do you think that "Mentor changes mentorship properties" and "Admin changes mentorship properties" need to be broken down to changes of message/weight/status? Or would only what is in the table now be helpful?

Urbanecm_WMF moved this task from New Tasks to Needs Discussion / Blocked on the GrowthExperiments-Mentorship board.Nov 1 2022, 12:40 PM
Urbanecm_WMF moved this task from Inbox to Needs Discussion on the Growth-Team board.

Moving to Needs Discussion (copies for the summaries, as well as whether "Mentor/admin changes mentorship properties" need to be broken down to individual changes needs to be decided).

Iniquity added a comment.Nov 1 2022, 5:27 PM
In T322115#8359567, @Urbanecm_WMF wrote:

Thanks again for the feedback @Iniquity! To me, this looks like we should improve edit summaries. Here is a list of common operations, and proposed summaries -- let me know what you think.

ActionDesired summaryCurrent summary
EnrollingAdding myself as a mentorSame as desired
Mentor changes mentorship propertiesChanging my mentorship options(none)
Removing a mentorRemoving ABC as a mentor: REASONREASON
Admin changes mentorship propertiesChanging ABC's mentorship options: REASONREASON

Is it possible to add gender support to these messages?

@Iniquity Do you think that "Mentor changes mentorship properties" and "Admin changes mentorship properties" need to be broken down to changes of message/weight/status? Or would only what is in the table now be helpful?

I think yes, it would be useful to show more fully: "Changing my mentorship options - weight: 2->3; automaticallyAssigned: true->false; welcome message was edited". And I think we need to add separate lines for self-deletion and admin-deletion.

kostajh moved this task from Needs Discussion to Triaged on the Growth-Team board.Jan 13 2023, 11:07 AM
kostajh subscribed.
In T322115#8359591, @Urbanecm_WMF wrote:

Moving to Needs Discussion (copies for the summaries, as well as whether "Mentor/admin changes mentorship properties" need to be broken down to individual changes needs to be decided).

Moving to Triaged, as we haven't had any movement on this task in two months. @Urbanecm_WMF your proposals look good to me, if you want to move forward with implementing, please feel free.

Urbanecm_WMF updated the task description. (Show Details)Jun 9 2023, 11:13 AM
Urbanecm_WMF triaged this task as Low priority.Jul 21 2023, 10:34 PM
Urbanecm_WMF moved this task from Needs Discussion / Blocked to Prioritized on the GrowthExperiments-Mentorship board.
gerritbot added a comment.Aug 7 2023, 11:00 AM

Change 946526 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Mentorship: Add meaningful comment summaries to GrowthMentors.json changes

https://gerrit.wikimedia.org/r/946526

gerritbot added a project: Patch-For-Review.Aug 7 2023, 11:00 AM
Urbanecm_WMF changed the task status from Open to In Progress.Aug 7 2023, 11:00 AM
Urbanecm_WMF edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.
Urbanecm_WMF moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.
Maintenance_bot moved this task from Prioritized to In Progress on the GrowthExperiments-Mentorship board.Aug 7 2023, 11:15 AM
Urbanecm_WMF claimed this task.Aug 7 2023, 11:35 AM
gerritbot added a comment.Sep 13 2023, 7:42 PM

Change 946526 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Structured mentor list: Use meaningful edit summaries

https://gerrit.wikimedia.org/r/946526

Urbanecm_WMF changed the task status from In Progress to Open.Sep 13 2023, 7:42 PM
Urbanecm_WMF moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.
Urbanecm_WMF moved this task from In Progress to Ready for QA on the GrowthExperiments-Mentorship board.
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.27; 2023-09-19).Sep 13 2023, 8:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 13 2023, 8:11 PM
Etonkovidova subscribed.EditedSep 26 2023, 1:20 AM

Desired edit summaries

ActionDesired summaryBefore the fix summarySummary displayed in wmf.27
EnrollingAdding myself as a mentorSame as desiredAdding myself as a mentor Tag: mentor list change
Mentor changes mentorship propertiesChanging my mentorship options(none)Changing my mentorship options Tag: mentor list change Note the history records change in mentor's Status, Number of mentees assigned to me, and Message to your mentees. Other changes - changes in Send praise are not recorded MediaWiki:GrowthMentors.json history
Removing a mentorRemoving ABC as a mentor: REASONREASONRemoving [user] as a mentor
Admin changes mentorship propertiesChanging ABC's mentorship options: REASONREASONChanging [user's] mentorship options Note: the message is generic; changing Away status is not recorded in the history.

@Urbanecm_WMF - to summarize the current state of added summaries in MediaWiki:GrowthMentors.json

  • "Changing my mentorship options"
    • Send praise changes are not recorded
    • the message Changing my mentorship options Tag: mentor list change doesn't indicate which options are changed, although it does indicate that a mentor changed the setting, not an admin
  • "Changing ABC's mentorship options: "
    • as the previous message ("Changing my mentorship options") it's generic
    • changes in Away status done by Admin are not recorded
Etonkovidova closed this task as Resolved.Sep 26 2023, 1:36 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL