Page MenuHomePhabricator
Create Task
Maniphest T322150

(Unplanned) Wikilove icon out of position in vector 2022
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To
ovasileva
Authored By
Esanders
Nov 1 2022, 3:57 PM
Tags
Referenced Files
F35801134: Screenshot 2022-11-19 at 9.08.09 AM.png
Nov 19 2022, 5:11 PM
F35801131: Screenshot 2022-11-19 at 9.09.46 AM.png
Nov 19 2022, 5:11 PM
F35737676: Screenshot 2022-11-09 at 7.28.11 PM.png
Nov 10 2022, 3:34 AM
F35737675: Screenshot 2022-11-09 at 7.27.50 PM.png
Nov 10 2022, 3:34 AM
F35691662: image.png
Nov 1 2022, 3:57 PM
F35691655: image.png
Nov 1 2022, 3:57 PM
Subscribers
Aklapper
Edtadros
Esanders
Jdlrobson

Description

With VectorVisualEnhancementNext=false:

image.png (65×173 px, 2 KB)

With VectorVisualEnhancementNext=true:

image.png (131×217 px, 6 KB)

QA Results - Beta

ACStatusDetails
1✅T322150#8385303

QA Results - Prod

ACStatusDetails
1✅T322150#8407672

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Fix icon position in vector 2022mediawiki/extensions/WikiLovemaster+3 -5
Customize query in gerrit

Related Objects
Search...

Event Timeline

Esanders created this task.Nov 1 2022, 3:57 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptNov 1 2022, 3:57 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a comment.Nov 1 2022, 3:59 PM

Change 851663 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/WikiLove@master] Fix icon position in vector 2022

https://gerrit.wikimedia.org/r/851663

gerritbot added a project: Patch-For-Review.Nov 1 2022, 3:59 PM
Esanders added a subscriber: Jdlrobson.Nov 1 2022, 3:59 PM
Jdlrobson added a project: Web-Team-Backlog-Archived (Kanbanana-2022-23-Q2).Nov 2 2022, 4:32 PM
Jdlrobson added a parent task: T320101: [M] Enable VectorVisualEnhancementsNext everywhere.
gerritbot added a comment.Nov 2 2022, 4:38 PM

Change 851663 merged by jenkins-bot:

[mediawiki/extensions/WikiLove@master] Fix icon position in vector 2022

https://gerrit.wikimedia.org/r/851663

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.10; 2022-11-14).Nov 2 2022, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.Nov 2 2022, 5:30 PM
Jdlrobson renamed this task from Wikilove icon out of position in vector 2022 to (Unplanned) Wikilove icon out of position in vector 2022.Nov 2 2022, 9:44 PM
Jdlrobson assigned this task to Edtadros.
Jdlrobson moved this task from Needs Analysis to QA on the Web-Team-Backlog-Archived (Kanbanana-2022-23-Q2) board.
LGoto set the point value for this task to 1.Nov 3 2022, 5:04 PM
Tgr moved this task from Inbox to Triaged on the Growth-Team board.Nov 5 2022, 6:32 AM
Edtadros moved this task from QA to QA in Prod on the Web-Team-Backlog-Archived (Kanbanana-2022-23-Q2) board.Nov 10 2022, 3:34 AM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: WikiLove icon should be correctly aligned vertically
With VectorVisualEnhancementNext=false:

Screenshot 2022-11-09 at 7.27.50 PM.png (338×1 px, 69 KB)

With VectorVisualEnhancementNext=true:
Screenshot 2022-11-09 at 7.28.11 PM.png (345×1 px, 71 KB)

LGoto triaged this task as High priority.Nov 15 2022, 6:05 PM
Edtadros reassigned this task from Edtadros to ovasileva.Nov 19 2022, 5:11 PM
Edtadros moved this task from QA in Prod to Ready for Signoff on the Web-Team-Backlog-Archived (Kanbanana-2022-23-Q2) board.
Edtadros subscribed.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: WikiLove icon should be correctly aligned vertically
With VectorVisualEnhancementNext=false:

Screenshot 2022-11-19 at 9.09.46 AM.png (335×1 px, 68 KB)

With VectorVisualEnhancementNext=true:
Screenshot 2022-11-19 at 9.08.09 AM.png (345×1 px, 67 KB)

Edtadros updated the task description. (Show Details)Nov 19 2022, 5:13 PM
ovasileva closed this task as Resolved.Nov 21 2022, 3:45 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits