Page MenuHomePhabricator

Remove language menu from sticky header on Talk pages
Closed, ResolvedPublic

Description

To-do

  • Remove the language menu from the sticky header on Talk pages (and any other pages that show the compact version of the language menu)
currentremoved
Screen Shot 2022-11-01 at 12.06.45 PM.png (276×1 px, 178 KB)
Screen Shot 2022-11-01 at 12.07.23 PM.png (280×1 px, 174 KB)

Context

Depending on the type of page you're on the language menu contains access to:

  • interlanguage links
  • interface language settings
  • translation interface

On Talk pages the language menu only contains access to interface language settings, and is therefore not as useful/needed as it is on some other kinds of pages. In T273144#6805993 we decided that a compact version of the language menu should still appear on Talk pages, and be in the same location as it is on article pages. However we then decided it is not necessary for the language menu to also be included in the sticky header on Talk pages (T316559#8352067).

Event Timeline

In T273144#6805993 we decided that a compact version of the language menu should still appear on Talk pages, and be in the same location as it is on article pages.

This doesn't appear to have been implemented as on https://en.wikipedia.org/wiki/Talk:Laika?useskin=vector-2022, I get a large "Add languages" button. Given that we don't typically language-link talk pages this seems like a bug:

image.png (109×407 px, 7 KB)

A later comment on that tasks suggests the language button would only show in the article namespace:

...

  • Language button only appears on the main namespace

...

but the acceptance criteria still listed a talk page as expecting the language button to show.

@Esanders sorry for the confusion. To clarify:

  • Currently the full version of the language menu appears on Talk pages (and renders as "Add languages")
  • The language team is in the process of updating that, and it will soon be the compact version of the language menu on Talk pages (T316559)
  • "Language button only appears on the main namespace" is outdated. The language menu will appear on all pages: if the page supports interlanguage links it will be the full version, if not (such as Talk pages) it will be the compact version

What does "talk pages" mean here? AFAIK the talk page discussions code runs on pages other than talk pages e.g. https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical) - how will these be handled?

I would suggest we hide the sticky version of the tool anywhere we would use the compact tool, i.e. all namespaces except main?

What does "talk pages" mean here? AFAIK the talk page discussions code runs on pages other than talk pages e.g. https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical) - how will these be handled?

"Talk pages" mean Talk pages. "Talk pages" do not mean Village pump. I'm not sure how else to phrase that.

I would suggest we hide the sticky version of the tool anywhere we would use the compact tool...

Yes, I think that mapping is correct. If a page has the compact version of the language menu, it should not include the language menu in the sticky header. I wrote this task to be about Talk pages specifically, because they seem like the highest visibility among the types of pages that will get the compact version of the language menu. But feel free to generalize it if that makes more sense.

i.e. all namespaces except main?

I don't think that is correct, because pages in namespaces other than Main (such as Wikipedia, Help, and Category) can have interlanguage links, and therefore get the full version of the language menu.

Examples of pages outside of the Main namespace that have interlanguage links:

cc @Pginer-WMF

I would suggest we hide the sticky version of the tool anywhere we would use the compact tool...

If a page has the compact version of the language menu, it should not include the language menu in the sticky header.

+1.

According to @Pginer-WMF the above may get covered (completely or partially) by T316559. It will identify the pages that cannot be connected across languages (translated, linked on Wikidata) and present a less prominent version of the language selector. Pau also says that, it makes sense for that version not to be included in the sticky header.

Change 901582 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/skins/Vector@master] Hide sticky header on non-subject pages

https://gerrit.wikimedia.org/r/901582

Change 901582 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Hide language menu in sticky header on non-subject pages

https://gerrit.wikimedia.org/r/901582

CC @Pginer-WMF The above has now been merged which implements the logic described by Alex and Peter in T322153#8387827. Let us know if you see any problems with this.

CC @Pginer-WMF The above has now been merged which implements the logic described by Alex and Peter in T322153#8387827. Let us know if you see any problems with this.

Sounds good. No concerns from my side. Thanks for pinging!

EAkinloose added a subscriber: EAkinloose.

✅ Remove the language menu from the sticky header on Talk pages (and any other pages that show the compact version of the language menu)

Hidden on Talk page

Screenshot 2023-04-21 at 23.20.32.png (524×3 px, 223 KB)

Full Language button as expected

Screenshot 2023-04-21 at 23.25.24.png (546×3 px, 289 KB)

EAkinloose claimed this task.
EAkinloose updated the task description. (Show Details)