| Jdlrobson | |
| Nov 1 2022, 8:39 PM |
| F35736398: Screen Recording 2022-11-09 at 9.39.17 AM.mov.gif | |
| Nov 10 2022, 12:59 AM |
| F35736395: Screen Recording 2022-11-09 at 9.43.36 AM.mov.gif | |
| Nov 10 2022, 12:59 AM |
| F35696990: Screen Shot 2022-11-02 at 10.44.02 AM.png | |
| Nov 2 2022, 2:48 PM |
| F35692999: Screen Shot 2022-11-01 at 1.38.42 PM.png | |
| Nov 1 2022, 8:39 PM |
Expected:
The table of contents should appear under the dropdown button.
Actual:
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T322162#8385092 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | ovasileva | T319376 [SPIKE] Would it be possible to build a toggle that allows users to expand and collapse the width of the page | |||
| Resolved | ovasileva | T319449 [M] Create toggle to control the fixed width of the content for Vector 2022 skin | |||
| Resolved | ovasileva | T322162 [M] Table of contents misaligned with max width disabled |
Let's analyze and discuss, but yes, I think it should be a blocker, at least for further rollout.
I took a look at this and I think the .mixin-column-full-width() in grid.less is doing a little too much.
I think we can fix this issue by remove the margin-left/right:auto in favour of setting
justify-self: start on .mw-table-of-contents-container and
justify-self: center; on .mw-content-container separately.
I noticed this while working on T317897 too, it seems to be to be a 1 line fix, adding .mw-table-of-contents-container to the selector here: https://github.com/wikimedia/Vector/blob/master/resources/skins.vector.styles/layouts/grid.less#L20
.mw-content-container,
.mw-table-of-contents-container {
...
}Change 854568 had a related patch set uploaded (by Nray; author: Nray):
[mediawiki/skins/Vector@master] Fix TOC misaligned when max width option is disable
Discussed in standup - will backport this, then continue with T320101: [M] Enable VectorVisualEnhancementsNext everywhere next week
Change 854568 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Fix TOC misaligned when max width option is disable
Change 855068 had a related patch set uploaded (by Nray; author: Nray):
[mediawiki/skins/Vector@wmf/1.40.0-wmf.8] Fix TOC misaligned when max width option is disable
Change 855068 merged by jenkins-bot:
[mediawiki/skins/Vector@wmf/1.40.0-wmf.8] Fix TOC misaligned when max width option is disable
Mentioned in SAL (#wikimedia-operations) [2022-11-09T21:26:35Z] <samtar@deploy1002> Started scap: Backport for [[gerrit:855068|Fix TOC misaligned when max width option is disable (T322162)]]
Mentioned in SAL (#wikimedia-operations) [2022-11-09T21:26:55Z] <samtar@deploy1002> samtar and nray: Backport for [[gerrit:855068|Fix TOC misaligned when max width option is disable (T322162)]] synced to the testservers: mwdebug2002.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet
Mentioned in SAL (#wikimedia-operations) [2022-11-09T21:35:24Z] <samtar@deploy1002> Finished scap: Backport for [[gerrit:855068|Fix TOC misaligned when max width option is disable (T322162)]] (duration: 08m 48s)
Per @ovasileva comment, I backported this today and so it is in production everwhere. Given that, I'm assuming this should be moved to qa in production
Status: ✅ PASS
Environment: enwiki
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA
Test Artifact(s):
Disable max-width preference
Visit https://en.wikipedia.org/wiki/Corps_Austria_Frankfurt_am_Main
Click "hide" on table of contents
✅ AC1: The table of contents should appear under the dropdown button.
