Page MenuHomePhabricator

NewImpact: Explore using Charts.css for sparkline
Closed, DeclinedPublic

Description

Let's explore if we can use the Charts CSS project (line component or area component) for implementing the sparklines in the NewImpact module.

Positives:

Negatives:

  • as it's CSS-only, there's no ability to add interactivity. That said, current designs don't include any interactivity for individual points on the line, so this is OK for the current iteration.

Acceptance Criteria

  1. Should be able to ....
  2. ....
Completion checklist

Functionality

  • The patches have been code reviewed and merged
  • The task passes its acceptance criteria

Engineering

  • There are existing and passing unit/integration tests
  • Tests for every involved patch should pass
  • Coverage for every involved project should have improved or stayed the same

Design & QA

  • If the task is UX/Design related: it must be reviewed and approved by the UX/Design team
  • Must be reviewed and approved by Quality Assurance.

Documentation

  • Related and updated documentation done where necessary

Event Timeline

kostajh triaged this task as Medium priority.Nov 2 2022, 12:11 PM
kostajh updated the task description. (Show Details)

I'm going to decline this one. If security review of d3 doesn't work out, we can revisit it.