Let's explore if we can use the Charts CSS project (line component or area component) for implementing the sparklines in the NewImpact module.
Positives:
- we don't need to wait for T318854: Application Security Review Request : d3.js
- even if T318854: Application Security Review Request : d3.js is approved, by using a CSS-only solution we'd have a smaller payload to deliver to clients, better for performance
Negatives:
- as it's CSS-only, there's no ability to add interactivity. That said, current designs don't include any interactivity for individual points on the line, so this is OK for the current iteration.
Acceptance Criteria
- Should be able to ....
- ....
Completion checklist
Functionality
- The patches have been code reviewed and merged
- The task passes its acceptance criteria
Engineering
- There are existing and passing unit/integration tests
- Tests for every involved patch should pass
- Coverage for every involved project should have improved or stayed the same
Design & QA
- If the task is UX/Design related: it must be reviewed and approved by the UX/Design team
- Must be reviewed and approved by Quality Assurance.
Documentation
- Related and updated documentation done where necessary
- Internal technical changes: internal repository documentation must be updated (README.md, JSDoc, PHPDoc)
- Infrastructure technical changes: technical changes that reflect on environment, infrastructure, endpoints or any other area of interest for technical contributors should be reflected on Extension:GrowthExperiments or Extension:GrowthExperiments/Technical documentation pages.