Page MenuHomePhabricator

QA page tools instrumentation
Closed, ResolvedPublic3 Estimated Story Points

Description

Background

We would like to check the page tools instrumentation prior to deploying the feature. This instrumentation will help us answer the questions outlined T321229: [EPIC] Article tools instrumentation and measurement plan and make subsequent decisions

Acceptance criteria

For an engineer:

  • Double check that every field in the page tools instrumentation spec has been instrumented
  • Flag any fields that need work
  • If all fields are instrumented, pass ticket to analyst

For analyst:

  • Ensure instrumentation works properly and all events appear as expected

What have been QA-ed

What have not been QA-ed

  • Collapse/uncollapse events

Because Collapse/uncollapse feature have not been deployed as of March 20, 2023.

Bugs/Potential Issues/Limitations

IssuesStatusNote
Clicks on Who Wrote That are not logged in schema✅ Confirmed with WEB team that it's OK not to logT322204#8700531, T322204#8712095
Clicks on the tool links under In other projects are not logged in schema✅ Confirmed with WEB team that it's OK not to logT322204#8700531, T322204#8712095
Unexpected events of clicking on old tool links (on left sidebar) from anonymous users in vector-2022 skinT322204#8706748

Current Vector 2022 Page Tools Events in Sidebar, as well as Dropdown (Logged In Users)

Page Tools placementSection clickDropdown button click[hide]/[move to sidebar] toggle click
Page Tools Dropdownt-{{section ID}}.unknown.pinnedui.dropdown-vector-page-tools-dropdownpinnable-header.vector-page-tools.pin
sticky headerN/AN/AN/A
sidebart-{{section id}}.unknown.pinnedN/Apinnable-header.vector-page-tools.unpin
Page Tools HamburgerN/AN/AN/A

Event Timeline

ovasileva triaged this task as Medium priority.Nov 2 2022, 12:16 PM
ovasileva created this task.
ovasileva moved this task from Incoming to Current Fiscal Year on the Web-Team-Backlog board.
QA pin and unpin page tool
Issue for discussion and investigation

We observed more events of unpin (event.name=‘pinnable-header.vector-page-tools.unpin’) than events of pin (‘event.name=pinnable-header.vector-page-tools.pin’). In theory, it should be the opposite if tools in dropdown menu is the default. Is it possible the event names are reversed? If not, what else can be the cause?

Instrumentation

The click on move to sidebar is to pin the page tool at the right sidebar, supposed to be logged with event.name=‘pinnable-header.vector-page-tools.pin’ in event.desktopwebuiactionstracking schema.

Screenshot 2023-03-10 at 1.31.32 PM.png (424×744 px, 69 KB)

Tha clicks on hide is to unpin the page tool, supposed to be logged with event.name= ‘pinnable-header.vector-page-tools.unpin’ in event.desktopwebuiactionstracking schema.

Screenshot 2023-03-10 at 1.32.01 PM.png (394×824 px, 62 KB)

Data

Daily clicks to pin/unpin the page tool

event_datepinnable-header.vector-page-tools.pinpinnable-header.vector-page-tools.unpin
2023-02-25133533
2023-02-26115552
2023-02-2795563
2023-02-2897549
2023-03-01105447
2023-03-0277422
2023-03-0382411
2023-03-04136454
2023-03-05103458
2023-03-0679366
2023-03-0799445
2023-03-0892417

image.png (962×1 px, 128 KB)

Daily unique sessions which pin/unpin the page tool

image.png (954×1 px, 131 KB)

Query
query_daily_pin <- "
SELECT TO_DATE(meta.dt) AS event_date,  event.name AS event_name, event.isAnon AS is_anon, COUNT(DISTINCT event.token) AS event_tokens, count(1) AS clicks
FROM event.desktopwebuiactionstracking
WHERe year=2023
AND event.action='click'
AND  event.name IN (
-- To pin the page tool to the right sidebar
'pinnable-header.vector-page-tools.pin' ,
-- To unpin the page tool
 'pinnable-header.vector-page-tools.unpin'
) 
GROUP BY TO_DATE(meta.dt) ,  event.name ,  event.isAnon
"
LGoto set the point value for this task to 3.Mar 13 2023, 5:15 PM
QA clicks on tool links
Instrumentation Note

The events will be logged in desktopwebuiactionstracking schema with below field value for each scenario.

Field valueScenario
event.name="{link_name}.vector-page-tools.unpinned" & event.skin='vector-2022'User clicks on a link on new tools menu (unpinned)
event.name="{link_name}.vector-page-tools.pinned" & event.skin='vector-2022'User clicks on a link on new tools on the right sidebar
event.name={link_name} & event.skin='vector'User clicks on a link under tools menu on the left sidebar
QA summary
  • The tool links which have logged events are marked with ✅ in below table
  • Clicks on Who Wrote That are not logged in schema, marked with ❓ in below table. Needs to confirm with WEB team.
  • The tool links under In other projects DON'T have click events logged in schema. The links are Wikimedia Commons,Wikibooks,Wikinews,Wikiquote,Wikisource,Wikiversity,Wikivoyage. Have confirmed with @ovasileva, it's OK that page tool analysis does not cover the events from other projects.
Page tools in Vector2022 skinPage tools in Vector legacy skin
Link nameNew page tools (unpinned)New page tools (pinned at right sidebar)Old tools (left sidebar)
What links here✅t-whatlinkshere.vector-page-tools.unpinned✅ t-whatlinkshere.vector-page-tools.pinned✅ t-whatlinkshere
Related changes✅ t-recentchangeslinked.vector-page-tools.unpinned✅ t-recentchangeslinked.vector-page-tools.pinned✅ t-recentchangeslinked
Special pages✅ t-specialpages.vector-page-tools.unpinned✅t-specialpages.vector-page-tools.pinned✅ t-specialpages
Permanent link✅t-permalink.vector-page-tools.unpinned✅t-permalink.vector-page-tools.pinned✅t-permalink
Page information✅t-info.vector-page-tools.unpinned✅ t-info.vector-page-tools.pinned✅t-info
Cite this page✅ t-cite.vector-page-tools.unpinned✅ t-cite.vector-page-tools.pinned✅t-cite
Wikidata item✅t-wikibase.vector-page-tools.unpinned✅t-wikibase.vector-page-tools.pinned✅ t-wikibase
Who Wrote That❓ t-whowrotethat.vector-page-tools.unpinned❓t-whowrotethat.vector-page-tools.pinned❓t-whowrotethat
Delete✅ca-delete.vector-page-tools.unpinned✅ca-delete.vector-page-tools.pinned✅ca-delete
Move✅ca-move.vector-page-tools.unpinned✅ca-move.vector-page-tools.pinned✅ca-move
Change protection✅ca-unprotect.vector-page-tools.unpinned✅ca-unprotect.vector-page-tools.pinned✅ca-unprotect
Download as PDF✅coll-download-as-rl.vector-page-tools.unpinned✅coll-download-as-rl.vector-page-tools.pinned✅coll-download-as-rl
Printable version✅t-print.vector-page-tools.unpinned✅t-print.vector-page-tools.pinned✅t-print
In other projects
Wikimedia CommonsNot loggingNot loggingNot logging
WikibooksNot loggingNot loggingNot logging
WikinewsNot loggingNot loggingNot logging
WikiquoteNot loggingNot loggingNot logging
WikisourceNot loggingNot loggingNot logging
WikiversityNot loggingNot loggingNot logging
WikivoyageNot loggingNot loggingNot logging
QA breakdown dimensions for tool link click events
QA Summary
What has been checkedStatusNote
Events by date✅PASSEvents are available since 2023-01-17.
Events by wiki✅PASSAs of March 14th, 2023, schema logged tool click events from 719 wikis.
Events by isAnonUnexpected events of clicks on old tool links from anonymous users in vector-2022 skin.
Events by edit bucket✅PASS
Potential Issues/Limitations
  • Unexpected events of clicks on old tool links (on left sidebar) from anonymous users in vector-2022 skin.

Old tool links are supposed to be only available in vector skin not vector-2022 skin. Now we received events of clicks on old tool links from both vector and vector-2022 skin by anonymous users, . These events occurred on all types of tool links located on the left sidebar.

Below table shows the number of click events from anonymous users on English WIkipedia by skin and link name

skinis_anonnameevent_tokensclicks
vectorTRUEt-cite3334
vectorTRUEt-info2729
vectorTRUEt-wikibase110124
vectorTRUEt-specialpages1313
vectorTRUEcoll-download-as-rl242256
vectorTRUEt-recentchangeslinked1112
vectorTRUEt-print3942
vectorTRUEt-whatlinkshere3233
vector-2022TRUEt-info334386
vector-2022TRUEt-cite269335
vector-2022TRUEt-wikibase9935101
vector-2022TRUEt-whatlinkshere443513
vector-2022TRUEt-specialpages216261
vector-2022TRUEt-recentchangeslinked130165
vector-2022TRUEt-print602769
vector-2022TRUEcoll-download-as-rl41095355

Daily trend of clicks on old tool links (on left sidebar) on English Wikipedia

image.png (964×1 px, 145 KB)

Query

query_enwiki_anon <- "
SELECT event.skin , event.isAnon AS is_anon,  event.name, 
COUNT(DISTINCT event.token) AS event_tokens, count(1) AS clicks
FROM event.desktopwebuiactionstracking
WHERe year=2023
AND event.action='click'
AND event.name IN 
(
't-whatlinkshere',
't-recentchangeslinked',
't-specialpages',
't-permalink-page-tools',
't-info',
't-cite',
't-wikibase',
't-whowrotethat',
'ca-delete',
'ca-move',
'ca-unprotect',
'coll-download-as-rl',
't-print'
)
AND wiki='enwiki'  AND event.isAnon  
GROUP BY event.skin , event.isAnon, event.name
ORDER BY event.skin
LIMIT 10000
"

*Note
Logged-in users had the similar issue before but it has been fixed. There were events logged for clicks on old tool links in vector-2022 skin by logged-in users between 2023-01-18 and 2023-02-18. Data has been clean since 2023-02-19. Since then, events for old tool links have been only logged for vector skin. For future analysis, we should exclude the data between 2023-01-18 and 2023-02-18.

Have discussed the data trends of pin and unpin events (mentioned in T322204#8684502) with engineer. The pinned tool bar is the default in vector2022 as of March 2023. Therefore, it's expected to have more events of unpin (event.name=‘pinnable-header.vector-page-tools.unpin’) than events of pin (‘event.name=pinnable-header.vector-page-tools.pin’). It's not an issue.

QA breakdown dimensions for pin/unpin events
QA Summary
What has been checkedStatusNote
Events by date✅PASSEvents are available since 2023-01-12.
Events by wiki✅PASSAs of March 9th, 2023, schema logged tool click events from 330 wikis.
Events by isAnon✅PASSOnly log for logged-in users in vector-2022. [1]
Events by edit bucket✅PASS

[1] Note:
There is one event logged for anonymous users from enwiki on 2023-01-28, logged as dt: 2023-01-28T18:16:08.593Z "isanon":true,"editcountbucket":"1-4 edits". It should be a wrong data entry as anonymous users should be in 0 edits bucket. We will exclude it in future analysis.

jwang edited projects, added Product-Analytics (Kanban); removed Product-Analytics.
jwang updated the task description. (Show Details)
QA clicks on tool links
QA summary
  • Clicks on Who Wrote That are not logged in schema, marked with ❓ in below table. Needs to confirm with WEB team.

Per discussion with engineer, Who Wrote That is part of browser extension. It's ok not to log.

Page tools in Vector2022 skinPage tools in Vector legacy skin
Link nameNew page tools (unpinned)New page tools (pinned at right sidebar)Old tools (left sidebar)
Who Wrote Thatt-whowrotethat.vector-page-tools.unpinned , NOT LOGGINGt-whowrotethat.vector-page-tools.pinned , NOT LOGGINGt-whowrotethat , NOT LOGGING

After conducting QA, it seems page tools links are firing slightly incorrect syntax in production.

Example: On clicking the "Download as PDF" link in the right sidebar (when Page Tools is pinned), the following event fires: event.action="coll-download-as-rl.unknown.pinned"

The TOC version of this bug has been documented in T332612. Page tools should probably be addressed alongside TOC. cc: @Jdrewniak